Remove unix_socket dependency #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 1.70.0, the SocketAddrExt trait [0] provides ways to create a socket address for Unix sockets with abstract names. [0]: https://doc.rust-lang.org/std/os/linux/net/trait.SocketAddrExt.html Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
When creating a new Unix socket, don't allocate a new String needlessly. Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
Pull Request Test Coverage Report for Build 12485070824Details
💛 - Coveralls |
|
@epilys Seems the CI in master is failing consistently after this PR was merged. Could you please have a look? |
|
@zeenix it seems like a flaky test? The PR CI didn't timeout on |
|
@zeenix FWIW I was able to get the exact same test timeout on the commit before this PR was merged by running it a bunch of times locally. |
Oh interesting. Will have a look when/if it comes up failing again. If you have the time, please do have a look into it. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 1.70.0, the
SocketAddrExttrait provides ways to create asocket address for Unix sockets with abstract names: https://doc.rust-lang.org/std/os/linux/net/trait.SocketAddrExt.html