Convert ignore rustdoc tests to no_run
#118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
epilys
force-pushed
the
unignore-tests
branch
from
4135d0c to
6b56c1d
Compare
Pull Request Test Coverage Report for Build 12507932881Details
💛 - Coveralls |
epilys
force-pushed
the
unignore-tests
branch
2 times, most recently
from
a4125e9 to
29b04ca
Compare
Currently, varlink_file! macro takes as argument either an absolute path or a relative path to the current working directory. This can be different depending on the Rust/Cargo version. The documentation says it is relative to the workspace directory, but that isn't true for the MSRV 1.70.0. This commit inspects the env var CARGO_MANIFEST_DIR, if it is defined, and prepends it to the given filename to create an absolute path. This way, the behavior of the macro is consistent. Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
Print descriptive errors when a file operation fails in varlink_file! macro. Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
Rewrite parts of module and macro rustdocs to make the formatting more idiomatic and also explain the macro arguments better. Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
Convert `ignore` rustdoc tests to `no_run` by adding missing code to make compilation work. Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
Change inline code block from `norun` to `shell`, and add code backticks to "<varlink_file>". Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
Remove unnecessary String allocation in varlink-certification tests Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
epilys
force-pushed
the
unignore-tests
branch
from
29b04ca to
645d250
Compare
zeenix
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert
ignorerustdoc tests tono_runby adding missing code tomake compilation work.
Depends on #117