chore: refactor XML payload into RequestFactory #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also correct the type hints to clarify that it accepts any Iterable.
jorwoods
commented
Jul 20, 2025
| password=password, | ||
| embed_password=embed_password, | ||
| ) | ||
| response = self.put_request(url, request_body) |
There was a problem hiding this comment.
The response doesn't seem to get used. Can you give me an example response XML?
There was a problem hiding this comment.
The response is just a success message, so not necessarily needs to be used.
| f"Updated connections for datasource {datasource_item.id}: {', '.join(connection_luids)}" | ||
| ) | ||
| logger.info(f"Updated connections for datasource {datasource_item.id}: {', '.join(connection_luids)}") | ||
| return connection_luids |
There was a problem hiding this comment.
As outlined in this PR, the function works with any Iterable[str], not just a list. The only problem is if the user were to pass in an Iterator, the Iterator gets consumed by this function and returns an exhausted Iterator. If the connection ids are in the response, we can generate it from the response and have it work in the general case.
vchavatapalli
merged commit 8ee48d1
into
vchavatapalli:Adding-new-update-connections-api
19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also correct the type hints to clarify that it accepts any Iterable.