Merges .go-sdl2-libs as part of the repository #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes static and/or cross-platform build when using the new Go Module system as it doesn't fetch the (previously) sub-module go-sdl2-libs. Signed-off-by: Lilis Iskandar <lilis@veand.co>
|
Hi, Sure, this is fine, a simple change. It does add some weight in MB to the repo, but that should not be a big issue. |
|
Yeah, it will add quite a bit to the Git repo. I'm hopeful that since Go is making the Module system the default in Go 1.13, users won't notice the difference since they're going to download only the files without history 😁 Alright then, I'm merging it! |
neputevshina
pushed a commit
to neputevshina/go-sdl2
that referenced
this pull request
Nov 13, 2024
This fixes static and/or cross-platform build when using the new Go Module system as it doesn't fetch the (previously) sub-module go-sdl2-libs. Signed-off-by: Lilis Iskandar <lilis@veand.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes static and/or cross-platform build when using the new Go
Module system as it doesn't fetch the (previously) sub-module
go-sdl2-libs.
I thought that this is straightforward but perhaps it's good to have an okay from @gen2brain. I should not have asked him to make it into sub-module 😹