Add Gray code to modems : close both veeresht/CommPy#100 and veeresht/CommPy#60. #102
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation based on the code from @edsonportosilva in #100. I refactored the code and simplified it a bit.
The Gray code is the new default for both QAM and PSK modems. I have no time to add tests based on performances but
modem.plot_constellation
show a proper Gray code.I'll merge this PR as soon as @veeresht, @kirlf and/or @edsonportosilva validate my code.
Close both #100 and #60.