Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEXT-689] next dev rewrites isolatedModules to true in tsconfig with typescript 5 option verbatimModuleSyntax set to true #46509

Closed
1 task done
m1tyya opened this issue Feb 27, 2023 · 3 comments · Fixed by #48018
Labels
bug Issue was opened via the bug report template. linear: next Confirmed issue that is tracked by the Next.js team. locked

Comments

@m1tyya
Copy link

m1tyya commented Feb 27, 2023

Verify canary release

  • I verified that the issue exists in the latest Next.js canary release

Provide environment information

Operating System:
  Platform: win32
  Arch: x64
  Version: Windows 10 Pro
Binaries:
  Node: 18.9.1
  npm: N/A
  Yarn: N/A
  pnpm: N/A
Relevant packages:
  next: 13.2.1
  eslint-config-next: N/A
  react: 18.2.0
  react-dom: 18.2.0

Which area(s) of Next.js are affected? (leave empty if unsure)

CLI (create-next-app)

Link to the code that reproduces this issue

https://github.com/m1tyya/next-typescript5-bug

To Reproduce

  1. Clone repo and install dependencies.
  2. Run yarn dev and see changes in tsconfig.json.

Describe the Bug

Typescript 5 has a new option verbatimModuleSyntax which makes isolatedModules redundant. However, starting a dev server sets isolatedModules to true.

Expected Behavior

Not setting isolatedModules value.

Which browser are you using? (if relevant)

No response

How are you deploying your application? (if relevant)

No response

NEXT-689

@m1tyya m1tyya added the bug Issue was opened via the bug report template. label Feb 27, 2023
@timneutkens timneutkens added the linear: next Confirmed issue that is tracked by the Next.js team. label Feb 28, 2023
@timneutkens timneutkens changed the title next dev rewrites isolatedModules to true in tsconfig with typescript 5 option verbatimModuleSyntax set to true [NEXT-689] next dev rewrites isolatedModules to true in tsconfig with typescript 5 option verbatimModuleSyntax set to true Feb 28, 2023
@wiesson
Copy link
Contributor

wiesson commented Mar 28, 2023

I just want to notice that it happens with next build as well

@kodiakhq kodiakhq bot closed this as completed in #48018 Jun 9, 2023
kodiakhq bot pushed a commit that referenced this issue Jun 9, 2023
### What?

When `verbatimModuleSyntax: true` is set, `isolatedModules: true` are not allowed by TS

### Why?

Next always adds `isolatedModules: true` which causes TS error.

### How?

- Fixes #46509

fix NEXT-689

Co-authored-by: Steven <229881+styfle@users.noreply.github.com>
@belgattitude
Copy link
Contributor

Note that when extending a tsonfig.base.ts, it's still required to add explicitly "verbatimModuleSyntax": true, in the app tsconfig.json. As tested with next 13.4.6

@github-actions
Copy link
Contributor

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue was opened via the bug report template. linear: next Confirmed issue that is tracked by the Next.js team. locked
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants