Update Firebase Auth Example for New Env Support #13587

Remeic · 2020-05-30T16:54:18Z

Prefixed variables name with NEXT_PUBLIC_.

Solving #13585 issue related to get undefined from process.env.VARNAME inside .env* files.

I'm not secure if SESSION_SECRET_* need the prefix.

Prefix variables name with NEXT_PUBLIC_ to align with Nextjs 9.4

lfades

Hi @Remeic thank you for the PR, please make the following changes:

Rename .env.example to .env.local.example as it should be used to create a .env.local file instead of .env. You can still use .env for defaults (keys that aren't secret and can be safely pushed to a repository)
If a key is secret and is not supposed to be used by the UI, don't add NEXT_PUBLIC_ to it, e.g: NEXT_PUBLIC_SESSION_SECRET_CURRENT should not be having the prefix.
Remove next.config.js, you can access the environment variables directly thanks to the new Environment Variables support

…iable Remove empty next.config.js file, Next 9.4 can directly access to env variables Remove NEXT_PUBLIC prefix from SESSION_SECRET_*, these variable can't be public

Remeic · 2020-05-30T20:55:30Z

Hi @Remeic thank you for the PR, please make the following changes:

Rename .env.example to .env.local.example as it should be used to create a .env.local file instead of .env. You can still use .env for defaults (keys that aren't secret and can be safely pushed to a repository)

If a key is secret and is not supposed to be used by the UI, don't add NEXT_PUBLIC_ to it, e.g: NEXT_PUBLIC_SESSION_SECRET_CURRENT should not be having the prefix.

Remove next.config.js, you can access the environment variables directly thanks to the new Environment Variables support

Thanks @lfades for helping me with one of my first public PR!
Removed next.config.js file and prefix from secret session variable.
If i can do more, don't hesitate!
Thanks again

examples/with-firebase-authentication/.env.local.example

examples/with-firebase-authentication/utils/middleware/cookieSession.js

Remove NEXT_PUBLIC wrong prefix from secret key inside .env.local.example Remove NEXT_PUBLIC wrong prefix from cookieSession, session secrets

…se_env_var

ijjk · 2020-06-02T16:04:13Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
buildDuration	13s	12.7s	-283ms
nodeModulesSize	66.3 MB	66.3 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.269	2.333	⚠️ +0.06
/ avg req/sec	1101.57	1071.75	-29.82
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.358	1.424	⚠️ +0.07
/error-in-render avg req/sec	1841.22	1756.08	-85.14

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
main-HASH.js gzip	6.59 kB	6.59 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..6c2a.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
main-HASH.module.js gzip	5.67 kB	5.67 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.21 kB	8.21 kB	✓

Client Pages Modern

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.51 kB	1.51 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.32 kB	5.32 kB	✓

Client Build Manifests

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
index.html gzip	925 B	925 B	✓
link.html gzip	936 B	936 B	✓
withRouter.html gzip	923 B	923 B	✓
Overall change	2.78 kB	2.78 kB	✓

Serverless Mode

General

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
buildDuration	14s	14.1s	⚠️ +86ms
nodeModulesSize	66.3 MB	66.3 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
main-HASH.js gzip	6.59 kB	6.59 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..6c2a.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
main-HASH.module.js gzip	5.67 kB	5.67 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.21 kB	8.21 kB	✓

Client Pages Modern

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.51 kB	1.51 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.32 kB	5.32 kB	✓

Client Build Manifests

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
_error.js	878 kB	878 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	879 kB	879 kB	✓
link.js	916 kB	916 kB	✓
routerDirect.js	909 kB	909 kB	✓
withRouter.js	909 kB	909 kB	✓
Overall change	4.5 MB	4.5 MB	✓

Remeic · 2020-06-02T16:11:39Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Remeic/next.js hotfix/firebase_env_var Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.269 2.333 ⚠️ +0.06
/ avg req/sec 1101.57 1071.75 -29.82
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.358 1.424 ⚠️ +0.07
/error-in-render avg req/sec 1841.22 1756.08 -85.14
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless Mode

General
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles

Hi @ijjk can i solve this increase of page load time in some way?

ijjk · 2020-06-02T16:13:40Z

@Remeic that stat is variable since it's run in a shared environment and your changes aren't related so no need to address it

…firebase_env_var

ijjk · 2020-06-04T04:56:19Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
buildDuration	10.1s	10.3s	⚠️ +263ms
nodeModulesSize	66 MB	66 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.881	1.735	-0.15
/ avg req/sec	1329.1	1441.08	⚠️ +111.98
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.066	0.989	-0.08
/error-in-render avg req/sec	2345.85	2527.98	⚠️ +182.13

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
main-HASH.js gzip	6.59 kB	6.59 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..6c2a.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
main-HASH.module.js gzip	5.67 kB	5.67 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.21 kB	8.21 kB	✓

Client Pages Modern

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.51 kB	1.51 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.32 kB	5.32 kB	✓

Client Build Manifests

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
index.html gzip	924 B	924 B	✓
link.html gzip	934 B	934 B	✓
withRouter.html gzip	922 B	922 B	✓
Overall change	2.78 kB	2.78 kB	✓

Serverless Mode

General

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
buildDuration	11.5s	11.6s	⚠️ +91ms
nodeModulesSize	66 MB	66 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
main-HASH.js gzip	6.59 kB	6.59 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..6c2a.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
main-HASH.module.js gzip	5.67 kB	5.67 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.21 kB	8.21 kB	✓

Client Pages Modern

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.51 kB	1.51 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.32 kB	5.32 kB	✓

Client Build Manifests

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
_error.js	878 kB	878 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	879 kB	879 kB	✓
link.js	916 kB	916 kB	✓
routerDirect.js	909 kB	909 kB	✓
withRouter.js	909 kB	909 kB	✓
Overall change	4.5 MB	4.5 MB	✓

lfades

Thank you!

ijjk · 2020-06-04T06:51:18Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
buildDuration	13.3s	12.3s	-923ms
nodeModulesSize	66 MB	66 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.147	2.201	⚠️ +0.05
/ avg req/sec	1164.26	1135.77	-28.49
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.356	1.365	⚠️ +0.01
/error-in-render avg req/sec	1844.08	1832.09	-11.99

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
main-HASH.js gzip	6.59 kB	6.59 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..6c2a.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
main-HASH.module.js gzip	5.67 kB	5.67 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.21 kB	8.21 kB	✓

Client Pages Modern

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.51 kB	1.51 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.32 kB	5.32 kB	✓

Client Build Manifests

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
index.html gzip	924 B	924 B	✓
link.html gzip	934 B	934 B	✓
withRouter.html gzip	922 B	922 B	✓
Overall change	2.78 kB	2.78 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
buildDuration	13.3s	13.2s	-65ms
nodeModulesSize	66 MB	66 MB	⚠️ +2.79 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
main-HASH.js gzip	6.59 kB	6.59 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..6c2a.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
main-HASH.module.js gzip	5.67 kB	5.67 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.21 kB	8.21 kB	✓

Client Pages Modern

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.51 kB	1.51 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.32 kB	5.32 kB	✓

Client Build Manifests

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
_error.js	878 kB	878 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	879 kB	879 kB	✓
link.js	916 kB	916 kB	✓
routerDirect.js	909 kB	909 kB	✓
withRouter.js	909 kB	909 kB	✓
Overall change	4.5 MB	4.5 MB	✓

ijjk · 2020-06-04T06:52:34Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
buildDuration	13.2s	13.3s	⚠️ +124ms
nodeModulesSize	66 MB	66 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.378	2.309	-0.07
/ avg req/sec	1051.3	1082.65	⚠️ +31.35
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.565	1.442	-0.12
/error-in-render avg req/sec	1597.69	1733.12	⚠️ +135.43

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
main-HASH.js gzip	6.59 kB	6.59 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..6c2a.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
main-HASH.module.js gzip	5.67 kB	5.67 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.21 kB	8.21 kB	✓

Client Pages Modern

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.51 kB	1.51 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.32 kB	5.32 kB	✓

Client Build Manifests

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
index.html gzip	924 B	924 B	✓
link.html gzip	934 B	934 B	✓
withRouter.html gzip	922 B	922 B	✓
Overall change	2.78 kB	2.78 kB	✓

Serverless Mode

General

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
buildDuration	14.4s	14.2s	-219ms
nodeModulesSize	66 MB	66 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
main-HASH.js gzip	6.59 kB	6.59 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..6c2a.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
main-HASH.module.js gzip	5.67 kB	5.67 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.21 kB	8.21 kB	✓

Client Pages Modern

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.51 kB	1.51 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.32 kB	5.32 kB	✓

Client Build Manifests

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	vercel/next.js canary	Remeic/next.js hotfix/firebase_env_var	Change
_error.js	878 kB	878 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	879 kB	879 kB	✓
link.js	916 kB	916 kB	✓
routerDirect.js	909 kB	909 kB	✓
withRouter.js	909 kB	909 kB	✓
Overall change	4.5 MB	4.5 MB	✓

Prefixed variables name with NEXT_PUBLIC_. Solving vercel#13585 issue related to get undefined from process.env.VARNAME inside .env* files. I'm not secure if SESSION_SECRET_* need the prefix.

Fix, rename var name inside .env.example

4e4cb14

Prefix variables name with NEXT_PUBLIC_ to align with Nextjs 9.4

Remeic requested review from lfades and Timer as code owners May 30, 2020 16:54

lfades requested changes May 30, 2020

View reviewed changes

Fix, remove next.config.js, remove NEXT_PUBLIC prefix from secret var…

2198586

…iable Remove empty next.config.js file, Next 9.4 can directly access to env variables Remove NEXT_PUBLIC prefix from SESSION_SECRET_*, these variable can't be public

Merge branch 'canary' into hotfix/firebase_env_var

782997b

lfades reviewed Jun 1, 2020

View reviewed changes

examples/with-firebase-authentication/.env.local.example Outdated Show resolved Hide resolved

lfades reviewed Jun 1, 2020

View reviewed changes

examples/with-firebase-authentication/utils/middleware/cookieSession.js Outdated Show resolved Hide resolved

Remeic added 2 commits June 2, 2020 17:54

Fix, remove some wrong NEXT_PUBLIC prefixes

81466fb

Remove NEXT_PUBLIC wrong prefix from secret key inside .env.local.example Remove NEXT_PUBLIC wrong prefix from cookieSession, session secrets

Merge branch 'canary' of github.com:vercel/next.js into hotfix/fireba…

889bbce

…se_env_var

Timer requested a review from lfades June 2, 2020 16:19

rafaelalmeidatk added the examples Issue/PR related to examples label Jun 3, 2020

Merge branch 'canary' of https://github.com/zeit/next.js into hotfix/…

be8eaf8

…firebase_env_var

Remeic requested review from chibicode, ijjk and timneutkens as code owners June 4, 2020 04:49

Timer added this to the 9.4.5 milestone Jun 4, 2020

Fixes and updated readme

eb6c907

Timer assigned lfades Jun 4, 2020

lfades approved these changes Jun 4, 2020

View reviewed changes

Merge branch 'canary' into hotfix/firebase_env_var

f7689a8

Timer changed the title ~~Fix Rename var name inside .env.example #13585~~ Update Firebase Auth Example for New Env Support Jun 4, 2020

kodiakhq bot merged commit 00eef17 into vercel:canary Jun 4, 2020

vercel locked as resolved and limited conversation to collaborators Jan 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Firebase Auth Example for New Env Support #13587

Update Firebase Auth Example for New Env Support #13587

Remeic commented May 30, 2020

lfades left a comment

Remeic commented May 30, 2020

ijjk commented Jun 2, 2020

Remeic commented Jun 2, 2020

Stats from current PR

ijjk commented Jun 2, 2020

ijjk commented Jun 4, 2020

lfades left a comment

ijjk commented Jun 4, 2020

ijjk commented Jun 4, 2020

Update Firebase Auth Example for New Env Support #13587

Update Firebase Auth Example for New Env Support #13587

Conversation

Remeic commented May 30, 2020

lfades left a comment

Choose a reason for hiding this comment

Remeic commented May 30, 2020

ijjk commented Jun 2, 2020

Stats from current PR

Remeic commented Jun 2, 2020

Stats from current PR

ijjk commented Jun 2, 2020

ijjk commented Jun 4, 2020

Stats from current PR

lfades left a comment

Choose a reason for hiding this comment

ijjk commented Jun 4, 2020

Stats from current PR

ijjk commented Jun 4, 2020

Stats from current PR