Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates thre three-js example with drei and modules transpilation #14864

Merged
merged 8 commits into from
Jul 8, 2020
Merged

Updates thre three-js example with drei and modules transpilation #14864

merged 8 commits into from
Jul 8, 2020

Conversation

gsimone
Copy link
Contributor

@gsimone gsimone commented Jul 5, 2020

Hi, we received some issues on the react-three-fiber and drei repos, mentioning broken ssr because of some examples where we import three's examples - like to implement loaders or controls.

This PR adds a next.config suggested by many that transpiles everything in three, drei and postprocessing.

I also added some code from drei that shows how controls and effects can be easily added.

@ijjk ijjk added the examples Issue/PR related to examples label Jul 5, 2020
@ijjk
Copy link
Member

ijjk commented Jul 5, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary gsimone/next.js canary Change
buildDuration 13s 12.9s -95ms
nodeModulesSize 66.1 MB 66.1 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary gsimone/next.js canary Change
/ failed reqs 0 0
/ total time (seconds) 2.212 2.253 ⚠️ +0.04
/ avg req/sec 1130.36 1109.59 ⚠️ -20.77
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.417 1.487 ⚠️ +0.07
/error-in-render avg req/sec 1764.12 1681.49 ⚠️ -82.63
Client Bundles (main, webpack, commons)
vercel/next.js canary gsimone/next.js canary Change
main-HASH.js gzip 6.63 kB 6.63 kB
webpack-HASH.js gzip 751 B 751 B
19b7e98f51cc..18e4.js gzip 10.7 kB 10.7 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57.2 kB 57.2 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary gsimone/next.js canary Change
main-HASH.module.js gzip 5.71 kB 5.71 kB
webpack-HASH..dule.js gzip 751 B 751 B
19b7e98f51cc..dule.js gzip 7.09 kB 7.09 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.7 kB 52.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary gsimone/next.js canary Change
polyfills-HASH.js gzip 26.4 kB 26.4 kB
Overall change 26.4 kB 26.4 kB
Client Build Manifests
vercel/next.js canary gsimone/next.js canary Change
_buildManifest.js gzip 268 B 268 B
_buildManife..dule.js gzip 272 B 272 B
Overall change 540 B 540 B
Rendered Page Sizes
vercel/next.js canary gsimone/next.js canary Change
index.html gzip 954 B 954 B
link.html gzip 958 B 958 B
withRouter.html gzip 945 B 945 B
Overall change 2.86 kB 2.86 kB

Serverless Mode
General
vercel/next.js canary gsimone/next.js canary Change
buildDuration 13.9s 13.9s ⚠️ +90ms
nodeModulesSize 66.1 MB 66.1 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary gsimone/next.js canary Change
main-HASH.js gzip 6.63 kB 6.63 kB
webpack-HASH.js gzip 751 B 751 B
19b7e98f51cc..18e4.js gzip 10.7 kB 10.7 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57.2 kB 57.2 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary gsimone/next.js canary Change
main-HASH.module.js gzip 5.71 kB 5.71 kB
webpack-HASH..dule.js gzip 751 B 751 B
19b7e98f51cc..dule.js gzip 7.09 kB 7.09 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.7 kB 52.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary gsimone/next.js canary Change
polyfills-HASH.js gzip 26.4 kB 26.4 kB
Overall change 26.4 kB 26.4 kB
Client Build Manifests
vercel/next.js canary gsimone/next.js canary Change
_buildManifest.js gzip 268 B 268 B
_buildManife..dule.js gzip 272 B 272 B
Overall change 540 B 540 B
Serverless bundles
vercel/next.js canary gsimone/next.js canary Change
_error.js 876 kB 876 kB
404.html 4.17 kB 4.17 kB
hooks.html 3.79 kB 3.79 kB
index.js 876 kB 876 kB
link.js 915 kB 915 kB
routerDirect.js 908 kB 908 kB
withRouter.js 908 kB 908 kB
Overall change 4.49 MB 4.49 MB
Commit: cbf77d4

@ijjk
Copy link
Member

ijjk commented Jul 5, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary gsimone/next.js canary Change
buildDuration 13.3s 13.4s ⚠️ +127ms
nodeModulesSize 66.1 MB 66.1 MB
Page Load Tests Overall increase ✓
vercel/next.js canary gsimone/next.js canary Change
/ failed reqs 0 0
/ total time (seconds) 2.399 2.285 -0.11
/ avg req/sec 1042.09 1093.93 +51.84
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.526 1.546 ⚠️ +0.02
/error-in-render avg req/sec 1638.74 1616.91 ⚠️ -21.83
Client Bundles (main, webpack, commons)
vercel/next.js canary gsimone/next.js canary Change
main-HASH.js gzip 6.63 kB 6.63 kB
webpack-HASH.js gzip 751 B 751 B
19b7e98f51cc..18e4.js gzip 10.7 kB 10.7 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57.2 kB 57.2 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary gsimone/next.js canary Change
main-HASH.module.js gzip 5.71 kB 5.71 kB
webpack-HASH..dule.js gzip 751 B 751 B
19b7e98f51cc..dule.js gzip 7.09 kB 7.09 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.7 kB 52.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary gsimone/next.js canary Change
polyfills-HASH.js gzip 26.4 kB 26.4 kB
Overall change 26.4 kB 26.4 kB
Client Build Manifests
vercel/next.js canary gsimone/next.js canary Change
_buildManifest.js gzip 268 B 268 B
_buildManife..dule.js gzip 272 B 272 B
Overall change 540 B 540 B
Rendered Page Sizes
vercel/next.js canary gsimone/next.js canary Change
index.html gzip 954 B 954 B
link.html gzip 958 B 958 B
withRouter.html gzip 945 B 945 B
Overall change 2.86 kB 2.86 kB

Serverless Mode
General
vercel/next.js canary gsimone/next.js canary Change
buildDuration 14.4s 14.3s -133ms
nodeModulesSize 66.1 MB 66.1 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary gsimone/next.js canary Change
main-HASH.js gzip 6.63 kB 6.63 kB
webpack-HASH.js gzip 751 B 751 B
19b7e98f51cc..18e4.js gzip 10.7 kB 10.7 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57.2 kB 57.2 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary gsimone/next.js canary Change
main-HASH.module.js gzip 5.71 kB 5.71 kB
webpack-HASH..dule.js gzip 751 B 751 B
19b7e98f51cc..dule.js gzip 7.09 kB 7.09 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.7 kB 52.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary gsimone/next.js canary Change
polyfills-HASH.js gzip 26.4 kB 26.4 kB
Overall change 26.4 kB 26.4 kB
Client Build Manifests
vercel/next.js canary gsimone/next.js canary Change
_buildManifest.js gzip 268 B 268 B
_buildManife..dule.js gzip 272 B 272 B
Overall change 540 B 540 B
Serverless bundles
vercel/next.js canary gsimone/next.js canary Change
_error.js 876 kB 876 kB
404.html 4.17 kB 4.17 kB
hooks.html 3.79 kB 3.79 kB
index.js 876 kB 876 kB
link.js 915 kB 915 kB
routerDirect.js 908 kB 908 kB
withRouter.js 908 kB 908 kB
Overall change 4.49 MB 4.49 MB
Commit: 5d42e46

@ijjk
Copy link
Member

ijjk commented Jul 6, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary gsimone/next.js canary Change
buildDuration 12s 11.6s -335ms
nodeModulesSize 66.1 MB 66.1 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary gsimone/next.js canary Change
/ failed reqs 0 0
/ total time (seconds) 1.917 1.876 -0.04
/ avg req/sec 1304.09 1332.81 +28.72
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.139 1.164 ⚠️ +0.02
/error-in-render avg req/sec 2195.72 2147.93 ⚠️ -47.79
Client Bundles (main, webpack, commons)
vercel/next.js canary gsimone/next.js canary Change
main-HASH.js gzip 6.63 kB 6.63 kB
webpack-HASH.js gzip 751 B 751 B
19b7e98f51cc..18e4.js gzip 10.7 kB 10.7 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57.2 kB 57.2 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary gsimone/next.js canary Change
main-HASH.module.js gzip 5.71 kB 5.71 kB
webpack-HASH..dule.js gzip 751 B 751 B
19b7e98f51cc..dule.js gzip 7.09 kB 7.09 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.7 kB 52.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary gsimone/next.js canary Change
polyfills-HASH.js gzip 26.4 kB 26.4 kB
Overall change 26.4 kB 26.4 kB
Client Build Manifests
vercel/next.js canary gsimone/next.js canary Change
_buildManifest.js gzip 268 B 268 B
_buildManife..dule.js gzip 272 B 272 B
Overall change 540 B 540 B
Rendered Page Sizes
vercel/next.js canary gsimone/next.js canary Change
index.html gzip 954 B 954 B
link.html gzip 958 B 958 B
withRouter.html gzip 945 B 945 B
Overall change 2.86 kB 2.86 kB

Serverless Mode
General
vercel/next.js canary gsimone/next.js canary Change
buildDuration 13s 12.4s -567ms
nodeModulesSize 66.1 MB 66.1 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary gsimone/next.js canary Change
main-HASH.js gzip 6.63 kB 6.63 kB
webpack-HASH.js gzip 751 B 751 B
19b7e98f51cc..18e4.js gzip 10.7 kB 10.7 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57.2 kB 57.2 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary gsimone/next.js canary Change
main-HASH.module.js gzip 5.71 kB 5.71 kB
webpack-HASH..dule.js gzip 751 B 751 B
19b7e98f51cc..dule.js gzip 7.09 kB 7.09 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.7 kB 52.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary gsimone/next.js canary Change
polyfills-HASH.js gzip 26.4 kB 26.4 kB
Overall change 26.4 kB 26.4 kB
Client Build Manifests
vercel/next.js canary gsimone/next.js canary Change
_buildManifest.js gzip 268 B 268 B
_buildManife..dule.js gzip 272 B 272 B
Overall change 540 B 540 B
Serverless bundles
vercel/next.js canary gsimone/next.js canary Change
_error.js 876 kB 876 kB
404.html 4.17 kB 4.17 kB
hooks.html 3.79 kB 3.79 kB
index.js 876 kB 876 kB
link.js 915 kB 915 kB
routerDirect.js 908 kB 908 kB
withRouter.js 908 kB 908 kB
Overall change 4.49 MB 4.49 MB
Commit: 4cc9338

@ijjk
Copy link
Member

ijjk commented Jul 7, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary gsimone/next.js canary Change
buildDuration 11.6s 12.1s ⚠️ +539ms
nodeModulesSize 66.1 MB 66.1 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary gsimone/next.js canary Change
/ failed reqs 0 0
/ total time (seconds) 1.935 1.991 ⚠️ +0.06
/ avg req/sec 1291.77 1255.79 ⚠️ -35.98
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.162 1.21 ⚠️ +0.05
/error-in-render avg req/sec 2150.55 2066.33 ⚠️ -84.22
Client Bundles (main, webpack, commons)
vercel/next.js canary gsimone/next.js canary Change
main-HASH.js gzip 6.63 kB 6.63 kB
webpack-HASH.js gzip 751 B 751 B
19b7e98f51cc..c646.js gzip 10.7 kB 10.7 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57.2 kB 57.2 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary gsimone/next.js canary Change
main-HASH.module.js gzip 5.71 kB 5.71 kB
webpack-HASH..dule.js gzip 751 B 751 B
19b7e98f51cc..dule.js gzip 7.1 kB 7.1 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.7 kB 52.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary gsimone/next.js canary Change
polyfills-HASH.js gzip 26.4 kB 26.4 kB
Overall change 26.4 kB 26.4 kB
Client Build Manifests
vercel/next.js canary gsimone/next.js canary Change
_buildManifest.js gzip 268 B 268 B
_buildManife..dule.js gzip 272 B 272 B
Overall change 540 B 540 B
Rendered Page Sizes
vercel/next.js canary gsimone/next.js canary Change
index.html gzip 954 B 954 B
link.html gzip 960 B 960 B
withRouter.html gzip 946 B 946 B
Overall change 2.86 kB 2.86 kB

Serverless Mode
General
vercel/next.js canary gsimone/next.js canary Change
buildDuration 12.8s 13.5s ⚠️ +680ms
nodeModulesSize 66.1 MB 66.1 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary gsimone/next.js canary Change
main-HASH.js gzip 6.63 kB 6.63 kB
webpack-HASH.js gzip 751 B 751 B
19b7e98f51cc..c646.js gzip 10.7 kB 10.7 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57.2 kB 57.2 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary gsimone/next.js canary Change
main-HASH.module.js gzip 5.71 kB 5.71 kB
webpack-HASH..dule.js gzip 751 B 751 B
19b7e98f51cc..dule.js gzip 7.1 kB 7.1 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.7 kB 52.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary gsimone/next.js canary Change
polyfills-HASH.js gzip 26.4 kB 26.4 kB
Overall change 26.4 kB 26.4 kB
Client Build Manifests
vercel/next.js canary gsimone/next.js canary Change
_buildManifest.js gzip 268 B 268 B
_buildManife..dule.js gzip 272 B 272 B
Overall change 540 B 540 B
Serverless bundles
vercel/next.js canary gsimone/next.js canary Change
_error.js 876 kB 876 kB
404.html 4.17 kB 4.17 kB
hooks.html 3.79 kB 3.79 kB
index.js 877 kB 877 kB
link.js 915 kB 915 kB
routerDirect.js 909 kB 909 kB
withRouter.js 909 kB 909 kB
Overall change 4.49 MB 4.49 MB
Commit: ed0dac1

@ijjk
Copy link
Member

ijjk commented Jul 7, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary gsimone/next.js canary Change
buildDuration 10.6s 11.1s ⚠️ +445ms
nodeModulesSize 66.1 MB 66.1 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary gsimone/next.js canary Change
/ failed reqs 0 0
/ total time (seconds) 1.782 1.889 ⚠️ +0.11
/ avg req/sec 1403.03 1323.65 ⚠️ -79.38
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.243 1.243
/error-in-render avg req/sec 2010.83 2012.02 +1.19
Client Bundles (main, webpack, commons)
vercel/next.js canary gsimone/next.js canary Change
main-HASH.js gzip 6.63 kB 6.63 kB
webpack-HASH.js gzip 751 B 751 B
19b7e98f51cc..c646.js gzip 10.7 kB 10.7 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57.2 kB 57.2 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary gsimone/next.js canary Change
main-HASH.module.js gzip 5.71 kB 5.71 kB
webpack-HASH..dule.js gzip 751 B 751 B
19b7e98f51cc..dule.js gzip 7.1 kB 7.1 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.7 kB 52.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary gsimone/next.js canary Change
polyfills-HASH.js gzip 26.4 kB 26.4 kB
Overall change 26.4 kB 26.4 kB
Client Build Manifests
vercel/next.js canary gsimone/next.js canary Change
_buildManifest.js gzip 268 B 268 B
_buildManife..dule.js gzip 272 B 272 B
Overall change 540 B 540 B
Rendered Page Sizes
vercel/next.js canary gsimone/next.js canary Change
index.html gzip 954 B 954 B
link.html gzip 960 B 960 B
withRouter.html gzip 946 B 946 B
Overall change 2.86 kB 2.86 kB

Serverless Mode
General
vercel/next.js canary gsimone/next.js canary Change
buildDuration 11.6s 11.7s ⚠️ +86ms
nodeModulesSize 66.1 MB 66.1 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary gsimone/next.js canary Change
main-HASH.js gzip 6.63 kB 6.63 kB
webpack-HASH.js gzip 751 B 751 B
19b7e98f51cc..c646.js gzip 10.7 kB 10.7 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57.2 kB 57.2 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary gsimone/next.js canary Change
main-HASH.module.js gzip 5.71 kB 5.71 kB
webpack-HASH..dule.js gzip 751 B 751 B
19b7e98f51cc..dule.js gzip 7.1 kB 7.1 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.7 kB 52.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary gsimone/next.js canary Change
polyfills-HASH.js gzip 26.4 kB 26.4 kB
Overall change 26.4 kB 26.4 kB
Client Build Manifests
vercel/next.js canary gsimone/next.js canary Change
_buildManifest.js gzip 268 B 268 B
_buildManife..dule.js gzip 272 B 272 B
Overall change 540 B 540 B
Serverless bundles
vercel/next.js canary gsimone/next.js canary Change
_error.js 876 kB 876 kB
404.html 4.17 kB 4.17 kB
hooks.html 3.79 kB 3.79 kB
index.js 877 kB 877 kB
link.js 915 kB 915 kB
routerDirect.js 909 kB 909 kB
withRouter.js 909 kB 909 kB
Overall change 4.49 MB 4.49 MB
Commit: 8447502

Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gsimone Thank you for the PR. Is the current example broken or only drei? I looked at the issues and they all seem to be drei related, if that's the case please create a new example called with-three-js-drei instead.

@gsimone
Copy link
Contributor Author

gsimone commented Jul 7, 2020

Drei and react-three-fiber are strictly connected, same author and maintainers, we usually advice using drei for most common use cases, thus people will likely end up using both.

Also, in a common use case such as OrbitControls, users will have the same problem since it requires importing an example from threejs

Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you.

@ijjk
Copy link
Member

ijjk commented Jul 7, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary gsimone/next.js canary Change
buildDuration 13.3s 13.2s -93ms
nodeModulesSize 66.1 MB 66.1 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary gsimone/next.js canary Change
/ failed reqs 0 0
/ total time (seconds) 2.272 2.328 ⚠️ +0.06
/ avg req/sec 1100.3 1073.89 ⚠️ -26.41
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.494 1.521 ⚠️ +0.03
/error-in-render avg req/sec 1673.51 1643.46 ⚠️ -30.05
Client Bundles (main, webpack, commons)
vercel/next.js canary gsimone/next.js canary Change
main-HASH.js gzip 6.63 kB 6.63 kB
webpack-HASH.js gzip 751 B 751 B
19b7e98f51cc..c646.js gzip 10.7 kB 10.7 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57.2 kB 57.2 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary gsimone/next.js canary Change
main-HASH.module.js gzip 5.71 kB 5.71 kB
webpack-HASH..dule.js gzip 751 B 751 B
19b7e98f51cc..dule.js gzip 7.1 kB 7.1 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.7 kB 52.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary gsimone/next.js canary Change
polyfills-HASH.js gzip 26.4 kB 26.4 kB
Overall change 26.4 kB 26.4 kB
Client Build Manifests
vercel/next.js canary gsimone/next.js canary Change
_buildManifest.js gzip 268 B 268 B
_buildManife..dule.js gzip 272 B 272 B
Overall change 540 B 540 B
Rendered Page Sizes
vercel/next.js canary gsimone/next.js canary Change
index.html gzip 954 B 954 B
link.html gzip 960 B 960 B
withRouter.html gzip 946 B 946 B
Overall change 2.86 kB 2.86 kB

Serverless Mode
General
vercel/next.js canary gsimone/next.js canary Change
buildDuration 14.3s 14.4s ⚠️ +66ms
nodeModulesSize 66.1 MB 66.1 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary gsimone/next.js canary Change
main-HASH.js gzip 6.63 kB 6.63 kB
webpack-HASH.js gzip 751 B 751 B
19b7e98f51cc..c646.js gzip 10.7 kB 10.7 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57.2 kB 57.2 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary gsimone/next.js canary Change
main-HASH.module.js gzip 5.71 kB 5.71 kB
webpack-HASH..dule.js gzip 751 B 751 B
19b7e98f51cc..dule.js gzip 7.1 kB 7.1 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.7 kB 52.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary gsimone/next.js canary Change
polyfills-HASH.js gzip 26.4 kB 26.4 kB
Overall change 26.4 kB 26.4 kB
Client Build Manifests
vercel/next.js canary gsimone/next.js canary Change
_buildManifest.js gzip 268 B 268 B
_buildManife..dule.js gzip 272 B 272 B
Overall change 540 B 540 B
Serverless bundles
vercel/next.js canary gsimone/next.js canary Change
_error.js 876 kB 876 kB
404.html 4.17 kB 4.17 kB
hooks.html 3.79 kB 3.79 kB
index.js 877 kB 877 kB
link.js 915 kB 915 kB
routerDirect.js 909 kB 909 kB
withRouter.js 909 kB 909 kB
Overall change 4.49 MB 4.49 MB
Commit: 157dbe8

@ijjk
Copy link
Member

ijjk commented Jul 8, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary gsimone/next.js canary Change
buildDuration 11.1s 11.1s ⚠️ +51ms
nodeModulesSize 66.1 MB 66.1 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary gsimone/next.js canary Change
/ failed reqs 0 0
/ total time (seconds) 1.92 2.093 ⚠️ +0.17
/ avg req/sec 1302.05 1194.53 ⚠️ -107.52
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.293 1.46 ⚠️ +0.17
/error-in-render avg req/sec 1933.74 1712.09 ⚠️ -221.65
Client Bundles (main, webpack, commons)
vercel/next.js canary gsimone/next.js canary Change
main-HASH.js gzip 6.63 kB 6.63 kB
webpack-HASH.js gzip 751 B 751 B
19b7e98f51cc..c646.js gzip 10.7 kB 10.7 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57.2 kB 57.2 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary gsimone/next.js canary Change
main-HASH.module.js gzip 5.71 kB 5.71 kB
webpack-HASH..dule.js gzip 751 B 751 B
19b7e98f51cc..dule.js gzip 7.1 kB 7.1 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.7 kB 52.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary gsimone/next.js canary Change
polyfills-HASH.js gzip 26.4 kB 26.4 kB
Overall change 26.4 kB 26.4 kB
Client Build Manifests
vercel/next.js canary gsimone/next.js canary Change
_buildManifest.js gzip 268 B 268 B
_buildManife..dule.js gzip 272 B 272 B
Overall change 540 B 540 B
Rendered Page Sizes
vercel/next.js canary gsimone/next.js canary Change
index.html gzip 954 B 954 B
link.html gzip 960 B 960 B
withRouter.html gzip 946 B 946 B
Overall change 2.86 kB 2.86 kB

Serverless Mode
General
vercel/next.js canary gsimone/next.js canary Change
buildDuration 11.9s 12.2s ⚠️ +261ms
nodeModulesSize 66.1 MB 66.1 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary gsimone/next.js canary Change
main-HASH.js gzip 6.63 kB 6.63 kB
webpack-HASH.js gzip 751 B 751 B
19b7e98f51cc..c646.js gzip 10.7 kB 10.7 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57.2 kB 57.2 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary gsimone/next.js canary Change
main-HASH.module.js gzip 5.71 kB 5.71 kB
webpack-HASH..dule.js gzip 751 B 751 B
19b7e98f51cc..dule.js gzip 7.1 kB 7.1 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.7 kB 52.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary gsimone/next.js canary Change
polyfills-HASH.js gzip 26.4 kB 26.4 kB
Overall change 26.4 kB 26.4 kB
Client Build Manifests
vercel/next.js canary gsimone/next.js canary Change
_buildManifest.js gzip 268 B 268 B
_buildManife..dule.js gzip 272 B 272 B
Overall change 540 B 540 B
Serverless bundles
vercel/next.js canary gsimone/next.js canary Change
_error.js 876 kB 876 kB
404.html 4.17 kB 4.17 kB
hooks.html 3.79 kB 3.79 kB
index.js 877 kB 877 kB
link.js 915 kB 915 kB
routerDirect.js 909 kB 909 kB
withRouter.js 909 kB 909 kB
Overall change 4.49 MB 4.49 MB
Commit: 7e6a0d3

@kodiakhq kodiakhq bot merged commit 3fa5e58 into vercel:canary Jul 8, 2020
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
…rcel#14864)

Hi, we received some issues on the `react-three-fiber` and `drei` repos, mentioning broken ssr because of some examples where we import three's examples - like to implement loaders or controls. 

This PR adds a next.config suggested by many that transpiles everything in three, drei and postprocessing.

I also added some code from `drei` that shows how controls and effects can be easily added.
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants