Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

De-experimentalize redirects for rosetta example #15554

Merged
merged 3 commits into from
Jul 28, 2020
Merged

De-experimentalize redirects for rosetta example #15554

merged 3 commits into from
Jul 28, 2020

Conversation

Timer
Copy link
Member

@Timer Timer commented Jul 28, 2020

Fixes #15552

@ijjk ijjk added the examples Issue/PR related to examples label Jul 28, 2020
@Timer Timer mentioned this pull request Jul 28, 2020
Closed
@ijjk
Copy link
Member

ijjk commented Jul 28, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary Timer/next.js update-rosetta-example Change
buildDuration 12.5s 11.8s -696ms
nodeModulesSize 64.5 MB 64.5 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js update-rosetta-example Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.06 1.976 -0.08
/ avg req/sec 1213.61 1265.03 +51.42
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.353 1.347 -0.01
/error-in-render avg req/sec 1847.71 1855.98 +8.27
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js update-rosetta-example Change
677f882d2ed8..7778.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-af9a1a4..87fe.js gzip 6.71 kB 6.71 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.6 kB 87.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js update-rosetta-example Change
677f882d2ed8..dule.js gzip 6.08 kB 6.08 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-69d5e5f..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary Timer/next.js update-rosetta-example Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js update-rosetta-example Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js update-rosetta-example Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js update-rosetta-example Change
index.html gzip 945 B 945 B ✓
link.html gzip 954 B 954 B ✓
withRouter.html gzip 940 B 940 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General
vercel/next.js canary Timer/next.js update-rosetta-example Change
buildDuration 12.8s 12.9s ⚠️ +95ms
nodeModulesSize 64.5 MB 64.5 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js update-rosetta-example Change
677f882d2ed8..7778.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-af9a1a4..87fe.js gzip 6.71 kB 6.71 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.6 kB 87.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js update-rosetta-example Change
677f882d2ed8..dule.js gzip 6.08 kB 6.08 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-69d5e5f..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary Timer/next.js update-rosetta-example Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js update-rosetta-example Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js update-rosetta-example Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Serverless bundles
vercel/next.js canary Timer/next.js update-rosetta-example Change
_error.js 880 kB 880 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 881 kB 881 kB ✓
link.js 921 kB 921 kB ✓
routerDirect.js 915 kB 915 kB ✓
withRouter.js 915 kB 915 kB ✓
Overall change 4.52 MB 4.52 MB ✓
Commit: 34b6f02

@ijjk
Copy link
Member

ijjk commented Jul 28, 2020

Stats from current PR

Default Server Mode
General
vercel/next.js canary Timer/next.js update-rosetta-example Change
buildDuration 13.2s 13s -193ms
nodeModulesSize 64.5 MB 64.5 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js update-rosetta-example Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.066 2.054 -0.01
/ avg req/sec 1210.1 1216.99 +6.89
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.331 1.333 0
/error-in-render avg req/sec 1878.87 1875.12 ⚠️ -3.75
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js update-rosetta-example Change
677f882d2ed8..7778.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-af9a1a4..87fe.js gzip 6.71 kB 6.71 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.6 kB 87.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js update-rosetta-example Change
677f882d2ed8..dule.js gzip 6.08 kB 6.08 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-69d5e5f..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary Timer/next.js update-rosetta-example Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js update-rosetta-example Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js update-rosetta-example Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js update-rosetta-example Change
index.html gzip 945 B 945 B ✓
link.html gzip 954 B 954 B ✓
withRouter.html gzip 940 B 940 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General
vercel/next.js canary Timer/next.js update-rosetta-example Change
buildDuration 14.1s 13.9s -266ms
nodeModulesSize 64.5 MB 64.5 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js update-rosetta-example Change
677f882d2ed8..7778.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-af9a1a4..87fe.js gzip 6.71 kB 6.71 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.6 kB 87.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js update-rosetta-example Change
677f882d2ed8..dule.js gzip 6.08 kB 6.08 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-69d5e5f..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary Timer/next.js update-rosetta-example Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js update-rosetta-example Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js update-rosetta-example Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Serverless bundles
vercel/next.js canary Timer/next.js update-rosetta-example Change
_error.js 880 kB 880 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 881 kB 881 kB ✓
link.js 921 kB 921 kB ✓
routerDirect.js 915 kB 915 kB ✓
withRouter.js 915 kB 915 kB ✓
Overall change 4.52 MB 4.52 MB ✓
Commit: 03d0203

@ijjk
Copy link
Member

ijjk commented Jul 28, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary Timer/next.js update-rosetta-example Change
buildDuration 13.7s 13.8s ⚠️ +133ms
nodeModulesSize 64.5 MB 64.5 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js update-rosetta-example Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.395 2.271 -0.12
/ avg req/sec 1043.71 1100.74 +57.03
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.521 1.48 -0.04
/error-in-render avg req/sec 1643.16 1689.75 +46.59
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js update-rosetta-example Change
677f882d2ed8..7778.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-af9a1a4..87fe.js gzip 6.71 kB 6.71 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.6 kB 87.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js update-rosetta-example Change
677f882d2ed8..dule.js gzip 6.08 kB 6.08 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-69d5e5f..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary Timer/next.js update-rosetta-example Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js update-rosetta-example Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js update-rosetta-example Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js update-rosetta-example Change
index.html gzip 945 B 945 B ✓
link.html gzip 954 B 954 B ✓
withRouter.html gzip 940 B 940 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General
vercel/next.js canary Timer/next.js update-rosetta-example Change
buildDuration 15.3s 15s -298ms
nodeModulesSize 64.5 MB 64.5 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js update-rosetta-example Change
677f882d2ed8..7778.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-af9a1a4..87fe.js gzip 6.71 kB 6.71 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.6 kB 87.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js update-rosetta-example Change
677f882d2ed8..dule.js gzip 6.08 kB 6.08 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-69d5e5f..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary Timer/next.js update-rosetta-example Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js update-rosetta-example Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js update-rosetta-example Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Serverless bundles
vercel/next.js canary Timer/next.js update-rosetta-example Change
_error.js 880 kB 880 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 881 kB 881 kB ✓
link.js 921 kB 921 kB ✓
routerDirect.js 915 kB 915 kB ✓
withRouter.js 915 kB 915 kB ✓
Overall change 4.52 MB 4.52 MB ✓
Commit: cc31ade

@kodiakhq kodiakhq bot merged commit 5b4274a into vercel:canary Jul 28, 2020
@Timer Timer deleted the update-rosetta-example branch July 28, 2020 16:01
LauraBeatris pushed a commit to LauraBeatris/next.js that referenced this pull request Sep 1, 2020
@Timer @LauraBeatris
De-experimentalize redirects for rosetta example (vercel#15554)
0982e62 
Fixes vercel#15552
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update examples using new routing properties
3 participants
@Timer @ijjk @timneutkens