Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove broken server example #15653

Merged
merged 2 commits into from
Jul 29, 2020
Merged

remove broken server example #15653

merged 2 commits into from
Jul 29, 2020

Conversation

scefali
Copy link

@scefali scefali commented Jul 29, 2020

This removes the server 4 example which breaks all server code since the error will happen when the file is sourced.

@ijjk ijjk added the examples Issue/PR related to examples label Jul 29, 2020
scefali
scefali commented Jul 29, 2020
View reviewed changes
examples/with-sentry/pages/server/test4.js
@@ -1,12 +0,0 @@
const doAsyncWork = () => Promise.reject(new Error('Server Test 4'))
doAsyncWork()
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This uncaught exception is no bueno

@ijjk
Copy link
Member

ijjk commented Jul 29, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary scefali/next.js scefali/with-sentry-broken-server-example Change
buildDuration 13.8s 14s ⚠️ +258ms
nodeModulesSize 65.5 MB 65.5 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary scefali/next.js scefali/with-sentry-broken-server-example Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.546 2.505 -0.04
/ avg req/sec 981.95 998.19 +16.24
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.56 1.581 ⚠️ +0.02
/error-in-render avg req/sec 1603 1581.7 ⚠️ -21.3
Client Bundles (main, webpack, commons)
vercel/next.js canary scefali/next.js scefali/with-sentry-broken-server-example Change
677f882d2ed8..b7a9.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-7efbba9..5962.js gzip 6.76 kB 6.76 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 56.8 kB 56.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary scefali/next.js scefali/with-sentry-broken-server-example Change
677f882d2ed8..dule.js gzip 6.09 kB 6.09 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-763946d..dule.js gzip 5.84 kB 5.84 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary scefali/next.js scefali/with-sentry-broken-server-example Change
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
Overall change 30.8 kB 30.8 kB ✓
Client Pages
vercel/next.js canary scefali/next.js scefali/with-sentry-broken-server-example Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-a98d9..5cb7.js gzip 3.45 kB 3.45 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-6f8445b..99e1.js gzip 1.3 kB 1.3 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.72 kB 7.72 kB ✓
Client Pages Modern
vercel/next.js canary scefali/next.js scefali/with-sentry-broken-server-example Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-d5979..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-91516ae..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary scefali/next.js scefali/with-sentry-broken-server-example Change
_buildManifest.js gzip 274 B 274 B ✓
_buildManife..dule.js gzip 282 B 282 B ✓
Overall change 556 B 556 B ✓
Rendered Page Sizes
vercel/next.js canary scefali/next.js scefali/with-sentry-broken-server-example Change
index.html gzip 946 B 946 B ✓
link.html gzip 953 B 953 B ✓
withRouter.html gzip 938 B 938 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General
vercel/next.js canary scefali/next.js scefali/with-sentry-broken-server-example Change
buildDuration 15.3s 15.3s ⚠️ +6ms
nodeModulesSize 65.5 MB 65.5 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary scefali/next.js scefali/with-sentry-broken-server-example Change
677f882d2ed8..b7a9.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-7efbba9..5962.js gzip 6.76 kB 6.76 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 56.8 kB 56.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary scefali/next.js scefali/with-sentry-broken-server-example Change
677f882d2ed8..dule.js gzip 6.09 kB 6.09 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-763946d..dule.js gzip 5.84 kB 5.84 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary scefali/next.js scefali/with-sentry-broken-server-example Change
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
Overall change 30.8 kB 30.8 kB ✓
Client Pages
vercel/next.js canary scefali/next.js scefali/with-sentry-broken-server-example Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-a98d9..5cb7.js gzip 3.45 kB 3.45 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-6f8445b..99e1.js gzip 1.3 kB 1.3 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.72 kB 7.72 kB ✓
Client Pages Modern
vercel/next.js canary scefali/next.js scefali/with-sentry-broken-server-example Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-d5979..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-91516ae..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary scefali/next.js scefali/with-sentry-broken-server-example Change
_buildManifest.js gzip 274 B 274 B ✓
_buildManife..dule.js gzip 282 B 282 B ✓
Overall change 556 B 556 B ✓
Serverless bundles
vercel/next.js canary scefali/next.js scefali/with-sentry-broken-server-example Change
_error.js 1.02 MB 1.02 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.2 MB 5.2 MB ✓
Commit: 85e870b

lfades
lfades approved these changes Jul 29, 2020
View reviewed changes
Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ijjk
Copy link
Member

ijjk commented Jul 29, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary scefali/next.js scefali/with-sentry-broken-server-example Change
buildDuration 12.4s 12.3s -146ms
nodeModulesSize 65.5 MB 65.5 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary scefali/next.js scefali/with-sentry-broken-server-example Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.166 2.21 ⚠️ +0.04
/ avg req/sec 1154.15 1131.08 ⚠️ -23.07
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.214 1.241 ⚠️ +0.03
/error-in-render avg req/sec 2059.17 2015.28 ⚠️ -43.89
Client Bundles (main, webpack, commons)
vercel/next.js canary scefali/next.js scefali/with-sentry-broken-server-example Change
677f882d2ed8..b7a9.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-7efbba9..5962.js gzip 6.76 kB 6.76 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 56.8 kB 56.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary scefali/next.js scefali/with-sentry-broken-server-example Change
677f882d2ed8..dule.js gzip 6.09 kB 6.09 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-763946d..dule.js gzip 5.84 kB 5.84 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary scefali/next.js scefali/with-sentry-broken-server-example Change
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
Overall change 30.8 kB 30.8 kB ✓
Client Pages
vercel/next.js canary scefali/next.js scefali/with-sentry-broken-server-example Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-a98d9..5cb7.js gzip 3.45 kB 3.45 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-6f8445b..99e1.js gzip 1.3 kB 1.3 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.72 kB 7.72 kB ✓
Client Pages Modern
vercel/next.js canary scefali/next.js scefali/with-sentry-broken-server-example Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-d5979..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-91516ae..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary scefali/next.js scefali/with-sentry-broken-server-example Change
_buildManifest.js gzip 274 B 274 B ✓
_buildManife..dule.js gzip 282 B 282 B ✓
Overall change 556 B 556 B ✓
Rendered Page Sizes
vercel/next.js canary scefali/next.js scefali/with-sentry-broken-server-example Change
index.html gzip 946 B 946 B ✓
link.html gzip 953 B 953 B ✓
withRouter.html gzip 938 B 938 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General
vercel/next.js canary scefali/next.js scefali/with-sentry-broken-server-example Change
buildDuration 13.9s 13.8s -128ms
nodeModulesSize 65.5 MB 65.5 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary scefali/next.js scefali/with-sentry-broken-server-example Change
677f882d2ed8..b7a9.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-7efbba9..5962.js gzip 6.76 kB 6.76 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 56.8 kB 56.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary scefali/next.js scefali/with-sentry-broken-server-example Change
677f882d2ed8..dule.js gzip 6.09 kB 6.09 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-763946d..dule.js gzip 5.84 kB 5.84 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary scefali/next.js scefali/with-sentry-broken-server-example Change
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
Overall change 30.8 kB 30.8 kB ✓
Client Pages
vercel/next.js canary scefali/next.js scefali/with-sentry-broken-server-example Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-a98d9..5cb7.js gzip 3.45 kB 3.45 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-6f8445b..99e1.js gzip 1.3 kB 1.3 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.72 kB 7.72 kB ✓
Client Pages Modern
vercel/next.js canary scefali/next.js scefali/with-sentry-broken-server-example Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-d5979..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-91516ae..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary scefali/next.js scefali/with-sentry-broken-server-example Change
_buildManifest.js gzip 274 B 274 B ✓
_buildManife..dule.js gzip 282 B 282 B ✓
Overall change 556 B 556 B ✓
Serverless bundles
vercel/next.js canary scefali/next.js scefali/with-sentry-broken-server-example Change
_error.js 1.02 MB 1.02 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.2 MB 5.2 MB ✓
Commit: e3a877c

@kodiakhq kodiakhq bot merged commit 5992496 into vercel:canary Jul 29, 2020
LauraBeatris pushed a commit to LauraBeatris/next.js that referenced this pull request Sep 1, 2020
@LauraBeatris
remove broken server example (vercel#15653)
925bffc 
This removes the server 4 example which breaks all server code since the error will happen when the file is sourced.
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lfades lfades lfades approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scefali @ijjk @lfades