Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update next-transpile-modules in with-react-intl example #15730

Merged
merged 2 commits into from
Jul 31, 2020
Merged

Update next-transpile-modules in with-react-intl example #15730

merged 2 commits into from
Jul 31, 2020

Conversation

jonespen
Copy link
Contributor

next-transpile-modules needs to be updated to support Next.js 9.5

Closes #15725

@ijjk ijjk added the examples Issue/PR related to examples label Jul 31, 2020
@ijjk
Copy link
Member

ijjk commented Jul 31, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary jonespen/next.js react-intl-update-next-transpile-modules Change
buildDuration 12.6s 12.2s -428ms
nodeModulesSize 65.5 MB 65.5 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary jonespen/next.js react-intl-update-next-transpile-modules Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.342 2.272 -0.07
/ avg req/sec 1067.3 1100.55 +33.25
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.324 1.331 ⚠️ +0.01
/error-in-render avg req/sec 1888.14 1878.57 ⚠️ -9.57
Client Bundles (main, webpack, commons)
vercel/next.js canary jonespen/next.js react-intl-update-next-transpile-modules Change
677f882d2ed8..b7a9.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-88c5dea..200a.js gzip 6.76 kB 6.76 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.7 kB 87.7 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary jonespen/next.js react-intl-update-next-transpile-modules Change
677f882d2ed8..dule.js gzip 6.09 kB 6.09 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-001590a..dule.js gzip 5.84 kB 5.84 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.7 kB 82.7 kB ✓
Client Pages
vercel/next.js canary jonespen/next.js react-intl-update-next-transpile-modules Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-a98d9..5cb7.js gzip 3.45 kB 3.45 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-6f8445b..99e1.js gzip 1.3 kB 1.3 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.72 kB 7.72 kB ✓
Client Pages Modern
vercel/next.js canary jonespen/next.js react-intl-update-next-transpile-modules Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-d5979..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-91516ae..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary jonespen/next.js react-intl-update-next-transpile-modules Change
_buildManifest.js gzip 274 B 274 B ✓
_buildManife..dule.js gzip 282 B 282 B ✓
Overall change 556 B 556 B ✓
Rendered Page Sizes
vercel/next.js canary jonespen/next.js react-intl-update-next-transpile-modules Change
index.html gzip 947 B 947 B ✓
link.html gzip 953 B 953 B ✓
withRouter.html gzip 940 B 940 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General
vercel/next.js canary jonespen/next.js react-intl-update-next-transpile-modules Change
buildDuration 13.4s 13.4s -84ms
nodeModulesSize 65.5 MB 65.5 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary jonespen/next.js react-intl-update-next-transpile-modules Change
677f882d2ed8..b7a9.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-88c5dea..200a.js gzip 6.76 kB 6.76 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.7 kB 87.7 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary jonespen/next.js react-intl-update-next-transpile-modules Change
677f882d2ed8..dule.js gzip 6.09 kB 6.09 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-001590a..dule.js gzip 5.84 kB 5.84 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.7 kB 82.7 kB ✓
Client Pages
vercel/next.js canary jonespen/next.js react-intl-update-next-transpile-modules Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-a98d9..5cb7.js gzip 3.45 kB 3.45 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-6f8445b..99e1.js gzip 1.3 kB 1.3 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.72 kB 7.72 kB ✓
Client Pages Modern
vercel/next.js canary jonespen/next.js react-intl-update-next-transpile-modules Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-d5979..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-91516ae..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary jonespen/next.js react-intl-update-next-transpile-modules Change
_buildManifest.js gzip 274 B 274 B ✓
_buildManife..dule.js gzip 282 B 282 B ✓
Overall change 556 B 556 B ✓
Serverless bundles
vercel/next.js canary jonespen/next.js react-intl-update-next-transpile-modules Change
_error.js 1.02 MB 1.02 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.2 MB 5.2 MB ✓
Commit: 5edbe15

@ijjk
Copy link
Member

ijjk commented Jul 31, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary jonespen/next.js react-intl-update-next-transpile-modules Change
buildDuration 12.7s 12.4s -361ms
nodeModulesSize 65.5 MB 65.5 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary jonespen/next.js react-intl-update-next-transpile-modules Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.126 2.143 ⚠️ +0.02
/ avg req/sec 1175.87 1166.32 ⚠️ -9.55
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.175 1.22 ⚠️ +0.04
/error-in-render avg req/sec 2127.62 2048.95 ⚠️ -78.67
Client Bundles (main, webpack, commons)
vercel/next.js canary jonespen/next.js react-intl-update-next-transpile-modules Change
677f882d2ed8..b7a9.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-88c5dea..200a.js gzip 6.76 kB 6.76 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 56.8 kB 56.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary jonespen/next.js react-intl-update-next-transpile-modules Change
677f882d2ed8..dule.js gzip 6.09 kB 6.09 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-001590a..dule.js gzip 5.84 kB 5.84 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary jonespen/next.js react-intl-update-next-transpile-modules Change
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
Overall change 30.8 kB 30.8 kB ✓
Client Pages
vercel/next.js canary jonespen/next.js react-intl-update-next-transpile-modules Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-a98d9..5cb7.js gzip 3.45 kB 3.45 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-6f8445b..99e1.js gzip 1.3 kB 1.3 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.72 kB 7.72 kB ✓
Client Pages Modern
vercel/next.js canary jonespen/next.js react-intl-update-next-transpile-modules Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-d5979..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-91516ae..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary jonespen/next.js react-intl-update-next-transpile-modules Change
_buildManifest.js gzip 274 B 274 B ✓
_buildManife..dule.js gzip 282 B 282 B ✓
Overall change 556 B 556 B ✓
Rendered Page Sizes
vercel/next.js canary jonespen/next.js react-intl-update-next-transpile-modules Change
index.html gzip 947 B 947 B ✓
link.html gzip 953 B 953 B ✓
withRouter.html gzip 940 B 940 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General
vercel/next.js canary jonespen/next.js react-intl-update-next-transpile-modules Change
buildDuration 13.2s 13.5s ⚠️ +299ms
nodeModulesSize 65.5 MB 65.5 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary jonespen/next.js react-intl-update-next-transpile-modules Change
677f882d2ed8..b7a9.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-88c5dea..200a.js gzip 6.76 kB 6.76 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 56.8 kB 56.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary jonespen/next.js react-intl-update-next-transpile-modules Change
677f882d2ed8..dule.js gzip 6.09 kB 6.09 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-001590a..dule.js gzip 5.84 kB 5.84 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary jonespen/next.js react-intl-update-next-transpile-modules Change
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
Overall change 30.8 kB 30.8 kB ✓
Client Pages
vercel/next.js canary jonespen/next.js react-intl-update-next-transpile-modules Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-a98d9..5cb7.js gzip 3.45 kB 3.45 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-6f8445b..99e1.js gzip 1.3 kB 1.3 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.72 kB 7.72 kB ✓
Client Pages Modern
vercel/next.js canary jonespen/next.js react-intl-update-next-transpile-modules Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-d5979..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-91516ae..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary jonespen/next.js react-intl-update-next-transpile-modules Change
_buildManifest.js gzip 274 B 274 B ✓
_buildManife..dule.js gzip 282 B 282 B ✓
Overall change 556 B 556 B ✓
Serverless bundles
vercel/next.js canary jonespen/next.js react-intl-update-next-transpile-modules Change
_error.js 1.02 MB 1.02 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.2 MB 5.2 MB ✓
Commit: fe76637

@kodiakhq kodiakhq bot merged commit 1409cd6 into vercel:canary Jul 31, 2020
@jonespen jonespen deleted the react-intl-update-next-transpile-modules branch July 31, 2020 07:30
LauraBeatris pushed a commit to LauraBeatris/next.js that referenced this pull request Sep 1, 2020
@jonespen @LauraBeatris
Update next-transpile-modules in with-react-intl example (vercel#15730)
0fe20fa 
next-transpile-modules needs to be updated to support Next.js 9.5

Closes vercel#15725
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

react-intl not working in WITH-REACT-INTL-APP example
3 participants
@jonespen @ijjk @Timer