Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New example: /with-storybook-styled-jsx-scss #18570

Merged
merged 35 commits into from
Jan 4, 2021
Merged

New example: /with-storybook-styled-jsx-scss #18570

merged 35 commits into from
Jan 4, 2021

Conversation

justinphilpott
Copy link
Contributor

@justinphilpott justinphilpott commented Oct 31, 2020 •
edited
Loading

Hi,

I'm submitting this PR for consideration as a new example app showing Styled JSX with SCSS working inside and outside storybook with example components.

Only known issue: I noticed that when running this example with:

$ yarn next ./examples/with-storybook-styled-jsx-scss

I receive the following error:

error - ./pages/_app.js
Error: [BABEL] .../next.js/examples/with-storybook-styled-jsx-scss/pages/_app.js: Cannot find module 'styled-jsx-plugin-sass' (While processing: ".../next.js/node_modules/next/babel.js")

However I notice that this same missing module error is triggered when running this existing example app "with-styled-jsx-scss".

Any changes/tweaks needed?

Thanks!

@ijjk ijjk added the examples Issue/PR related to examples label Oct 31, 2020
@justinphilpott
Copy link
Contributor Author

.... futher to the above comment, this example of course runs error free when installing it as a standalone app.

@ijjk
Copy link
Member

ijjk commented Oct 31, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
buildDuration 14s 14.6s ⚠️ +629ms
nodeModulesSize 91.3 MB 91.3 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.836 2.752 -0.08
/ avg req/sec 881.48 908.56 +27.08
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.732 1.672 -0.06
/error-in-render avg req/sec 1443.25 1495.19 +51.94
Client Bundles (main, webpack, commons)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
677f882d2ed8..3aa9.js gzip 11.3 kB 11.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-2bc1e97..bed6.js gzip 7.35 kB 7.35 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.3 kB 58.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
677f882d2ed8..dule.js gzip 7.03 kB 7.03 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-8cad9cc..dule.js gzip 6.33 kB 6.33 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-41ceea0..6b62.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-2d41a89..dule.js gzip 1.31 kB 1.31 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.4 kB 5.4 kB ✓
Client Build Manifests
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 995 B 995 B ✓
Overall change 3.01 kB 3.01 kB ✓
Serverless Mode
General
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
buildDuration 15.8s 15.9s ⚠️ +98ms
nodeModulesSize 91.3 MB 91.3 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
677f882d2ed8..3aa9.js gzip 11.3 kB 11.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-2bc1e97..bed6.js gzip 7.35 kB 7.35 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.3 kB 58.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
677f882d2ed8..dule.js gzip 7.03 kB 7.03 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-8cad9cc..dule.js gzip 6.33 kB 6.33 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-41ceea0..6b62.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-2d41a89..dule.js gzip 1.31 kB 1.31 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.4 kB 5.4 kB ✓
Client Build Manifests
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_error.js 1.06 MB 1.06 MB ✓
404.html 4.73 kB 4.73 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.06 MB 1.06 MB ✓
link.js 1.11 MB 1.11 MB ✓
routerDirect.js 1.1 MB 1.1 MB ✓
withRouter.js 1.1 MB 1.1 MB ✓
Overall change 5.43 MB 5.43 MB ✓
Commit: 25df573

@justinphilpott
Copy link
Contributor Author

justinphilpott commented Oct 31, 2020 •
edited
Loading

Can someone give me a pointer regarding the azure pipeline errors?

azure next.js Failing after 51m — Build #20201031.2 had test failures
Details
@azure-pipelines
azure next.js (test_chrome node-10-1) Failing after 39m — test_chrome node-10-1 failed
Details
@azure-pipelines
azure next.js (test_chrome node-10-2) Failing after 48m — test_chrome node-10-2 failed
Details
@azure-pipelines
azure next.js (test_chrome node-10-4) Failing after 34m — test_chrome node-10-4 failed
Details

@ijjk Any tips?

@vercel
Copy link

vercel bot commented Nov 4, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vercel/nextjs-examples-image-component/ovyx4zs29
✅ Preview: https://nextjs-examples-image-compon-git-with-storybook-styled-j-5d843e.vercel.vercel.app

@vercel vercel bot temporarily deployed to Preview November 4, 2020 18:53 Inactive
@ijjk
Copy link
Member

ijjk commented Nov 4, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
buildDuration 12.7s 13s ⚠️ +306ms
nodeModulesSize 90.5 MB 90.5 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.463 2.454 -0.01
/ avg req/sec 1014.96 1018.81 +3.85
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.307 1.261 -0.05
/error-in-render avg req/sec 1913.47 1981.79 +68.32
Client Bundles (main, webpack, commons)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
677f882d2ed8..1f3c.js gzip 11.2 kB 11.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-be398bc..d262.js gzip 7.33 kB 7.33 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.3 kB 58.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
677f882d2ed8..dule.js gzip 7.02 kB 7.02 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-378f0c6..dule.js gzip 6.33 kB 6.33 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
polyfills-b5..1119.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-a674d88..ccde.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-a4469f3..dule.js gzip 1.32 kB 1.32 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.41 kB 5.41 kB ✓
Client Build Manifests
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 994 B 994 B ✓
Overall change 3 kB 3 kB ✓
Serverless Mode
General
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
buildDuration 14.9s 14.7s -167ms
nodeModulesSize 90.5 MB 90.5 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
677f882d2ed8..1f3c.js gzip 11.2 kB 11.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-be398bc..d262.js gzip 7.33 kB 7.33 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.3 kB 58.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
677f882d2ed8..dule.js gzip 7.02 kB 7.02 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-378f0c6..dule.js gzip 6.33 kB 6.33 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
polyfills-b5..1119.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-a674d88..ccde.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-a4469f3..dule.js gzip 1.32 kB 1.32 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.41 kB 5.41 kB ✓
Client Build Manifests
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_error.js 1.07 MB 1.07 MB ✓
404.html 4.73 kB 4.73 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.07 MB 1.07 MB ✓
link.js 1.12 MB 1.12 MB ✓
routerDirect.js 1.11 MB 1.11 MB ✓
withRouter.js 1.11 MB 1.11 MB ✓
Overall change 5.48 MB 5.48 MB ✓
Commit: fcdd297

@ijjk
Copy link
Member

ijjk commented Nov 4, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
buildDuration 12.9s 13.5s ⚠️ +532ms
nodeModulesSize 90.5 MB 90.5 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.426 2.386 -0.04
/ avg req/sec 1030.48 1047.95 +17.47
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.319 1.28 -0.04
/error-in-render avg req/sec 1895.12 1952.36 +57.24
Client Bundles (main, webpack, commons)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
677f882d2ed8..1f3c.js gzip 11.2 kB 11.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-be398bc..d262.js gzip 7.33 kB 7.33 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.3 kB 58.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
677f882d2ed8..dule.js gzip 7.02 kB 7.02 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-378f0c6..dule.js gzip 6.33 kB 6.33 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
polyfills-b5..1119.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-a674d88..ccde.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-a4469f3..dule.js gzip 1.32 kB 1.32 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.41 kB 5.41 kB ✓
Client Build Manifests
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 994 B 994 B ✓
Overall change 3 kB 3 kB ✓
Serverless Mode
General
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
buildDuration 14.8s 14.5s -277ms
nodeModulesSize 90.5 MB 90.5 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
677f882d2ed8..1f3c.js gzip 11.2 kB 11.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-be398bc..d262.js gzip 7.33 kB 7.33 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.3 kB 58.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
677f882d2ed8..dule.js gzip 7.02 kB 7.02 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-378f0c6..dule.js gzip 6.33 kB 6.33 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
polyfills-b5..1119.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-a674d88..ccde.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-a4469f3..dule.js gzip 1.32 kB 1.32 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.41 kB 5.41 kB ✓
Client Build Manifests
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_error.js 1.07 MB 1.07 MB ✓
404.html 4.73 kB 4.73 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.07 MB 1.07 MB ✓
link.js 1.12 MB 1.12 MB ✓
routerDirect.js 1.11 MB 1.11 MB ✓
withRouter.js 1.11 MB 1.11 MB ✓
Overall change 5.48 MB 5.48 MB ✓
Commit: 76f61b6

@ijjk
Copy link
Member

ijjk commented Nov 5, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
buildDuration 14.5s 14.2s -305ms
nodeModulesSize 87 MB 87 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.586 2.666 ⚠️ +0.08
/ avg req/sec 966.92 937.79 ⚠️ -29.13
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.367 1.569 ⚠️ +0.2
/error-in-render avg req/sec 1828.84 1593.6 ⚠️ -235.24
Client Bundles (main, webpack, commons)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
677f882d2ed8..7d3b.js gzip 11.3 kB 11.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-7a348ff..641f.js gzip 7.37 kB 7.37 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.4 kB 58.4 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
677f882d2ed8..dule.js gzip 7.04 kB 7.04 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-00e5ec9..dule.js gzip 6.37 kB 6.37 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-fca3d..2eb1.js gzip 3.44 kB 3.44 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-a674d88..ccde.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-a4469f3..dule.js gzip 1.32 kB 1.32 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.41 kB 5.41 kB ✓
Client Build Manifests
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_buildManifest.js gzip 321 B 321 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 994 B 994 B ✓
Overall change 3 kB 3 kB ✓
Serverless Mode
General
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
buildDuration 15.8s 15.4s -406ms
nodeModulesSize 87 MB 87 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
677f882d2ed8..7d3b.js gzip 11.3 kB 11.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-7a348ff..641f.js gzip 7.37 kB 7.37 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.4 kB 58.4 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
677f882d2ed8..dule.js gzip 7.04 kB 7.04 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-00e5ec9..dule.js gzip 6.37 kB 6.37 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-fca3d..2eb1.js gzip 3.44 kB 3.44 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-a674d88..ccde.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-a4469f3..dule.js gzip 1.32 kB 1.32 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.41 kB 5.41 kB ✓
Client Build Manifests
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_buildManifest.js gzip 321 B 321 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 651 B 651 B ✓
Serverless bundles
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_error.js 1.07 MB 1.07 MB ✓
404.html 4.73 kB 4.73 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.07 MB 1.07 MB ✓
link.js 1.12 MB 1.12 MB ✓
routerDirect.js 1.11 MB 1.11 MB ✓
withRouter.js 1.11 MB 1.11 MB ✓
Overall change 5.49 MB 5.49 MB ✓
Commit: 992c4ff

@ijjk
Copy link
Member

ijjk commented Nov 5, 2020

Failing test suites

Commit: 992c4ff

test/integration/font-optimization/test/index.test.js

  • Font optimization for SSR apps > should minify the css
  • Font optimization for emulated serverless apps > should minify the css
  • Font optimization for serverless apps > should minify the css
Expand output

● Font optimization for SSR apps › should minify the css

expect(received).toStrictEqual(expected) // deep equality

- Expected  - 1
+ Received  + 1

  Object {
    "https://fonts.googleapis.com/css2?family=Modak": "@font-face{font-family:'Modak';font-style:normal;font-weight:400;src:local('Modak'),url(https://fonts.gstatic.com/s/modak/v5/EJRYQgs1XtIEsnME.woff) format('woff')}@font-face{font-family:'Modak';font-style:normal;font-weight:400;src:local('Modak'),url(https://fonts.gstatic.com/s/modak/v5/EJRYQgs1XtIEskMB-hR77LKVTy8.woff2) format('woff2');unicode-range:U+0900-097F,U+1CD0-1CF6,U+1CF8-1CF9,U+200C-200D,U+20A8,U+20B9,U+25CC,U+A830-A839,U+A8E0-A8FB}@font-face{font-family:'Modak';font-style:normal;font-weight:400;src:local('Modak'),url(https://fonts.gstatic.com/s/modak/v5/EJRYQgs1XtIEskMO-hR77LKVTy8.woff2) format('woff2');unicode-range:U+0100-024F,U+0259,U+1E00-1EFF,U+2020,U+20A0-20AB,U+20AD-20CF,U+2113,U+2C60-2C7F,U+A720-A7FF}@font-face{font-family:'Modak';font-style:normal;font-weight:400;src:local('Modak'),url(https://fonts.gstatic.com/s/modak/v5/EJRYQgs1XtIEskMA-hR77LKV.woff2) format('woff2');unicode-range:U+0000-00FF,U+0131,U+0152-0153,U+02BB-02BC,U+02C6,U+02DA,U+02DC,U+2000-206F,U+2074,U+20AC,U+2122,U+2191,U+2193,U+2212,U+2215,U+FEFF,U+FFFD}",
    "https://fonts.googleapis.com/css2?family=Roboto:wght@700": "@font-face{font-family:'Roboto';font-style:normal;font-weight:700;src:local('Roboto Bold'),local('Roboto-Bold'),url(https://fonts.gstatic.com/s/roboto/v20/KFOlCnqEu92Fr1MmWUlvAA.woff) format('woff')}@font-face{font-family:'Roboto';font-style:normal;font-weight:700;src:local('Roboto Bold'),local('Roboto-Bold'),url(https://fonts.gstatic.com/s/roboto/v20/KFOlCnqEu92Fr1MmWUlfCRc4AMP6lbBP.woff2) format('woff2');unicode-range:U+0460-052F,U+1C80-1C88,U+20B4,U+2DE0-2DFF,U+A640-A69F,U+FE2E-FE2F}@font-face{font-family:'Roboto';font-style:normal;font-weight:700;src:local('Roboto Bold'),local('Roboto-Bold'),url(https://fonts.gstatic.com/s/roboto/v20/KFOlCnqEu92Fr1MmWUlfABc4AMP6lbBP.woff2) format('woff2');unicode-range:U+0400-045F,U+0490-0491,U+04B0-04B1,U+2116}@font-face{font-family:'Roboto';font-style:normal;font-weight:700;src:local('Roboto Bold'),local('Roboto-Bold'),url(https://fonts.gstatic.com/s/roboto/v20/KFOlCnqEu92Fr1MmWUlfCBc4AMP6lbBP.woff2) format('woff2');unicode-range:U+1F00-1FFF}@font-face{font-family:'Roboto';font-style:normal;font-weight:700;src:local('Roboto Bold'),local('Roboto-Bold'),url(https://fonts.gstatic.com/s/roboto/v20/KFOlCnqEu92Fr1MmWUlfBxc4AMP6lbBP.woff2) format('woff2');unicode-range:U+0370-03FF}@font-face{font-family:'Roboto';font-style:normal;font-weight:700;src:local('Roboto Bold'),local('Roboto-Bold'),url(https://fonts.gstatic.com/s/roboto/v20/KFOlCnqEu92Fr1MmWUlfCxc4AMP6lbBP.woff2) format('woff2');unicode-range:U+0102-0103,U+0110-0111,U+0128-0129,U+0168-0169,U+01A0-01A1,U+01AF-01B0,U+1EA0-1EF9,U+20AB}@font-face{font-family:'Roboto';font-style:normal;font-weight:700;src:local('Roboto Bold'),local('Roboto-Bold'),url(https://fonts.gstatic.com/s/roboto/v20/KFOlCnqEu92Fr1MmWUlfChc4AMP6lbBP.woff2) format('woff2');unicode-range:U+0100-024F,U+0259,U+1E00-1EFF,U+2020,U+20A0-20AB,U+20AD-20CF,U+2113,U+2C60-2C7F,U+A720-A7FF}@font-face{font-family:'Roboto';font-style:normal;font-weight:700;src:local('Roboto Bold'),local('Roboto-Bold'),url(https://fonts.gstatic.com/s/roboto/v20/KFOlCnqEu92Fr1MmWUlfBBc4AMP6lQ.woff2) format('woff2');unicode-range:U+0000-00FF,U+0131,U+0152-0153,U+02BB-02BC,U+02C6,U+02DA,U+02DC,U+2000-206F,U+2074,U+20AC,U+2122,U+2191,U+2193,U+2212,U+2215,U+FEFF,U+FFFD}",
-   "https://fonts.googleapis.com/css?family=Voces": "@font-face{font-family:'Voces';font-style:normal;font-weight:400;src:local('Voces Regular'),local('Voces-Regular'),url(https://fonts.gstatic.com/s/voces/v10/-F6_fjJyLyU8d7PGDmk.woff) format('woff')}@font-face{font-family:'Voces';font-style:normal;font-weight:400;src:local('Voces Regular'),local('Voces-Regular'),url(https://fonts.gstatic.com/s/voces/v10/-F6_fjJyLyU8d7PIDm_6pClI_ik.woff2) format('woff2');unicode-range:U+0100-024F,U+0259,U+1E00-1EFF,U+2020,U+20A0-20AB,U+20AD-20CF,U+2113,U+2C60-2C7F,U+A720-A7FF}@font-face{font-family:'Voces';font-style:normal;font-weight:400;src:local('Voces Regular'),local('Voces-Regular'),url(https://fonts.gstatic.com/s/voces/v10/-F6_fjJyLyU8d7PGDm_6pClI.woff2) format('woff2');unicode-range:U+0000-00FF,U+0131,U+0152-0153,U+02BB-02BC,U+02C6,U+02DA,U+02DC,U+2000-206F,U+2074,U+20AC,U+2122,U+2191,U+2193,U+2212,U+2215,U+FEFF,U+FFFD}",
+   "https://fonts.googleapis.com/css?family=Voces": "@font-face{font-family:'Voces';font-style:normal;font-weight:400;src:local('Voces Regular'),local('Voces-Regular'),url(https://fonts.gstatic.com/s/voces/v10/-F6_fjJyLyU8d7PGDmk.woff) format('woff')}@font-face{font-family:'Voces';font-style:normal;font-weight:400;src:url(https://fonts.gstatic.com/s/voces/v10/-F6_fjJyLyU8d7PIDm_6pClI_ik.woff2?ce=43710007) format('woff2');unicode-range:U+0100-024F,U+0259,U+1E00-1EFF,U+2020,U+20A0-20AB,U+20AD-20CF,U+2113,U+2C60-2C7F,U+A720-A7FF}@font-face{font-family:'Voces';font-style:normal;font-weight:400;src:url(https://fonts.gstatic.com/s/voces/v10/-F6_fjJyLyU8d7PGDm_6pClI.woff2?ce=43710007) format('woff2');unicode-range:U+0000-00FF,U+0131,U+0152-0153,U+02BB-02BC,U+02C6,U+02DA,U+02DC,U+2000-206F,U+2074,U+20AC,U+2122,U+2191,U+2193,U+2212,U+2215,U+FEFF,U+FFFD}",
  }

  101 |     })
  102 | 
> 103 |     expect(testCss).toStrictEqual(snapshotCss)
      |                     ^
  104 |   })
  105 | }
  106 | 

  at Object.<anonymous> (integration/font-optimization/test/index.test.js:103:21)

● Font optimization for serverless apps › should minify the css

expect(received).toStrictEqual(expected) // deep equality

- Expected  - 1
+ Received  + 1

  Object {
    "https://fonts.googleapis.com/css2?family=Modak": "@font-face{font-family:'Modak';font-style:normal;font-weight:400;src:local('Modak'),url(https://fonts.gstatic.com/s/modak/v5/EJRYQgs1XtIEsnME.woff) format('woff')}@font-face{font-family:'Modak';font-style:normal;font-weight:400;src:local('Modak'),url(https://fonts.gstatic.com/s/modak/v5/EJRYQgs1XtIEskMB-hR77LKVTy8.woff2) format('woff2');unicode-range:U+0900-097F,U+1CD0-1CF6,U+1CF8-1CF9,U+200C-200D,U+20A8,U+20B9,U+25CC,U+A830-A839,U+A8E0-A8FB}@font-face{font-family:'Modak';font-style:normal;font-weight:400;src:local('Modak'),url(https://fonts.gstatic.com/s/modak/v5/EJRYQgs1XtIEskMO-hR77LKVTy8.woff2) format('woff2');unicode-range:U+0100-024F,U+0259,U+1E00-1EFF,U+2020,U+20A0-20AB,U+20AD-20CF,U+2113,U+2C60-2C7F,U+A720-A7FF}@font-face{font-family:'Modak';font-style:normal;font-weight:400;src:local('Modak'),url(https://fonts.gstatic.com/s/modak/v5/EJRYQgs1XtIEskMA-hR77LKV.woff2) format('woff2');unicode-range:U+0000-00FF,U+0131,U+0152-0153,U+02BB-02BC,U+02C6,U+02DA,U+02DC,U+2000-206F,U+2074,U+20AC,U+2122,U+2191,U+2193,U+2212,U+2215,U+FEFF,U+FFFD}",
    "https://fonts.googleapis.com/css2?family=Roboto:wght@700": "@font-face{font-family:'Roboto';font-style:normal;font-weight:700;src:local('Roboto Bold'),local('Roboto-Bold'),url(https://fonts.gstatic.com/s/roboto/v20/KFOlCnqEu92Fr1MmWUlvAA.woff) format('woff')}@font-face{font-family:'Roboto';font-style:normal;font-weight:700;src:local('Roboto Bold'),local('Roboto-Bold'),url(https://fonts.gstatic.com/s/roboto/v20/KFOlCnqEu92Fr1MmWUlfCRc4AMP6lbBP.woff2) format('woff2');unicode-range:U+0460-052F,U+1C80-1C88,U+20B4,U+2DE0-2DFF,U+A640-A69F,U+FE2E-FE2F}@font-face{font-family:'Roboto';font-style:normal;font-weight:700;src:local('Roboto Bold'),local('Roboto-Bold'),url(https://fonts.gstatic.com/s/roboto/v20/KFOlCnqEu92Fr1MmWUlfABc4AMP6lbBP.woff2) format('woff2');unicode-range:U+0400-045F,U+0490-0491,U+04B0-04B1,U+2116}@font-face{font-family:'Roboto';font-style:normal;font-weight:700;src:local('Roboto Bold'),local('Roboto-Bold'),url(https://fonts.gstatic.com/s/roboto/v20/KFOlCnqEu92Fr1MmWUlfCBc4AMP6lbBP.woff2) format('woff2');unicode-range:U+1F00-1FFF}@font-face{font-family:'Roboto';font-style:normal;font-weight:700;src:local('Roboto Bold'),local('Roboto-Bold'),url(https://fonts.gstatic.com/s/roboto/v20/KFOlCnqEu92Fr1MmWUlfBxc4AMP6lbBP.woff2) format('woff2');unicode-range:U+0370-03FF}@font-face{font-family:'Roboto';font-style:normal;font-weight:700;src:local('Roboto Bold'),local('Roboto-Bold'),url(https://fonts.gstatic.com/s/roboto/v20/KFOlCnqEu92Fr1MmWUlfCxc4AMP6lbBP.woff2) format('woff2');unicode-range:U+0102-0103,U+0110-0111,U+0128-0129,U+0168-0169,U+01A0-01A1,U+01AF-01B0,U+1EA0-1EF9,U+20AB}@font-face{font-family:'Roboto';font-style:normal;font-weight:700;src:local('Roboto Bold'),local('Roboto-Bold'),url(https://fonts.gstatic.com/s/roboto/v20/KFOlCnqEu92Fr1MmWUlfChc4AMP6lbBP.woff2) format('woff2');unicode-range:U+0100-024F,U+0259,U+1E00-1EFF,U+2020,U+20A0-20AB,U+20AD-20CF,U+2113,U+2C60-2C7F,U+A720-A7FF}@font-face{font-family:'Roboto';font-style:normal;font-weight:700;src:local('Roboto Bold'),local('Roboto-Bold'),url(https://fonts.gstatic.com/s/roboto/v20/KFOlCnqEu92Fr1MmWUlfBBc4AMP6lQ.woff2) format('woff2');unicode-range:U+0000-00FF,U+0131,U+0152-0153,U+02BB-02BC,U+02C6,U+02DA,U+02DC,U+2000-206F,U+2074,U+20AC,U+2122,U+2191,U+2193,U+2212,U+2215,U+FEFF,U+FFFD}",
-   "https://fonts.googleapis.com/css?family=Voces": "@font-face{font-family:'Voces';font-style:normal;font-weight:400;src:local('Voces Regular'),local('Voces-Regular'),url(https://fonts.gstatic.com/s/voces/v10/-F6_fjJyLyU8d7PGDmk.woff) format('woff')}@font-face{font-family:'Voces';font-style:normal;font-weight:400;src:local('Voces Regular'),local('Voces-Regular'),url(https://fonts.gstatic.com/s/voces/v10/-F6_fjJyLyU8d7PIDm_6pClI_ik.woff2) format('woff2');unicode-range:U+0100-024F,U+0259,U+1E00-1EFF,U+2020,U+20A0-20AB,U+20AD-20CF,U+2113,U+2C60-2C7F,U+A720-A7FF}@font-face{font-family:'Voces';font-style:normal;font-weight:400;src:local('Voces Regular'),local('Voces-Regular'),url(https://fonts.gstatic.com/s/voces/v10/-F6_fjJyLyU8d7PGDm_6pClI.woff2) format('woff2');unicode-range:U+0000-00FF,U+0131,U+0152-0153,U+02BB-02BC,U+02C6,U+02DA,U+02DC,U+2000-206F,U+2074,U+20AC,U+2122,U+2191,U+2193,U+2212,U+2215,U+FEFF,U+FFFD}",
+   "https://fonts.googleapis.com/css?family=Voces": "@font-face{font-family:'Voces';font-style:normal;font-weight:400;src:local('Voces Regular'),local('Voces-Regular'),url(https://fonts.gstatic.com/s/voces/v10/-F6_fjJyLyU8d7PGDmk.woff) format('woff')}@font-face{font-family:'Voces';font-style:normal;font-weight:400;src:url(https://fonts.gstatic.com/s/voces/v10/-F6_fjJyLyU8d7PIDm_6pClI_ik.woff2?ce=43710007) format('woff2');unicode-range:U+0100-024F,U+0259,U+1E00-1EFF,U+2020,U+20A0-20AB,U+20AD-20CF,U+2113,U+2C60-2C7F,U+A720-A7FF}@font-face{font-family:'Voces';font-style:normal;font-weight:400;src:url(https://fonts.gstatic.com/s/voces/v10/-F6_fjJyLyU8d7PGDm_6pClI.woff2?ce=43710007) format('woff2');unicode-range:U+0000-00FF,U+0131,U+0152-0153,U+02BB-02BC,U+02C6,U+02DA,U+02DC,U+2000-206F,U+2074,U+20AC,U+2122,U+2191,U+2193,U+2212,U+2215,U+FEFF,U+FFFD}",
  }

  101 |     })
  102 | 
> 103 |     expect(testCss).toStrictEqual(snapshotCss)
      |                     ^
  104 |   })
  105 | }
  106 | 

  at Object.<anonymous> (integration/font-optimization/test/index.test.js:103:21)

● Font optimization for emulated serverless apps › should minify the css

expect(received).toStrictEqual(expected) // deep equality

- Expected  - 1
+ Received  + 1

  Object {
    "https://fonts.googleapis.com/css2?family=Modak": "@font-face{font-family:'Modak';font-style:normal;font-weight:400;src:local('Modak'),url(https://fonts.gstatic.com/s/modak/v5/EJRYQgs1XtIEsnME.woff) format('woff')}@font-face{font-family:'Modak';font-style:normal;font-weight:400;src:local('Modak'),url(https://fonts.gstatic.com/s/modak/v5/EJRYQgs1XtIEskMB-hR77LKVTy8.woff2) format('woff2');unicode-range:U+0900-097F,U+1CD0-1CF6,U+1CF8-1CF9,U+200C-200D,U+20A8,U+20B9,U+25CC,U+A830-A839,U+A8E0-A8FB}@font-face{font-family:'Modak';font-style:normal;font-weight:400;src:local('Modak'),url(https://fonts.gstatic.com/s/modak/v5/EJRYQgs1XtIEskMO-hR77LKVTy8.woff2) format('woff2');unicode-range:U+0100-024F,U+0259,U+1E00-1EFF,U+2020,U+20A0-20AB,U+20AD-20CF,U+2113,U+2C60-2C7F,U+A720-A7FF}@font-face{font-family:'Modak';font-style:normal;font-weight:400;src:local('Modak'),url(https://fonts.gstatic.com/s/modak/v5/EJRYQgs1XtIEskMA-hR77LKV.woff2) format('woff2');unicode-range:U+0000-00FF,U+0131,U+0152-0153,U+02BB-02BC,U+02C6,U+02DA,U+02DC,U+2000-206F,U+2074,U+20AC,U+2122,U+2191,U+2193,U+2212,U+2215,U+FEFF,U+FFFD}",
    "https://fonts.googleapis.com/css2?family=Roboto:wght@700": "@font-face{font-family:'Roboto';font-style:normal;font-weight:700;src:local('Roboto Bold'),local('Roboto-Bold'),url(https://fonts.gstatic.com/s/roboto/v20/KFOlCnqEu92Fr1MmWUlvAA.woff) format('woff')}@font-face{font-family:'Roboto';font-style:normal;font-weight:700;src:local('Roboto Bold'),local('Roboto-Bold'),url(https://fonts.gstatic.com/s/roboto/v20/KFOlCnqEu92Fr1MmWUlfCRc4AMP6lbBP.woff2) format('woff2');unicode-range:U+0460-052F,U+1C80-1C88,U+20B4,U+2DE0-2DFF,U+A640-A69F,U+FE2E-FE2F}@font-face{font-family:'Roboto';font-style:normal;font-weight:700;src:local('Roboto Bold'),local('Roboto-Bold'),url(https://fonts.gstatic.com/s/roboto/v20/KFOlCnqEu92Fr1MmWUlfABc4AMP6lbBP.woff2) format('woff2');unicode-range:U+0400-045F,U+0490-0491,U+04B0-04B1,U+2116}@font-face{font-family:'Roboto';font-style:normal;font-weight:700;src:local('Roboto Bold'),local('Roboto-Bold'),url(https://fonts.gstatic.com/s/roboto/v20/KFOlCnqEu92Fr1MmWUlfCBc4AMP6lbBP.woff2) format('woff2');unicode-range:U+1F00-1FFF}@font-face{font-family:'Roboto';font-style:normal;font-weight:700;src:local('Roboto Bold'),local('Roboto-Bold'),url(https://fonts.gstatic.com/s/roboto/v20/KFOlCnqEu92Fr1MmWUlfBxc4AMP6lbBP.woff2) format('woff2');unicode-range:U+0370-03FF}@font-face{font-family:'Roboto';font-style:normal;font-weight:700;src:local('Roboto Bold'),local('Roboto-Bold'),url(https://fonts.gstatic.com/s/roboto/v20/KFOlCnqEu92Fr1MmWUlfCxc4AMP6lbBP.woff2) format('woff2');unicode-range:U+0102-0103,U+0110-0111,U+0128-0129,U+0168-0169,U+01A0-01A1,U+01AF-01B0,U+1EA0-1EF9,U+20AB}@font-face{font-family:'Roboto';font-style:normal;font-weight:700;src:local('Roboto Bold'),local('Roboto-Bold'),url(https://fonts.gstatic.com/s/roboto/v20/KFOlCnqEu92Fr1MmWUlfChc4AMP6lbBP.woff2) format('woff2');unicode-range:U+0100-024F,U+0259,U+1E00-1EFF,U+2020,U+20A0-20AB,U+20AD-20CF,U+2113,U+2C60-2C7F,U+A720-A7FF}@font-face{font-family:'Roboto';font-style:normal;font-weight:700;src:local('Roboto Bold'),local('Roboto-Bold'),url(https://fonts.gstatic.com/s/roboto/v20/KFOlCnqEu92Fr1MmWUlfBBc4AMP6lQ.woff2) format('woff2');unicode-range:U+0000-00FF,U+0131,U+0152-0153,U+02BB-02BC,U+02C6,U+02DA,U+02DC,U+2000-206F,U+2074,U+20AC,U+2122,U+2191,U+2193,U+2212,U+2215,U+FEFF,U+FFFD}",
-   "https://fonts.googleapis.com/css?family=Voces": "@font-face{font-family:'Voces';font-style:normal;font-weight:400;src:local('Voces Regular'),local('Voces-Regular'),url(https://fonts.gstatic.com/s/voces/v10/-F6_fjJyLyU8d7PGDmk.woff) format('woff')}@font-face{font-family:'Voces';font-style:normal;font-weight:400;src:local('Voces Regular'),local('Voces-Regular'),url(https://fonts.gstatic.com/s/voces/v10/-F6_fjJyLyU8d7PIDm_6pClI_ik.woff2) format('woff2');unicode-range:U+0100-024F,U+0259,U+1E00-1EFF,U+2020,U+20A0-20AB,U+20AD-20CF,U+2113,U+2C60-2C7F,U+A720-A7FF}@font-face{font-family:'Voces';font-style:normal;font-weight:400;src:local('Voces Regular'),local('Voces-Regular'),url(https://fonts.gstatic.com/s/voces/v10/-F6_fjJyLyU8d7PGDm_6pClI.woff2) format('woff2');unicode-range:U+0000-00FF,U+0131,U+0152-0153,U+02BB-02BC,U+02C6,U+02DA,U+02DC,U+2000-206F,U+2074,U+20AC,U+2122,U+2191,U+2193,U+2212,U+2215,U+FEFF,U+FFFD}",
+   "https://fonts.googleapis.com/css?family=Voces": "@font-face{font-family:'Voces';font-style:normal;font-weight:400;src:local('Voces Regular'),local('Voces-Regular'),url(https://fonts.gstatic.com/s/voces/v10/-F6_fjJyLyU8d7PGDmk.woff) format('woff')}@font-face{font-family:'Voces';font-style:normal;font-weight:400;src:url(https://fonts.gstatic.com/s/voces/v10/-F6_fjJyLyU8d7PIDm_6pClI_ik.woff2?ce=43710007) format('woff2');unicode-range:U+0100-024F,U+0259,U+1E00-1EFF,U+2020,U+20A0-20AB,U+20AD-20CF,U+2113,U+2C60-2C7F,U+A720-A7FF}@font-face{font-family:'Voces';font-style:normal;font-weight:400;src:url(https://fonts.gstatic.com/s/voces/v10/-F6_fjJyLyU8d7PGDm_6pClI.woff2?ce=43710007) format('woff2');unicode-range:U+0000-00FF,U+0131,U+0152-0153,U+02BB-02BC,U+02C6,U+02DA,U+02DC,U+2000-206F,U+2074,U+20AC,U+2122,U+2191,U+2193,U+2212,U+2215,U+FEFF,U+FFFD}",
  }

  101 |     })
  102 | 
> 103 |     expect(testCss).toStrictEqual(snapshotCss)
      |                     ^
  104 |   })
  105 | }
  106 | 

  at Object.<anonymous> (integration/font-optimization/test/index.test.js:103:21)

@ijjk
Copy link
Member

ijjk commented Nov 6, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
buildDuration 15s 14.1s -927ms
nodeModulesSize 84.9 MB 84.9 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.598 2.72 ⚠️ +0.12
/ avg req/sec 962.31 918.99 ⚠️ -43.32
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.468 1.564 ⚠️ +0.1
/error-in-render avg req/sec 1702.74 1598.32 ⚠️ -104.42
Client Bundles (main, webpack, commons)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
677f882d2ed8..7d3b.js gzip 11.3 kB 11.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-4066db0..605e.js gzip 7.39 kB 7.39 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.4 kB 58.4 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
677f882d2ed8..dule.js gzip 7.04 kB 7.04 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-d0da7fd..dule.js gzip 6.38 kB 6.38 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-fca3d..2eb1.js gzip 3.44 kB 3.44 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-03d24c6..d1c7.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-dfbbfbd..dule.js gzip 1.32 kB 1.32 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.41 kB 5.41 kB ✓
Client Build Manifests
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 996 B 996 B ✓
Overall change 3.01 kB 3.01 kB ✓
Serverless Mode
General
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
buildDuration 16.2s 16.1s -88ms
nodeModulesSize 84.9 MB 84.9 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
677f882d2ed8..7d3b.js gzip 11.3 kB 11.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-4066db0..605e.js gzip 7.39 kB 7.39 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.4 kB 58.4 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
677f882d2ed8..dule.js gzip 7.04 kB 7.04 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-d0da7fd..dule.js gzip 6.38 kB 6.38 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-fca3d..2eb1.js gzip 3.44 kB 3.44 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-03d24c6..d1c7.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-dfbbfbd..dule.js gzip 1.32 kB 1.32 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.41 kB 5.41 kB ✓
Client Build Manifests
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_error.js 914 kB 914 kB ✓
404.html 4.73 kB 4.73 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 914 kB 914 kB ✓
link.js 962 kB 962 kB ✓
routerDirect.js 956 kB 956 kB ✓
withRouter.js 956 kB 956 kB ✓
Overall change 4.71 MB 4.71 MB ✓
Commit: 547aad3

@ijjk
Copy link
Member

ijjk commented Nov 8, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
buildDuration 13.9s 13.4s -478ms
nodeModulesSize 84.9 MB 84.9 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.479 2.465 -0.01
/ avg req/sec 1008.48 1014.3 +5.82
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.344 1.363 ⚠️ +0.02
/error-in-render avg req/sec 1859.89 1834.8 ⚠️ -25.09
Client Bundles (main, webpack, commons)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
677f882d2ed8..7d3b.js gzip 11.3 kB 11.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-84e37d7..9cdb.js gzip 7.4 kB 7.4 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.4 kB 58.4 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
677f882d2ed8..dule.js gzip 7.04 kB 7.04 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-614d615..dule.js gzip 6.39 kB 6.39 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-fca3d..2eb1.js gzip 3.44 kB 3.44 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-8a9d104..0e42.js gzip 1.55 kB 1.55 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.96 kB 7.96 kB ✓
Client Pages Modern
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-d1cfb87..dule.js gzip 1.49 kB 1.49 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.59 kB 5.59 kB ✓
Client Build Manifests
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 995 B 995 B ✓
Overall change 3.01 kB 3.01 kB ✓
Serverless Mode
General
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
buildDuration 15.3s 15.2s -115ms
nodeModulesSize 84.9 MB 84.9 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
677f882d2ed8..7d3b.js gzip 11.3 kB 11.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-84e37d7..9cdb.js gzip 7.4 kB 7.4 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.4 kB 58.4 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
677f882d2ed8..dule.js gzip 7.04 kB 7.04 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-614d615..dule.js gzip 6.39 kB 6.39 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-fca3d..2eb1.js gzip 3.44 kB 3.44 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-8a9d104..0e42.js gzip 1.55 kB 1.55 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.96 kB 7.96 kB ✓
Client Pages Modern
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-d1cfb87..dule.js gzip 1.49 kB 1.49 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.59 kB 5.59 kB ✓
Client Build Manifests
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_error.js 915 kB 915 kB ✓
404.html 4.73 kB 4.73 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 915 kB 915 kB ✓
link.js 964 kB 964 kB ✓
routerDirect.js 957 kB 957 kB ✓
withRouter.js 957 kB 957 kB ✓
Overall change 4.72 MB 4.72 MB ✓
Commit: 20b5d3d

@ijjk
Copy link
Member

ijjk commented Nov 12, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
buildDuration 13.8s 13.6s -227ms
nodeModulesSize 84.8 MB 84.8 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.544 2.608 ⚠️ +0.06
/ avg req/sec 982.82 958.48 ⚠️ -24.34
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.487 1.556 ⚠️ +0.07
/error-in-render avg req/sec 1680.96 1606.83 ⚠️ -74.13
Client Bundles (main, webpack, commons)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
677f882d2ed8..d4b6.js gzip 12.6 kB 12.6 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-43dd9e5..8439.js gzip 6.48 kB 6.48 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.8 kB 58.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
677f882d2ed8..dule.js gzip 8.22 kB 8.22 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-472f7d5..dule.js gzip 5.58 kB 5.58 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.5 kB 53.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_app-3b0cf13..85f8.js gzip 1.28 kB 1.28 kB ✓
_error-6f635..c393.js gzip 3.44 kB 3.44 kB ✓
hooks-d4ffc3..9e0f.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d9a15a0..130a.js gzip 1.57 kB 1.57 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.98 kB 7.98 kB ✓
Client Pages Modern
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-f2fcc..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-973cce3..dule.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.6 kB 5.6 kB ✓
Client Build Manifests
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_buildManifest.js gzip 321 B 321 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
index.html gzip 970 B 970 B ✓
link.html gzip 977 B 977 B ✓
withRouter.html gzip 962 B 962 B ✓
Overall change 2.91 kB 2.91 kB ✓
Serverless Mode
General
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
buildDuration 15.3s 15.4s ⚠️ +104ms
nodeModulesSize 84.8 MB 84.8 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
677f882d2ed8..d4b6.js gzip 12.6 kB 12.6 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-43dd9e5..8439.js gzip 6.48 kB 6.48 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.8 kB 58.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
677f882d2ed8..dule.js gzip 8.22 kB 8.22 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-472f7d5..dule.js gzip 5.58 kB 5.58 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.5 kB 53.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_app-3b0cf13..85f8.js gzip 1.28 kB 1.28 kB ✓
_error-6f635..c393.js gzip 3.44 kB 3.44 kB ✓
hooks-d4ffc3..9e0f.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d9a15a0..130a.js gzip 1.57 kB 1.57 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.98 kB 7.98 kB ✓
Client Pages Modern
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-f2fcc..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-973cce3..dule.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.6 kB 5.6 kB ✓
Client Build Manifests
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_buildManifest.js gzip 321 B 321 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 651 B 651 B ✓
Serverless bundles
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_error.js 916 kB 916 kB ✓
404.html 4.61 kB 4.61 kB ✓
hooks.html 3.86 kB 3.86 kB ✓
index.js 916 kB 916 kB ✓
link.js 974 kB 974 kB ✓
routerDirect.js 967 kB 967 kB ✓
withRouter.js 967 kB 967 kB ✓
Overall change 4.75 MB 4.75 MB ✓
Commit: 7e4ccea

@vercel vercel bot temporarily deployed to Preview December 12, 2020 14:41 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 12, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
buildDuration 9.9s 9.8s -92ms
nodeModulesSize 82.5 MB 82.5 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.357 2.407 ⚠️ +0.05
/ avg req/sec 1060.51 1038.78 ⚠️ -21.73
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.24 1.251 ⚠️ +0.01
/error-in-render avg req/sec 2015.83 1998.64 ⚠️ -17.19
Client Bundles (main, webpack, commons)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
677f882d2ed8..c0a8.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-3e8cb31..cddc.js gzip 6.56 kB 6.56 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-01375..90b6.js gzip 3.69 kB 3.69 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-db223d9..dbd7.js gzip 1.61 kB 1.61 kB ✓
routerDirect..fd29.js gzip 303 B 303 B ✓
withRouter-b..76ae.js gzip 302 B 302 B ✓
Overall change 8.31 kB 8.31 kB ✓
Client Build Manifests
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_buildManifest.js gzip 322 B 322 B ✓
Overall change 322 B 322 B ✓
Rendered Page Sizes
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
index.html gzip 613 B 613 B ✓
link.html gzip 618 B 618 B ✓
withRouter.html gzip 606 B 606 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
buildDuration 11.5s 11.6s ⚠️ +41ms
nodeModulesSize 82.5 MB 82.5 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
677f882d2ed8..c0a8.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-3e8cb31..cddc.js gzip 6.56 kB 6.56 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-01375..90b6.js gzip 3.69 kB 3.69 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-db223d9..dbd7.js gzip 1.61 kB 1.61 kB ✓
routerDirect..fd29.js gzip 303 B 303 B ✓
withRouter-b..76ae.js gzip 302 B 302 B ✓
Overall change 8.31 kB 8.31 kB ✓
Client Build Manifests
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_buildManifest.js gzip 322 B 322 B ✓
Overall change 322 B 322 B ✓
Serverless bundles
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.16 MB 5.16 MB ✓
Commit: 6994635

justinphilpott
justinphilpott commented Dec 13, 2020
View reviewed changes
Copy link
Contributor Author

@justinphilpott justinphilpott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed unneeded lines in TSconf

examples/with-storybook-styled-jsx-scss/tsconfig.json Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview December 15, 2020 13:33 Inactive
@vercel vercel bot temporarily deployed to Preview December 15, 2020 13:34 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 15, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
buildDuration 10.1s 10.1s -52ms
nodeModulesSize 82.4 MB 82.4 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.367 2.385 ⚠️ +0.02
/ avg req/sec 1056.25 1048.06 ⚠️ -8.19
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.211 1.309 ⚠️ +0.1
/error-in-render avg req/sec 2064.89 1909.99 ⚠️ -154.9
Client Bundles (main, webpack, commons)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
677f882d2ed8..0679.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-b992ce4..2479.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59.1 kB 59.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-2cf0e..a0a0.js gzip 3.69 kB 3.69 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.31 kB 8.31 kB ✓
Client Build Manifests
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
index.html gzip 615 B 615 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
buildDuration 12s 11.9s -136ms
nodeModulesSize 82.4 MB 82.4 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
677f882d2ed8..0679.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-b992ce4..2479.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59.1 kB 59.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-2cf0e..a0a0.js gzip 3.69 kB 3.69 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.31 kB 8.31 kB ✓
Client Build Manifests
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.16 MB 5.16 MB ✓
Commit: cf28825

@justinphilpott
Copy link
Contributor Author

@lfades I have updated TS conf re your feedback, tested and tweaked the description. Please check, thanks! :)

@vercel vercel bot temporarily deployed to Preview December 23, 2020 13:54 Inactive
@justinphilpott
Copy link
Contributor Author

@lfades I have updated TS conf re your feedback, tested and tweaked the description. Please check, thanks! :)

The PR looks good to me, added one comment more about tsconfig and everything else is great!

Can you please check??

@ijjk
Copy link
Member

ijjk commented Dec 23, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
buildDuration 9.1s 9.8s ⚠️ +733ms
nodeModulesSize 82.6 MB 82.6 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.876 1.811 -0.06
/ avg req/sec 1332.27 1380.27 +48
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.118 1.136 ⚠️ +0.02
/error-in-render avg req/sec 2236.55 2200.24 ⚠️ -36.31
Client Bundles (main, webpack, commons)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e0d2962..b163.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-85785..a9f3.js gzip 3.44 kB 3.44 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.05 kB 8.05 kB ✓
Client Build Manifests
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
index.html gzip 612 B 612 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
buildDuration 11.5s 10.6s -928ms
nodeModulesSize 82.6 MB 82.6 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e0d2962..b163.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-85785..a9f3.js gzip 3.44 kB 3.44 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.05 kB 8.05 kB ✓
Client Build Manifests
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.16 MB 5.16 MB ✓
Commit: a3f8a79

@vercel vercel bot temporarily deployed to Preview December 31, 2020 12:34 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 31, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
buildDuration 8.8s 8.9s ⚠️ +134ms
nodeModulesSize 83 MB 83 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.713 1.743 ⚠️ +0.03
/ avg req/sec 1459.35 1434.25 ⚠️ -25.1
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.058 1.082 ⚠️ +0.02
/error-in-render avg req/sec 2363.27 2309.76 ⚠️ -53.51
Client Bundles (main, webpack, commons)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
677f882d2ed8..8a8f.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-5b13c61..eaca.js gzip 6.59 kB 6.59 kB ✓
webpack-7193..1446.js gzip 751 B 751 B ✓
Overall change 59.1 kB 59.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
polyfills-67..b7d1.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_app-6220e08..9a40.js gzip 1.28 kB 1.28 kB ✓
_error-4b0b5..2c91.js gzip 3.44 kB 3.44 kB ✓
hooks-5f309a..7282.js gzip 887 B 887 B ✓
index-57f580..c562.js gzip 227 B 227 B ✓
link-b862cd7..dba8.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bd82.js gzip 303 B 303 B ✓
withRouter-2..e384.js gzip 302 B 302 B ✓
Overall change 8.08 kB 8.08 kB ✓
Client Build Manifests
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
index.html gzip 616 B 616 B ✓
link.html gzip 622 B 622 B ✓
withRouter.html gzip 610 B 610 B ✓
Overall change 1.85 kB 1.85 kB ✓
Serverless Mode
General
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
buildDuration 10.5s 10.5s ⚠️ +59ms
nodeModulesSize 83 MB 83 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
677f882d2ed8..8a8f.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-5b13c61..eaca.js gzip 6.59 kB 6.59 kB ✓
webpack-7193..1446.js gzip 751 B 751 B ✓
Overall change 59.1 kB 59.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
polyfills-67..b7d1.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_app-6220e08..9a40.js gzip 1.28 kB 1.28 kB ✓
_error-4b0b5..2c91.js gzip 3.44 kB 3.44 kB ✓
hooks-5f309a..7282.js gzip 887 B 887 B ✓
index-57f580..c562.js gzip 227 B 227 B ✓
link-b862cd7..dba8.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bd82.js gzip 303 B 303 B ✓
withRouter-2..e384.js gzip 302 B 302 B ✓
Overall change 8.08 kB 8.08 kB ✓
Client Build Manifests
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.17 MB 5.17 MB ✓
Commit: 2af3813

@ijjk
Copy link
Member

ijjk commented Jan 2, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
buildDuration 10.9s 10.9s ⚠️ +57ms
nodeModulesSize 80.6 MB 80.6 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.236 2.322 ⚠️ +0.09
/ avg req/sec 1118.29 1076.77 ⚠️ -41.52
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.524 1.655 ⚠️ +0.13
/error-in-render avg req/sec 1640.21 1510.96 ⚠️ -129.25
Client Bundles (main, webpack, commons)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
677f882d2ed8..42af.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-a9a6f0d..a96d.js gzip 6.59 kB 6.59 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.3 kB 59.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-cfcb6..fe1c.js gzip 3.44 kB 3.44 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-705099c..c35d.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.08 kB 8.08 kB ✓
Client Build Manifests
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
index.html gzip 615 B 615 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
buildDuration 12.7s 13.4s ⚠️ +711ms
nodeModulesSize 80.6 MB 80.6 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
677f882d2ed8..42af.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-a9a6f0d..a96d.js gzip 6.59 kB 6.59 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.3 kB 59.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-cfcb6..fe1c.js gzip 3.44 kB 3.44 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-705099c..c35d.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.08 kB 8.08 kB ✓
Client Build Manifests
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.17 MB 5.17 MB ✓
Commit: f2fd813

@ijjk
Copy link
Member

ijjk commented Jan 4, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
buildDuration 10.7s 10.6s -58ms
nodeModulesSize 80.6 MB 80.6 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.081 2.189 ⚠️ +0.11
/ avg req/sec 1201.61 1142.02 ⚠️ -59.59
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.362 1.415 ⚠️ +0.05
/error-in-render avg req/sec 1835.24 1767.2 ⚠️ -68.04
Client Bundles (main, webpack, commons)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
677f882d2ed8..396f.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-a9a6f0d..a96d.js gzip 6.59 kB 6.59 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.3 kB 59.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-705099c..c35d.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
index.html gzip 615 B 615 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
buildDuration 13.2s 12.5s -687ms
nodeModulesSize 80.6 MB 80.6 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
677f882d2ed8..396f.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-a9a6f0d..a96d.js gzip 6.59 kB 6.59 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.3 kB 59.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-705099c..c35d.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.17 MB 5.17 MB ✓
Commit: 59dd23d

@ijjk
Copy link
Member

ijjk commented Jan 4, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
buildDuration 9s 8.9s -37ms
nodeModulesSize 80.6 MB 80.6 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.781 1.721 -0.06
/ avg req/sec 1404 1452.42 +48.42
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.125 1.115 -0.01
/error-in-render avg req/sec 2221.86 2241.18 +19.32
Client Bundles (main, webpack, commons)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
677f882d2ed8..396f.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-fd59cc5..1b57.js gzip 6.59 kB 6.59 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.3 kB 59.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-705099c..c35d.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
index.html gzip 613 B 613 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
buildDuration 10.6s 10.5s -160ms
nodeModulesSize 80.6 MB 80.6 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
677f882d2ed8..396f.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-fd59cc5..1b57.js gzip 6.59 kB 6.59 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.3 kB 59.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-705099c..c35d.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.17 MB 5.17 MB ✓
Commit: 42a26cd

lfades
lfades approved these changes Jan 4, 2021
View reviewed changes
Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justinphilpott Sorry for the late check. LGTM. Thank you and good work! 💯

@ijjk
Copy link
Member

ijjk commented Jan 4, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
buildDuration 9.7s 9.8s ⚠️ +109ms
nodeModulesSize 80.6 MB 80.6 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.859 1.964 ⚠️ +0.1
/ avg req/sec 1344.91 1273.11 ⚠️ -71.8
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.191 1.173 -0.02
/error-in-render avg req/sec 2098.81 2131.93 +33.12
Client Bundles (main, webpack, commons)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
677f882d2ed8..396f.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-6b712d3..3360.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.3 kB 59.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-705099c..c35d.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
index.html gzip 615 B 615 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
buildDuration 11.6s 11.8s ⚠️ +190ms
nodeModulesSize 80.6 MB 80.6 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
677f882d2ed8..396f.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-6b712d3..3360.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.3 kB 59.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-705099c..c35d.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary justinphilpott/next.js with-storybook-styled-jsx-scss Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.17 MB 5.17 MB ✓
Commit: a6df557

@kodiakhq kodiakhq bot merged commit 2a4887c into vercel:canary Jan 4, 2021
@justinphilpott justinphilpott deleted the with-storybook-styled-jsx-scss branch January 5, 2021 10:33
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lfades lfades lfades approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justinphilpott @ijjk @lfades