fix: issue #18256 - examples/with-firebase-authentication: fix to use getIdToken to get the token #18599

toshi1127 · 2020-11-01T01:05:59Z

Description

Fixes #18256

fix to use getIdToken to get the token.
- ref: https://firebase.google.com/docs/reference/js/firebase.User#getidtoken
StyledFirebaseAuth was running in SSR, so I removed the process of hiding it until the mount was finished.

…xample

ijjk · 2020-11-01T01:15:58Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	toshi1127/next.js feature/fix-with-firebase-authentication-example	Change
buildDuration	12.9s	13.3s	⚠️ +396ms
nodeModulesSize	90.1 MB	90.1 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	toshi1127/next.js feature/fix-with-firebase-authentication-example	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.395	2.435	⚠️ +0.04
/ avg req/sec	1043.65	1026.67	⚠️ -16.98
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.288	1.308	⚠️ +0.02
/error-in-render avg req/sec	1940.47	1911.42	⚠️ -29.05

Client Bundles (main, webpack, commons)

	vercel/next.js canary	toshi1127/next.js feature/fix-with-firebase-authentication-example	Change
677f882d2ed8..3aa9.js gzip	11.3 kB	11.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-41cbdbf..2c20.js gzip	7.35 kB	7.35 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.3 kB	58.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	toshi1127/next.js feature/fix-with-firebase-authentication-example	Change
677f882d2ed8..dule.js gzip	7.03 kB	7.03 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-9cda5a7..dule.js gzip	6.33 kB	6.33 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	toshi1127/next.js feature/fix-with-firebase-authentication-example	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	toshi1127/next.js feature/fix-with-firebase-authentication-example	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-41ceea0..6b62.js gzip	1.35 kB	1.35 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.75 kB	7.75 kB	✓

Client Pages Modern

	vercel/next.js canary	toshi1127/next.js feature/fix-with-firebase-authentication-example	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-2d41a89..dule.js gzip	1.31 kB	1.31 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.4 kB	5.4 kB	✓

Client Build Manifests

	vercel/next.js canary	toshi1127/next.js feature/fix-with-firebase-authentication-example	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Rendered Page Sizes

	vercel/next.js canary	toshi1127/next.js feature/fix-with-firebase-authentication-example	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	997 B	997 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode

General

	vercel/next.js canary	toshi1127/next.js feature/fix-with-firebase-authentication-example	Change
buildDuration	14.7s	14.6s	-129ms
nodeModulesSize	90.1 MB	90.1 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	toshi1127/next.js feature/fix-with-firebase-authentication-example	Change
677f882d2ed8..3aa9.js gzip	11.3 kB	11.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-41cbdbf..2c20.js gzip	7.35 kB	7.35 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.3 kB	58.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	toshi1127/next.js feature/fix-with-firebase-authentication-example	Change
677f882d2ed8..dule.js gzip	7.03 kB	7.03 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-9cda5a7..dule.js gzip	6.33 kB	6.33 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	toshi1127/next.js feature/fix-with-firebase-authentication-example	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	toshi1127/next.js feature/fix-with-firebase-authentication-example	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-41ceea0..6b62.js gzip	1.35 kB	1.35 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.75 kB	7.75 kB	✓

Client Pages Modern

	vercel/next.js canary	toshi1127/next.js feature/fix-with-firebase-authentication-example	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-2d41a89..dule.js gzip	1.31 kB	1.31 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.4 kB	5.4 kB	✓

Client Build Manifests

	vercel/next.js canary	toshi1127/next.js feature/fix-with-firebase-authentication-example	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Serverless bundles

	vercel/next.js canary	toshi1127/next.js feature/fix-with-firebase-authentication-example	Change
_error.js	1.06 MB	1.06 MB	✓
404.html	4.73 kB	4.73 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.06 MB	1.06 MB	✓
link.js	1.11 MB	1.11 MB	✓
routerDirect.js	1.1 MB	1.1 MB	✓
withRouter.js	1.1 MB	1.1 MB	✓
Overall change	5.43 MB	5.43 MB	✓

Commit: 47dec8d

ijjk · 2020-11-01T01:16:21Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	toshi1127/next.js feature/fix-with-firebase-authentication-example	Change
buildDuration	12.8s	13.2s	⚠️ +453ms
nodeModulesSize	90.1 MB	90.1 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	toshi1127/next.js feature/fix-with-firebase-authentication-example	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.389	2.336	-0.05
/ avg req/sec	1046.59	1070.03	+23.44
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.266	1.213	-0.05
/error-in-render avg req/sec	1975.28	2060.58	+85.3

Client Bundles (main, webpack, commons)

	vercel/next.js canary	toshi1127/next.js feature/fix-with-firebase-authentication-example	Change
677f882d2ed8..3aa9.js gzip	11.3 kB	11.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-41cbdbf..2c20.js gzip	7.35 kB	7.35 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.3 kB	58.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	toshi1127/next.js feature/fix-with-firebase-authentication-example	Change
677f882d2ed8..dule.js gzip	7.03 kB	7.03 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-9cda5a7..dule.js gzip	6.33 kB	6.33 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	toshi1127/next.js feature/fix-with-firebase-authentication-example	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	toshi1127/next.js feature/fix-with-firebase-authentication-example	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-41ceea0..6b62.js gzip	1.35 kB	1.35 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.75 kB	7.75 kB	✓

Client Pages Modern

	vercel/next.js canary	toshi1127/next.js feature/fix-with-firebase-authentication-example	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-2d41a89..dule.js gzip	1.31 kB	1.31 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.4 kB	5.4 kB	✓

Client Build Manifests

	vercel/next.js canary	toshi1127/next.js feature/fix-with-firebase-authentication-example	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Rendered Page Sizes

	vercel/next.js canary	toshi1127/next.js feature/fix-with-firebase-authentication-example	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	997 B	997 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode

General

	vercel/next.js canary	toshi1127/next.js feature/fix-with-firebase-authentication-example	Change
buildDuration	14.7s	14.8s	⚠️ +24ms
nodeModulesSize	90.1 MB	90.1 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	toshi1127/next.js feature/fix-with-firebase-authentication-example	Change
677f882d2ed8..3aa9.js gzip	11.3 kB	11.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-41cbdbf..2c20.js gzip	7.35 kB	7.35 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.3 kB	58.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	toshi1127/next.js feature/fix-with-firebase-authentication-example	Change
677f882d2ed8..dule.js gzip	7.03 kB	7.03 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-9cda5a7..dule.js gzip	6.33 kB	6.33 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	toshi1127/next.js feature/fix-with-firebase-authentication-example	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	toshi1127/next.js feature/fix-with-firebase-authentication-example	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-41ceea0..6b62.js gzip	1.35 kB	1.35 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.75 kB	7.75 kB	✓

Client Pages Modern

	vercel/next.js canary	toshi1127/next.js feature/fix-with-firebase-authentication-example	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-2d41a89..dule.js gzip	1.31 kB	1.31 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.4 kB	5.4 kB	✓

Client Build Manifests

	vercel/next.js canary	toshi1127/next.js feature/fix-with-firebase-authentication-example	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Serverless bundles

	vercel/next.js canary	toshi1127/next.js feature/fix-with-firebase-authentication-example	Change
_error.js	1.06 MB	1.06 MB	✓
404.html	4.73 kB	4.73 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.06 MB	1.06 MB	✓
link.js	1.11 MB	1.11 MB	✓
routerDirect.js	1.1 MB	1.1 MB	✓
withRouter.js	1.1 MB	1.1 MB	✓
Overall change	5.43 MB	5.43 MB	✓

Commit: 2c75356

lfades

@toshi1127 Hi there 👋 and thank you for the PR! Looks much better now! I haven't tested it but it looks good to me 👏 .

@SylvainGarrigues feel free to test this out!

…xample

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

remjx · 2020-11-19T08:53:13Z

This change broke signInFlow: 'redirect' when using that option. This example only uses signInFlow: 'popup'. Before this change, both methods worked. I am using redirect because I found popup does not work consistently on mobile browsers.

CodenameCookie · 2021-01-11T13:59:34Z

This change broke signInFlow: 'redirect' when using that option. This example only uses signInFlow: 'popup'. Before this change, both methods worked. I am using redirect because I found popup does not work consistently on mobile browsers.

Isn't this method broken then? The solution should sure work on both desktop and mobile.

remjx · 2021-01-11T18:24:12Z

@CodenameCookie as far as i know, yes it's broken. i've been meaning to open up an issue for it but just haven't gotten around to it. i'm still using the old method.

fix: Using getIdToken to get a token

47dec8d

toshi1127 requested review from chibicode, ijjk, lfades, Timer and timneutkens as code owners November 1, 2020 01:05

ijjk added the examples Issue/PR related to examples label Nov 1, 2020

Merge branch 'canary' into feature/fix-with-firebase-authentication-e…

2c75356

…xample

lfades approved these changes Nov 4, 2020

View reviewed changes

Merge branch 'canary' into feature/fix-with-firebase-authentication-e…

f79e8b9

…xample

lfades merged commit 5ecdcab into vercel:canary Nov 4, 2020

styfle pushed a commit that referenced this pull request Nov 4, 2020

fix: Using getIdToken to get a token (#18599)

1e834a9

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

jamesgeorge007 pushed a commit to jamesgeorge007/next.js that referenced this pull request Nov 5, 2020

fix: Using getIdToken to get a token (vercel#18599)

a8e37f2

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

pkail mentioned this pull request Nov 16, 2020

Missing component crashes computer #19210

Closed

This was referenced Nov 19, 2020

Fix firebase auth: use getIdToken instead of undocumented variables on user object remjx/coindrop#60

Closed

The getIdToken method used in next.js example only works when signInFlow: "popup" remjx/coindrop#67

Closed

vercel locked as resolved and limited conversation to collaborators Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: issue #18256 - examples/with-firebase-authentication: fix to use getIdToken to get the token #18599

fix: issue #18256 - examples/with-firebase-authentication: fix to use getIdToken to get the token #18599

toshi1127 commented Nov 1, 2020

ijjk commented Nov 1, 2020

ijjk commented Nov 1, 2020

lfades left a comment

remjx commented Nov 19, 2020

CodenameCookie commented Jan 11, 2021

remjx commented Jan 11, 2021

fix: issue #18256 - examples/with-firebase-authentication: fix to use getIdToken to get the token #18599

fix: issue #18256 - examples/with-firebase-authentication: fix to use getIdToken to get the token #18599

Conversation

toshi1127 commented Nov 1, 2020

Description

ijjk commented Nov 1, 2020

Stats from current PR

ijjk commented Nov 1, 2020

Stats from current PR

lfades left a comment

Choose a reason for hiding this comment

remjx commented Nov 19, 2020

CodenameCookie commented Jan 11, 2021

remjx commented Jan 11, 2021