Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct import comment in interfaces #20052

Merged
merged 3 commits into from Dec 28, 2020
Merged

Correct import comment in interfaces #20052

merged 3 commits into from Dec 28, 2020

Conversation

donavon
Copy link
Contributor

@donavon donavon commented Dec 10, 2020

No description provided.

@ijjk ijjk added the examples Issue/PR related to examples label Dec 10, 2020
@vercel vercel bot temporarily deployed to Preview December 10, 2020 11:03 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 10, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary donavon/next.js patch-1 Change
buildDuration 8.4s 8.4s -88ms
nodeModulesSize 82.5 MB 82.5 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary donavon/next.js patch-1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.063 2.085 ⚠️ +0.02
/ avg req/sec 1211.93 1198.88 ⚠️ -13.05
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.1 1.106 ⚠️ +0.01
/error-in-render avg req/sec 2273.74 2260.48 ⚠️ -13.26
Client Bundles (main, webpack, commons)
vercel/next.js canary donavon/next.js patch-1 Change
677f882d2ed8..34b9.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-899eb31..d9d9.js gzip 6.56 kB 6.56 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary donavon/next.js patch-1 Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary donavon/next.js patch-1 Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-01375..90b6.js gzip 3.69 kB 3.69 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-db223d9..dbd7.js gzip 1.61 kB 1.61 kB ✓
routerDirect..fd29.js gzip 303 B 303 B ✓
withRouter-b..76ae.js gzip 302 B 302 B ✓
Overall change 8.31 kB 8.31 kB ✓
Client Build Manifests
vercel/next.js canary donavon/next.js patch-1 Change
_buildManifest.js gzip 322 B 322 B ✓
Overall change 322 B 322 B ✓
Rendered Page Sizes
vercel/next.js canary donavon/next.js patch-1 Change
index.html gzip 614 B 614 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary donavon/next.js patch-1 Change
buildDuration 10s 10.2s ⚠️ +255ms
nodeModulesSize 82.5 MB 82.5 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary donavon/next.js patch-1 Change
677f882d2ed8..34b9.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-899eb31..d9d9.js gzip 6.56 kB 6.56 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary donavon/next.js patch-1 Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary donavon/next.js patch-1 Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-01375..90b6.js gzip 3.69 kB 3.69 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-db223d9..dbd7.js gzip 1.61 kB 1.61 kB ✓
routerDirect..fd29.js gzip 303 B 303 B ✓
withRouter-b..76ae.js gzip 302 B 302 B ✓
Overall change 8.31 kB 8.31 kB ✓
Client Build Manifests
vercel/next.js canary donavon/next.js patch-1 Change
_buildManifest.js gzip 322 B 322 B ✓
Overall change 322 B 322 B ✓
Serverless bundles
vercel/next.js canary donavon/next.js patch-1 Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.16 MB 5.16 MB ✓
Commit: 72ef7e0

lfades
lfades previously approved these changes Dec 10, 2020
View reviewed changes
Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thank you!

@lfades lfades changed the base branch from master to canary December 10, 2020 21:26
@lfades lfades dismissed their stale review December 10, 2020 21:26

The base branch was changed.

lfades
lfades approved these changes Dec 10, 2020
View reviewed changes
Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving again after changing the branch to canary. Keep in mind that canary is our main branch 🙏

@vercel vercel bot temporarily deployed to Preview December 10, 2020 21:27 Inactive
@vercel vercel bot temporarily deployed to Preview December 10, 2020 21:30 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 10, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary donavon/next.js patch-1 Change
buildDuration 10.4s 10.8s ⚠️ +394ms
nodeModulesSize 82.5 MB 82.5 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary donavon/next.js patch-1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.789 2.538 -0.25
/ avg req/sec 896.39 985.07 +88.68
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.618 1.601 -0.02
/error-in-render avg req/sec 1544.98 1561.5 +16.52
Client Bundles (main, webpack, commons)
vercel/next.js canary donavon/next.js patch-1 Change
677f882d2ed8..34b9.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-3e8cb31..cddc.js gzip 6.56 kB 6.56 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary donavon/next.js patch-1 Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary donavon/next.js patch-1 Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-01375..90b6.js gzip 3.69 kB 3.69 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-db223d9..dbd7.js gzip 1.61 kB 1.61 kB ✓
routerDirect..fd29.js gzip 303 B 303 B ✓
withRouter-b..76ae.js gzip 302 B 302 B ✓
Overall change 8.31 kB 8.31 kB ✓
Client Build Manifests
vercel/next.js canary donavon/next.js patch-1 Change
_buildManifest.js gzip 322 B 322 B ✓
Overall change 322 B 322 B ✓
Rendered Page Sizes
vercel/next.js canary donavon/next.js patch-1 Change
index.html gzip 614 B 614 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary donavon/next.js patch-1 Change
buildDuration 12.9s 12.8s -74ms
nodeModulesSize 82.5 MB 82.5 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary donavon/next.js patch-1 Change
677f882d2ed8..34b9.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-3e8cb31..cddc.js gzip 6.56 kB 6.56 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary donavon/next.js patch-1 Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary donavon/next.js patch-1 Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-01375..90b6.js gzip 3.69 kB 3.69 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-db223d9..dbd7.js gzip 1.61 kB 1.61 kB ✓
routerDirect..fd29.js gzip 303 B 303 B ✓
withRouter-b..76ae.js gzip 302 B 302 B ✓
Overall change 8.31 kB 8.31 kB ✓
Client Build Manifests
vercel/next.js canary donavon/next.js patch-1 Change
_buildManifest.js gzip 322 B 322 B ✓
Overall change 322 B 322 B ✓
Serverless bundles
vercel/next.js canary donavon/next.js patch-1 Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.16 MB 5.16 MB ✓
Commit: 14528b9

Timer
Timer approved these changes Dec 28, 2020
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @donavon!

@Timer Timer merged commit 47433b6 into vercel:canary Dec 28, 2020
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@lfades lfades lfades approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@donavon @ijjk @Timer @lfades