Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: progressive-web-app example #20288

Merged
merged 3 commits into from Dec 18, 2020
Merged

Fix: progressive-web-app example #20288

merged 3 commits into from Dec 18, 2020

Conversation

darshkpatel
Copy link
Contributor

@darshkpatel darshkpatel commented Dec 18, 2020 •
edited

Fixes: #20289
I noticed the following errors about missing icon files while working on the progressive-web-app example
Screenshot 2020-12-18 at 9 16 25 AM

I've added the missing icon files and updated the path :)

@ijjk ijjk added the examples Issue/PR related to examples label Dec 18, 2020
@vercel vercel bot temporarily deployed to Preview December 18, 2020 03:57 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 18, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary darshkpatel/next.js pwa-example-fix Change
buildDuration 12.3s 12.3s ⚠️ +68ms
nodeModulesSize 82.4 MB 82.4 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary darshkpatel/next.js pwa-example-fix Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.945 2.958 ⚠️ +0.01
/ avg req/sec 849.01 845.17 ⚠️ -3.84
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.822 1.822 ✓
/error-in-render avg req/sec 1372.02 1372.24 +0.22
Client Bundles (main, webpack, commons)
vercel/next.js canary darshkpatel/next.js pwa-example-fix Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-1f21dcf..0011.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary darshkpatel/next.js pwa-example-fix Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary darshkpatel/next.js pwa-example-fix Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-2cf0e..a0a0.js gzip 3.69 kB 3.69 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.31 kB 8.31 kB ✓
Client Build Manifests
vercel/next.js canary darshkpatel/next.js pwa-example-fix Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary darshkpatel/next.js pwa-example-fix Change
index.html gzip 612 B 612 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary darshkpatel/next.js pwa-example-fix Change
buildDuration 14.5s 14.8s ⚠️ +279ms
nodeModulesSize 82.4 MB 82.4 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary darshkpatel/next.js pwa-example-fix Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-1f21dcf..0011.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary darshkpatel/next.js pwa-example-fix Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary darshkpatel/next.js pwa-example-fix Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-2cf0e..a0a0.js gzip 3.69 kB 3.69 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.31 kB 8.31 kB ✓
Client Build Manifests
vercel/next.js canary darshkpatel/next.js pwa-example-fix Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary darshkpatel/next.js pwa-example-fix Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.16 MB 5.16 MB ✓
Commit: e88b47d

@vercel vercel bot temporarily deployed to Preview December 18, 2020 09:53 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 18, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary darshkpatel/next.js pwa-example-fix Change
buildDuration 8.4s 8.6s ⚠️ +211ms
nodeModulesSize 82.4 MB 82.4 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary darshkpatel/next.js pwa-example-fix Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.219 2.135 -0.08
/ avg req/sec 1126.4 1170.86 +44.46
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.258 1.279 ⚠️ +0.02
/error-in-render avg req/sec 1987.01 1954.2 ⚠️ -32.81
Client Bundles (main, webpack, commons)
vercel/next.js canary darshkpatel/next.js pwa-example-fix Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-1f21dcf..0011.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary darshkpatel/next.js pwa-example-fix Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary darshkpatel/next.js pwa-example-fix Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-2cf0e..a0a0.js gzip 3.69 kB 3.69 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.31 kB 8.31 kB ✓
Client Build Manifests
vercel/next.js canary darshkpatel/next.js pwa-example-fix Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary darshkpatel/next.js pwa-example-fix Change
index.html gzip 612 B 612 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary darshkpatel/next.js pwa-example-fix Change
buildDuration 10.1s 9.9s -131ms
nodeModulesSize 82.4 MB 82.4 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary darshkpatel/next.js pwa-example-fix Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-1f21dcf..0011.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary darshkpatel/next.js pwa-example-fix Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary darshkpatel/next.js pwa-example-fix Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-2cf0e..a0a0.js gzip 3.69 kB 3.69 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.31 kB 8.31 kB ✓
Client Build Manifests
vercel/next.js canary darshkpatel/next.js pwa-example-fix Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary darshkpatel/next.js pwa-example-fix Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.16 MB 5.16 MB ✓
Commit: 4150e36

@kodiakhq kodiakhq bot merged commit bad9a8c into vercel:canary Dec 18, 2020
This was referenced May 26, 2021
Open
Open
Open
Open
Open
Open
Open
Open
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Example: progressive-web-app has 404's in the console
3 participants
@darshkpatel @ijjk @timneutkens