Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sharp optional dependency to support NPM 7 #20432

Merged
merged 4 commits into from
Dec 29, 2020
Merged

Update sharp optional dependency to support NPM 7 #20432

merged 4 commits into from
Dec 29, 2020

Conversation

jorrit
Copy link
Contributor

@jorrit jorrit commented Dec 23, 2020

Sharp 0.26.3 updates prebuild-install to ^6.0.0 which fixes an incompatibility with NPM 7.

See lovell/sharp#2419 and prebuild/prebuild-install#128

@vercel vercel bot temporarily deployed to Preview December 23, 2020 19:30 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 23, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary jorrit/next.js patch-1 Change
buildDuration 10.2s 10.4s ⚠️ +166ms
nodeModulesSize 82.6 MB 82.7 MB ⚠️ +33.3 kB
Page Load Tests Overall increase ✓
vercel/next.js canary jorrit/next.js patch-1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.152 2.151 0
/ avg req/sec 1161.68 1162.15 +0.47
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.557 1.418 -0.14
/error-in-render avg req/sec 1605.64 1762.78 +157.14
Client Bundles (main, webpack, commons)
vercel/next.js canary jorrit/next.js patch-1 Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e0d2962..b163.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary jorrit/next.js patch-1 Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary jorrit/next.js patch-1 Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-85785..a9f3.js gzip 3.44 kB 3.44 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.05 kB 8.05 kB ✓
Client Build Manifests
vercel/next.js canary jorrit/next.js patch-1 Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary jorrit/next.js patch-1 Change
index.html gzip 612 B 612 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary jorrit/next.js patch-1 Change
buildDuration 12.2s 12.2s ⚠️ +4ms
nodeModulesSize 82.6 MB 82.7 MB ⚠️ +33.3 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary jorrit/next.js patch-1 Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e0d2962..b163.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary jorrit/next.js patch-1 Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary jorrit/next.js patch-1 Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-85785..a9f3.js gzip 3.44 kB 3.44 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.05 kB 8.05 kB ✓
Client Build Manifests
vercel/next.js canary jorrit/next.js patch-1 Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary jorrit/next.js patch-1 Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.16 MB 5.16 MB ✓
Commit: 20080ec

@vercel vercel bot temporarily deployed to Preview December 24, 2020 12:00 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 24, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary jorrit/next.js patch-1 Change
buildDuration 10.3s 9.9s -450ms
nodeModulesSize 82.6 MB 82.7 MB ⚠️ +33.3 kB
Page Load Tests Overall increase ✓
vercel/next.js canary jorrit/next.js patch-1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.033 1.904 -0.13
/ avg req/sec 1229.84 1312.84 +83
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.208 1.22 ⚠️ +0.01
/error-in-render avg req/sec 2068.83 2049.63 ⚠️ -19.2
Client Bundles (main, webpack, commons)
vercel/next.js canary jorrit/next.js patch-1 Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e0d2962..b163.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary jorrit/next.js patch-1 Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary jorrit/next.js patch-1 Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-85785..a9f3.js gzip 3.44 kB 3.44 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.05 kB 8.05 kB ✓
Client Build Manifests
vercel/next.js canary jorrit/next.js patch-1 Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary jorrit/next.js patch-1 Change
index.html gzip 612 B 612 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary jorrit/next.js patch-1 Change
buildDuration 12s 12.2s ⚠️ +145ms
nodeModulesSize 82.6 MB 82.7 MB ⚠️ +33.3 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary jorrit/next.js patch-1 Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e0d2962..b163.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary jorrit/next.js patch-1 Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary jorrit/next.js patch-1 Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-85785..a9f3.js gzip 3.44 kB 3.44 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.05 kB 8.05 kB ✓
Client Build Manifests
vercel/next.js canary jorrit/next.js patch-1 Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary jorrit/next.js patch-1 Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.16 MB 5.16 MB ✓
Commit: f7df47d

@jorrit jorrit mentioned this pull request Dec 24, 2020
Closed
@vercel vercel bot temporarily deployed to Preview December 29, 2020 10:20 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 29, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary jorrit/next.js patch-1 Change
buildDuration 8.9s 8.8s -155ms
nodeModulesSize 82.7 MB 82.7 MB ⚠️ +33.3 kB
Page Load Tests Overall increase ✓
vercel/next.js canary jorrit/next.js patch-1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.827 1.778 -0.05
/ avg req/sec 1368.68 1406.24 +37.56
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.165 1.132 -0.03
/error-in-render avg req/sec 2145.28 2207.52 +62.24
Client Bundles (main, webpack, commons)
vercel/next.js canary jorrit/next.js patch-1 Change
677f882d2ed8..68d0.js gzip 12.7 kB 12.7 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-8d1eb02..37d1.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary jorrit/next.js patch-1 Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary jorrit/next.js patch-1 Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-85785..a9f3.js gzip 3.44 kB 3.44 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.05 kB 8.05 kB ✓
Client Build Manifests
vercel/next.js canary jorrit/next.js patch-1 Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary jorrit/next.js patch-1 Change
index.html gzip 614 B 614 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary jorrit/next.js patch-1 Change
buildDuration 10.7s 10.2s -436ms
nodeModulesSize 82.7 MB 82.7 MB ⚠️ +33.3 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary jorrit/next.js patch-1 Change
677f882d2ed8..68d0.js gzip 12.7 kB 12.7 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-8d1eb02..37d1.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary jorrit/next.js patch-1 Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary jorrit/next.js patch-1 Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-85785..a9f3.js gzip 3.44 kB 3.44 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.05 kB 8.05 kB ✓
Client Build Manifests
vercel/next.js canary jorrit/next.js patch-1 Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary jorrit/next.js patch-1 Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.16 MB 5.16 MB ✓
Commit: 1b2e8cb

Timer
Timer approved these changes Dec 29, 2020
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vercel vercel bot temporarily deployed to Preview December 29, 2020 17:34 Inactive
@vercel vercel bot temporarily deployed to Preview December 29, 2020 17:35 Inactive
@vercel vercel bot temporarily deployed to Preview December 29, 2020 17:44 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 29, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary jorrit/next.js patch-1 Change
buildDuration 10.2s 10.7s ⚠️ +509ms
nodeModulesSize 82.7 MB 82.7 MB ⚠️ +33.3 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary jorrit/next.js patch-1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.111 2.178 ⚠️ +0.07
/ avg req/sec 1184.03 1147.65 ⚠️ -36.38
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.448 1.593 ⚠️ +0.15
/error-in-render avg req/sec 1726.95 1569.56 ⚠️ -157.39
Client Bundles (main, webpack, commons)
vercel/next.js canary jorrit/next.js patch-1 Change
677f882d2ed8..68d0.js gzip 12.7 kB 12.7 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-8d1eb02..37d1.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary jorrit/next.js patch-1 Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary jorrit/next.js patch-1 Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-85785..a9f3.js gzip 3.44 kB 3.44 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.05 kB 8.05 kB ✓
Client Build Manifests
vercel/next.js canary jorrit/next.js patch-1 Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary jorrit/next.js patch-1 Change
index.html gzip 614 B 614 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary jorrit/next.js patch-1 Change
buildDuration 12.2s 12.1s -130ms
nodeModulesSize 82.7 MB 82.7 MB ⚠️ +33.3 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary jorrit/next.js patch-1 Change
677f882d2ed8..68d0.js gzip 12.7 kB 12.7 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-8d1eb02..37d1.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary jorrit/next.js patch-1 Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary jorrit/next.js patch-1 Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-85785..a9f3.js gzip 3.44 kB 3.44 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.05 kB 8.05 kB ✓
Client Build Manifests
vercel/next.js canary jorrit/next.js patch-1 Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary jorrit/next.js patch-1 Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.16 MB 5.16 MB ✓
Commit: fcaf717

@kodiakhq kodiakhq bot merged commit a9c7c9a into vercel:canary Dec 29, 2020
@hdwatts hdwatts mentioned this pull request Jan 1, 2021
Open
TrySound
TrySound reviewed Jan 7, 2021
View reviewed changes
yarn.lock
dependencies:
color "^3.1.2"
array-flatten "^3.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, god. Every new release - more and more dependencies 👎

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, that is regrettable. Luckily sharp is optional, although that is broken atm.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really optional. It's always installed if environment is supported. It was decided to make it mandatory to easily switch to alternative. Though there is not any. Perhaps optimisation should be left on user initially without introducing bloated dep.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to omit it when using yarn install --ignore-optional. Or am I missing something? In any case, optional dependencies is not the most commonly used feature of yarn/npm to say the least.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, yeah. Though flags are not really handy and some other optionalDependencies can be necessary.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TrySound TrySound TrySound left review comments

@Timer Timer Timer approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jorrit @ijjk @Timer @TrySound