Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos found on examples docs #20516

Merged
merged 3 commits into from
Dec 27, 2020
Merged

Fix typos found on examples docs #20516

merged 3 commits into from
Dec 27, 2020

Conversation

LauraBeatris
Copy link
Contributor

@LauraBeatris LauraBeatris commented Dec 27, 2020 •
edited
Loading

This PR fixes some typos found on examples docs

@ijjk ijjk added the examples Issue/PR related to examples label Dec 27, 2020
@vercel vercel bot temporarily deployed to Preview December 27, 2020 15:35 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 27, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary LauraBeatris/next.js fix-examples-docs-typos Change
buildDuration 10.4s 10.1s -289ms
nodeModulesSize 82.6 MB 82.6 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary LauraBeatris/next.js fix-examples-docs-typos Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.044 2.013 -0.03
/ avg req/sec 1223.27 1242.16 +18.89
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.26 1.263 0
/error-in-render avg req/sec 1984.85 1978.99 ⚠️ -5.86
Client Bundles (main, webpack, commons)
vercel/next.js canary LauraBeatris/next.js fix-examples-docs-typos Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e0d2962..b163.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary LauraBeatris/next.js fix-examples-docs-typos Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary LauraBeatris/next.js fix-examples-docs-typos Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-85785..a9f3.js gzip 3.44 kB 3.44 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.05 kB 8.05 kB ✓
Client Build Manifests
vercel/next.js canary LauraBeatris/next.js fix-examples-docs-typos Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary LauraBeatris/next.js fix-examples-docs-typos Change
index.html gzip 612 B 612 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary LauraBeatris/next.js fix-examples-docs-typos Change
buildDuration 12.2s 12.2s ⚠️ +68ms
nodeModulesSize 82.6 MB 82.6 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary LauraBeatris/next.js fix-examples-docs-typos Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e0d2962..b163.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary LauraBeatris/next.js fix-examples-docs-typos Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary LauraBeatris/next.js fix-examples-docs-typos Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-85785..a9f3.js gzip 3.44 kB 3.44 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.05 kB 8.05 kB ✓
Client Build Manifests
vercel/next.js canary LauraBeatris/next.js fix-examples-docs-typos Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary LauraBeatris/next.js fix-examples-docs-typos Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.16 MB 5.16 MB ✓
Commit: 8c4a953

@vercel vercel bot temporarily deployed to Preview December 27, 2020 16:39 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 27, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary LauraBeatris/next.js fix-examples-docs-typos Change
buildDuration 10.4s 10.5s ⚠️ +83ms
nodeModulesSize 82.6 MB 82.6 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary LauraBeatris/next.js fix-examples-docs-typos Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.126 2.046 -0.08
/ avg req/sec 1175.65 1221.75 +46.1
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.306 1.297 -0.01
/error-in-render avg req/sec 1914.62 1927.65 +13.03
Client Bundles (main, webpack, commons)
vercel/next.js canary LauraBeatris/next.js fix-examples-docs-typos Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e0d2962..b163.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary LauraBeatris/next.js fix-examples-docs-typos Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary LauraBeatris/next.js fix-examples-docs-typos Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-85785..a9f3.js gzip 3.44 kB 3.44 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.05 kB 8.05 kB ✓
Client Build Manifests
vercel/next.js canary LauraBeatris/next.js fix-examples-docs-typos Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary LauraBeatris/next.js fix-examples-docs-typos Change
index.html gzip 612 B 612 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary LauraBeatris/next.js fix-examples-docs-typos Change
buildDuration 12.4s 12.5s ⚠️ +71ms
nodeModulesSize 82.6 MB 82.6 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary LauraBeatris/next.js fix-examples-docs-typos Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e0d2962..b163.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary LauraBeatris/next.js fix-examples-docs-typos Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary LauraBeatris/next.js fix-examples-docs-typos Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-85785..a9f3.js gzip 3.44 kB 3.44 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.05 kB 8.05 kB ✓
Client Build Manifests
vercel/next.js canary LauraBeatris/next.js fix-examples-docs-typos Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary LauraBeatris/next.js fix-examples-docs-typos Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.16 MB 5.16 MB ✓
Commit: f617d7b

ijjk
ijjk approved these changes Dec 27, 2020
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, thanks for the PR!

@vercel vercel bot temporarily deployed to Preview December 27, 2020 16:54 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 27, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary LauraBeatris/next.js fix-examples-docs-typos Change
buildDuration 11.7s 11.8s ⚠️ +94ms
nodeModulesSize 82.6 MB 82.6 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary LauraBeatris/next.js fix-examples-docs-typos Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.276 2.311 ⚠️ +0.04
/ avg req/sec 1098.2 1081.56 ⚠️ -16.64
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.515 1.487 -0.03
/error-in-render avg req/sec 1649.9 1681.02 +31.12
Client Bundles (main, webpack, commons)
vercel/next.js canary LauraBeatris/next.js fix-examples-docs-typos Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e0d2962..b163.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary LauraBeatris/next.js fix-examples-docs-typos Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary LauraBeatris/next.js fix-examples-docs-typos Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-85785..a9f3.js gzip 3.44 kB 3.44 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.05 kB 8.05 kB ✓
Client Build Manifests
vercel/next.js canary LauraBeatris/next.js fix-examples-docs-typos Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary LauraBeatris/next.js fix-examples-docs-typos Change
index.html gzip 612 B 612 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary LauraBeatris/next.js fix-examples-docs-typos Change
buildDuration 14.1s 13.8s -313ms
nodeModulesSize 82.6 MB 82.6 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary LauraBeatris/next.js fix-examples-docs-typos Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e0d2962..b163.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary LauraBeatris/next.js fix-examples-docs-typos Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary LauraBeatris/next.js fix-examples-docs-typos Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-85785..a9f3.js gzip 3.44 kB 3.44 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.05 kB 8.05 kB ✓
Client Build Manifests
vercel/next.js canary LauraBeatris/next.js fix-examples-docs-typos Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary LauraBeatris/next.js fix-examples-docs-typos Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.16 MB 5.16 MB ✓
Commit: 03d9dfc

@kodiakhq kodiakhq bot merged commit d96de6e into vercel:canary Dec 27, 2020
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@awareness481 awareness481 awareness481 left review comments

@ijjk ijjk ijjk approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LauraBeatris @ijjk @awareness481