Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Tailwind CSS 2.0 in blog-starter-typescript example #20664

Merged
merged 2 commits into from Jan 1, 2021
Merged

Update to Tailwind CSS 2.0 in blog-starter-typescript example #20664

merged 2 commits into from Jan 1, 2021

Conversation

JstnEdr
Copy link
Contributor

@JstnEdr JstnEdr commented Jan 1, 2021

This updates the blog-starter-typescript example to use the latest version of Tailwind CSS (2.0.2)

Notes:
Followed the upgrade guide here: https://tailwindcss.com/docs/upgrading-to-v2
And Next / PostCSS guide here: https://nextjs.org/docs/advanced-features/customizing-postcss-config

@ijjk ijjk added the examples Issue/PR related to examples label Jan 1, 2021
@ijjk
Copy link
Member

ijjk commented Jan 1, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary JstnEdr/next.js blog-typescript-tailwind-update Change
buildDuration 8.9s 8.8s -65ms
nodeModulesSize 83 MB 83 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary JstnEdr/next.js blog-typescript-tailwind-update Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.743 1.718 -0.03
/ avg req/sec 1434.1 1455.02 +20.92
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.109 1.089 -0.02
/error-in-render avg req/sec 2253.7 2296.57 +42.87
Client Bundles (main, webpack, commons)
vercel/next.js canary JstnEdr/next.js blog-typescript-tailwind-update Change
677f882d2ed8..2428.js gzip 12.9 kB 12.9 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-212f85f..f23b.js gzip 6.59 kB 6.59 kB ✓
webpack-7193..1446.js gzip 751 B 751 B ✓
Overall change 59.2 kB 59.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary JstnEdr/next.js blog-typescript-tailwind-update Change
polyfills-67..b7d1.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary JstnEdr/next.js blog-typescript-tailwind-update Change
_app-6220e08..9a40.js gzip 1.28 kB 1.28 kB ✓
_error-4b0b5..2c91.js gzip 3.44 kB 3.44 kB ✓
hooks-5f309a..7282.js gzip 887 B 887 B ✓
index-57f580..c562.js gzip 227 B 227 B ✓
link-b862cd7..dba8.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bd82.js gzip 303 B 303 B ✓
withRouter-2..e384.js gzip 302 B 302 B ✓
Overall change 8.08 kB 8.08 kB ✓
Client Build Manifests
vercel/next.js canary JstnEdr/next.js blog-typescript-tailwind-update Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary JstnEdr/next.js blog-typescript-tailwind-update Change
index.html gzip 617 B 617 B ✓
link.html gzip 622 B 622 B ✓
withRouter.html gzip 610 B 610 B ✓
Overall change 1.85 kB 1.85 kB ✓
Serverless Mode
General
vercel/next.js canary JstnEdr/next.js blog-typescript-tailwind-update Change
buildDuration 10.6s 10.5s -154ms
nodeModulesSize 83 MB 83 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary JstnEdr/next.js blog-typescript-tailwind-update Change
677f882d2ed8..2428.js gzip 12.9 kB 12.9 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-212f85f..f23b.js gzip 6.59 kB 6.59 kB ✓
webpack-7193..1446.js gzip 751 B 751 B ✓
Overall change 59.2 kB 59.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary JstnEdr/next.js blog-typescript-tailwind-update Change
polyfills-67..b7d1.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary JstnEdr/next.js blog-typescript-tailwind-update Change
_app-6220e08..9a40.js gzip 1.28 kB 1.28 kB ✓
_error-4b0b5..2c91.js gzip 3.44 kB 3.44 kB ✓
hooks-5f309a..7282.js gzip 887 B 887 B ✓
index-57f580..c562.js gzip 227 B 227 B ✓
link-b862cd7..dba8.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bd82.js gzip 303 B 303 B ✓
withRouter-2..e384.js gzip 302 B 302 B ✓
Overall change 8.08 kB 8.08 kB ✓
Client Build Manifests
vercel/next.js canary JstnEdr/next.js blog-typescript-tailwind-update Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary JstnEdr/next.js blog-typescript-tailwind-update Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.17 MB 5.17 MB ✓
Commit: 0e4fdff

lfades
lfades approved these changes Jan 1, 2021
View reviewed changes
Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@ijjk
Copy link
Member

ijjk commented Jan 1, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary JstnEdr/next.js blog-typescript-tailwind-update Change
buildDuration 10.4s 11s ⚠️ +614ms
nodeModulesSize 83 MB 83 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary JstnEdr/next.js blog-typescript-tailwind-update Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.085 2.105 ⚠️ +0.02
/ avg req/sec 1198.85 1187.4 ⚠️ -11.45
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.273 1.29 ⚠️ +0.02
/error-in-render avg req/sec 1963.74 1938.7 ⚠️ -25.04
Client Bundles (main, webpack, commons)
vercel/next.js canary JstnEdr/next.js blog-typescript-tailwind-update Change
677f882d2ed8..dbe2.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-212f85f..f23b.js gzip 6.59 kB 6.59 kB ✓
webpack-7193..1446.js gzip 751 B 751 B ✓
Overall change 59.3 kB 59.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary JstnEdr/next.js blog-typescript-tailwind-update Change
polyfills-67..b7d1.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary JstnEdr/next.js blog-typescript-tailwind-update Change
_app-6220e08..9a40.js gzip 1.28 kB 1.28 kB ✓
_error-4b0b5..2c91.js gzip 3.44 kB 3.44 kB ✓
hooks-5f309a..7282.js gzip 887 B 887 B ✓
index-57f580..c562.js gzip 227 B 227 B ✓
link-b862cd7..dba8.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bd82.js gzip 303 B 303 B ✓
withRouter-2..e384.js gzip 302 B 302 B ✓
Overall change 8.08 kB 8.08 kB ✓
Client Build Manifests
vercel/next.js canary JstnEdr/next.js blog-typescript-tailwind-update Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary JstnEdr/next.js blog-typescript-tailwind-update Change
index.html gzip 616 B 616 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 610 B 610 B ✓
Overall change 1.85 kB 1.85 kB ✓
Serverless Mode
General
vercel/next.js canary JstnEdr/next.js blog-typescript-tailwind-update Change
buildDuration 13.2s 12.7s -452ms
nodeModulesSize 83 MB 83 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary JstnEdr/next.js blog-typescript-tailwind-update Change
677f882d2ed8..dbe2.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-212f85f..f23b.js gzip 6.59 kB 6.59 kB ✓
webpack-7193..1446.js gzip 751 B 751 B ✓
Overall change 59.3 kB 59.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary JstnEdr/next.js blog-typescript-tailwind-update Change
polyfills-67..b7d1.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary JstnEdr/next.js blog-typescript-tailwind-update Change
_app-6220e08..9a40.js gzip 1.28 kB 1.28 kB ✓
_error-4b0b5..2c91.js gzip 3.44 kB 3.44 kB ✓
hooks-5f309a..7282.js gzip 887 B 887 B ✓
index-57f580..c562.js gzip 227 B 227 B ✓
link-b862cd7..dba8.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bd82.js gzip 303 B 303 B ✓
withRouter-2..e384.js gzip 302 B 302 B ✓
Overall change 8.08 kB 8.08 kB ✓
Client Build Manifests
vercel/next.js canary JstnEdr/next.js blog-typescript-tailwind-update Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary JstnEdr/next.js blog-typescript-tailwind-update Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.17 MB 5.17 MB ✓
Commit: 151235b

@kodiakhq kodiakhq bot merged commit 9ded7aa into vercel:canary Jan 1, 2021
@angristan angristan mentioned this pull request Jan 6, 2021
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lfades lfades lfades approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JstnEdr @ijjk @lfades