Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(client-image): add return types #20686

Merged
merged 3 commits into from
Jan 3, 2021
Merged

chore(client-image): add return types #20686

merged 3 commits into from
Jan 3, 2021

Conversation

tarunama
Copy link
Contributor

@tarunama tarunama commented Jan 2, 2021

No description provided.

@ijjk ijjk added the type: next label Jan 2, 2021
@ijjk
Copy link
Member

ijjk commented Jan 2, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary tarunama/next.js chore/add-return-types Change
buildDuration 10s 8.9s -1s
nodeModulesSize 80.6 MB 80.6 MB ⚠️ +16 B
Page Load Tests Overall increase ✓
vercel/next.js canary tarunama/next.js chore/add-return-types Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.052 1.86 -0.19
/ avg req/sec 1218.14 1344.08 +125.94
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.363 1.362 0
/error-in-render avg req/sec 1834.63 1835.65 +1.02
Client Bundles (main, webpack, commons)
vercel/next.js canary tarunama/next.js chore/add-return-types Change
677f882d2ed8..42af.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-a9a6f0d..a96d.js gzip 6.59 kB 6.59 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.3 kB 59.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary tarunama/next.js chore/add-return-types Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary tarunama/next.js chore/add-return-types Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-cfcb6..fe1c.js gzip 3.44 kB 3.44 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-705099c..c35d.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.08 kB 8.08 kB ✓
Client Build Manifests
vercel/next.js canary tarunama/next.js chore/add-return-types Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary tarunama/next.js chore/add-return-types Change
index.html gzip 615 B 615 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary tarunama/next.js chore/add-return-types Change
buildDuration 11s 10.5s -482ms
nodeModulesSize 80.6 MB 80.6 MB ⚠️ +16 B
Client Bundles (main, webpack, commons)
vercel/next.js canary tarunama/next.js chore/add-return-types Change
677f882d2ed8..42af.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-a9a6f0d..a96d.js gzip 6.59 kB 6.59 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.3 kB 59.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary tarunama/next.js chore/add-return-types Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary tarunama/next.js chore/add-return-types Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-cfcb6..fe1c.js gzip 3.44 kB 3.44 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-705099c..c35d.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.08 kB 8.08 kB ✓
Client Build Manifests
vercel/next.js canary tarunama/next.js chore/add-return-types Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary tarunama/next.js chore/add-return-types Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.17 MB 5.17 MB ✓
Commit: 66eef20

@ijjk
Copy link
Member

ijjk commented Jan 3, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary tarunama/next.js chore/add-return-types Change
buildDuration 10.3s 11s ⚠️ +635ms
nodeModulesSize 80.6 MB 80.6 MB ⚠️ +16 B
Page Load Tests Overall increase ✓
vercel/next.js canary tarunama/next.js chore/add-return-types Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.068 2.122 ⚠️ +0.05
/ avg req/sec 1208.67 1177.91 ⚠️ -30.76
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.378 1.348 -0.03
/error-in-render avg req/sec 1814.88 1854.24 +39.36
Client Bundles (main, webpack, commons)
vercel/next.js canary tarunama/next.js chore/add-return-types Change
677f882d2ed8..42af.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-a9a6f0d..a96d.js gzip 6.59 kB 6.59 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.3 kB 59.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary tarunama/next.js chore/add-return-types Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary tarunama/next.js chore/add-return-types Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-705099c..c35d.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary tarunama/next.js chore/add-return-types Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary tarunama/next.js chore/add-return-types Change
index.html gzip 615 B 615 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary tarunama/next.js chore/add-return-types Change
buildDuration 12.3s 12.5s ⚠️ +246ms
nodeModulesSize 80.6 MB 80.6 MB ⚠️ +16 B
Client Bundles (main, webpack, commons)
vercel/next.js canary tarunama/next.js chore/add-return-types Change
677f882d2ed8..42af.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-a9a6f0d..a96d.js gzip 6.59 kB 6.59 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.3 kB 59.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary tarunama/next.js chore/add-return-types Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary tarunama/next.js chore/add-return-types Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-705099c..c35d.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary tarunama/next.js chore/add-return-types Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary tarunama/next.js chore/add-return-types Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.17 MB 5.17 MB ✓
Commit: f75b35e

@kodiakhq kodiakhq bot merged commit 8795369 into vercel:canary Jan 3, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tarunama @ijjk @timneutkens