Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update error for mis-matching path in getStaticPaths #20767

Merged
merged 3 commits into from
Jan 6, 2021
Merged

Update error for mis-matching path in getStaticPaths #20767

merged 3 commits into from
Jan 6, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jan 5, 2021

This updates the error shown when a path doesn't match the dynamic route in getStaticPaths to not include the locale since this isn't considered when matching against the dynamic route.

@ijjk ijjk added the type: next label Jan 5, 2021
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member Author

ijjk commented Jan 5, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/static-paths-error Change
buildDuration 8.3s 8s -243ms
nodeModulesSize 80.6 MB 80.6 MB ⚠️ +13 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/static-paths-error Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.657 1.665 ⚠️ +0.01
/ avg req/sec 1508.49 1501.47 ⚠️ -7.02
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.064 1.022 -0.04
/error-in-render avg req/sec 2348.57 2445.82 +97.25
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/static-paths-error Change
677f882d2ed8..396f.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-d74fce9..a1a1.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.3 kB 59.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/static-paths-error Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/static-paths-error Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-705099c..c35d.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/static-paths-error Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/static-paths-error Change
index.html gzip 614 B 614 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/static-paths-error Change
buildDuration 9.7s 9.6s -121ms
nodeModulesSize 80.6 MB 80.6 MB ⚠️ +13 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/static-paths-error Change
677f882d2ed8..396f.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-d74fce9..a1a1.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.3 kB 59.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/static-paths-error Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/static-paths-error Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-705099c..c35d.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/static-paths-error Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary ijjk/next.js update/static-paths-error Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.17 MB 5.17 MB ✓
Commit: e3808c9

@ijjk
Copy link
Member Author

ijjk commented Jan 6, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/static-paths-error Change
buildDuration 10.3s 10.1s -219ms
nodeModulesSize 80.8 MB 80.8 MB ⚠️ +13 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/static-paths-error Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.031 2.129 ⚠️ +0.1
/ avg req/sec 1230.69 1174.51 ⚠️ -56.18
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.276 1.316 ⚠️ +0.04
/error-in-render avg req/sec 1958.82 1900.02 ⚠️ -58.8
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/static-paths-error Change
677f882d2ed8..89aa.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-1f258db..b7d8.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/static-paths-error Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/static-paths-error Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-705099c..c35d.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/static-paths-error Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/static-paths-error Change
index.html gzip 613 B 613 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/static-paths-error Change
buildDuration 12.2s 12s -271ms
nodeModulesSize 80.8 MB 80.8 MB ⚠️ +13 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/static-paths-error Change
677f882d2ed8..89aa.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-1f258db..b7d8.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/static-paths-error Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/static-paths-error Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-705099c..c35d.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/static-paths-error Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary ijjk/next.js update/static-paths-error Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.18 MB 5.18 MB ✓
Commit: d0e339f

@kodiakhq kodiakhq bot merged commit 991ad92 into vercel:canary Jan 6, 2021
@Timer Timer deleted the update/static-paths-error branch January 6, 2021 14:53
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ijjk @timneutkens