Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mkdirp #21365

Merged
merged 2 commits into from Jan 26, 2021
Merged

Remove mkdirp #21365

merged 2 commits into from Jan 26, 2021

Conversation

chulkilee
Copy link
Contributor

@chulkilee chulkilee commented Jan 20, 2021

Closes #17042

I removed mkdirp from package.json taskfil.js, and ran yarn && ./check-pre-compiled.sh . Please let me know if anything else is needed!

(Extracted from #20411)

Note that now compiled webpack has mkdirP function

@ijjk
Copy link
Member

ijjk commented Jan 20, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary chulkilee/next.js remove-mkdirp Change
buildDuration 11.3s 11s -228ms
nodeModulesSize 75.3 MB 75.3 MB ⚠️ +897 B
Page Load Tests Overall increase ✓
vercel/next.js canary chulkilee/next.js remove-mkdirp Change
/ failed reqs 0 0
/ total time (seconds) 2.29 2.273 -0.02
/ avg req/sec 1091.8 1099.97 +8.17
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.653 1.575 -0.08
/error-in-render avg req/sec 1512.27 1587.11 +74.84
Client Bundles (main, webpack, commons)
vercel/next.js canary chulkilee/next.js remove-mkdirp Change
677f882d2ed8..43e3.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 6.63 kB 6.63 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary chulkilee/next.js remove-mkdirp Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary chulkilee/next.js remove-mkdirp Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
hooks-c71ae4..70cd.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary chulkilee/next.js remove-mkdirp Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Rendered Page Sizes
vercel/next.js canary chulkilee/next.js remove-mkdirp Change
index.html gzip 616 B 616 B
link.html gzip 622 B 622 B
withRouter.html gzip 608 B 608 B
Overall change 1.85 kB 1.85 kB

Serverless Mode
General Overall increase ⚠️
vercel/next.js canary chulkilee/next.js remove-mkdirp Change
buildDuration 13.2s 13.3s ⚠️ +109ms
nodeModulesSize 75.3 MB 75.3 MB ⚠️ +897 B
Client Bundles (main, webpack, commons)
vercel/next.js canary chulkilee/next.js remove-mkdirp Change
677f882d2ed8..43e3.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 6.63 kB 6.63 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary chulkilee/next.js remove-mkdirp Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary chulkilee/next.js remove-mkdirp Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
hooks-c71ae4..70cd.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary chulkilee/next.js remove-mkdirp Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Serverless bundles
vercel/next.js canary chulkilee/next.js remove-mkdirp Change
_error.js 1 MB 1 MB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 1 MB 1 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.19 MB 5.19 MB

Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary chulkilee/next.js remove-mkdirp Change
buildDuration 13.7s 13.8s ⚠️ +73ms
nodeModulesSize 75.3 MB 75.3 MB ⚠️ +897 B
Page Load Tests Overall increase ✓
vercel/next.js canary chulkilee/next.js remove-mkdirp Change
/ failed reqs 0 0
/ total time (seconds) 2.235 2.233 0
/ avg req/sec 1118.71 1119.36 +0.65
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.554 1.538 -0.02
/error-in-render avg req/sec 1608.71 1625.01 +16.3
Client Bundles (main, webpack, commons)
vercel/next.js canary chulkilee/next.js remove-mkdirp Change
597-3bd7d6bd..868b.js gzip 13 kB 13 kB
framework.HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 6.58 kB 6.58 kB
webpack-HASH.js gzip 954 B 954 B
Overall change 59.8 kB 59.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary chulkilee/next.js remove-mkdirp Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary chulkilee/next.js remove-mkdirp Change
_app-a5b2e84..33cf.js gzip 1.26 kB 1.26 kB
_error-6f1f9..5577.js gzip 3.38 kB 3.38 kB
hooks-725de8..0a15.js gzip 904 B 904 B
index-939503..6e1c.js gzip 232 B 232 B
link-e0cc871..fdbb.js gzip 1.63 kB 1.63 kB
routerDirect..9360.js gzip 308 B 308 B
withRouter-6..44ec.js gzip 304 B 304 B
Overall change 8.02 kB 8.02 kB
Client Build Manifests
vercel/next.js canary chulkilee/next.js remove-mkdirp Change
_buildManifest.js gzip 299 B 299 B
Overall change 299 B 299 B
Rendered Page Sizes
vercel/next.js canary chulkilee/next.js remove-mkdirp Change
index.html gzip 587 B 587 B
link.html gzip 593 B 593 B
withRouter.html gzip 581 B 581 B
Overall change 1.76 kB 1.76 kB

Diffs

Diff for index.html
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "YseNqsdDl9cJFhW20g4XK",
+        "buildId": "Py5LCVM_aQY2bK0_6NJ6R",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/YseNqsdDl9cJFhW20g4XK/_buildManifest.js"
+      src="/_next/static/Py5LCVM_aQY2bK0_6NJ6R/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/YseNqsdDl9cJFhW20g4XK/_ssgManifest.js"
+      src="/_next/static/Py5LCVM_aQY2bK0_6NJ6R/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "YseNqsdDl9cJFhW20g4XK",
+        "buildId": "Py5LCVM_aQY2bK0_6NJ6R",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/YseNqsdDl9cJFhW20g4XK/_buildManifest.js"
+      src="/_next/static/Py5LCVM_aQY2bK0_6NJ6R/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/YseNqsdDl9cJFhW20g4XK/_ssgManifest.js"
+      src="/_next/static/Py5LCVM_aQY2bK0_6NJ6R/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "YseNqsdDl9cJFhW20g4XK",
+        "buildId": "Py5LCVM_aQY2bK0_6NJ6R",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/YseNqsdDl9cJFhW20g4XK/_buildManifest.js"
+      src="/_next/static/Py5LCVM_aQY2bK0_6NJ6R/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/YseNqsdDl9cJFhW20g4XK/_ssgManifest.js"
+      src="/_next/static/Py5LCVM_aQY2bK0_6NJ6R/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 53f807b

Copy link
Member

@timneutkens timneutkens left a comment

This looks fine to land

@ijjk
Copy link
Member

ijjk commented Jan 26, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary chulkilee/next.js remove-mkdirp Change
buildDuration 12.6s 13s ⚠️ +337ms
nodeModulesSize 74.9 MB 74.9 MB ⚠️ +90.6 kB
Page Load Tests Overall increase ✓
vercel/next.js canary chulkilee/next.js remove-mkdirp Change
/ failed reqs 0 0
/ total time (seconds) 2.468 2.556 ⚠️ +0.09
/ avg req/sec 1012.83 978.09 ⚠️ -34.74
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.86 1.78 -0.08
/error-in-render avg req/sec 1343.91 1404.24 +60.33
Client Bundles (main, webpack, commons)
vercel/next.js canary chulkilee/next.js remove-mkdirp Change
677f882d2ed8..38ed.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 6.63 kB 6.63 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary chulkilee/next.js remove-mkdirp Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary chulkilee/next.js remove-mkdirp Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
hooks-c71ae4..70cd.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary chulkilee/next.js remove-mkdirp Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Rendered Page Sizes
vercel/next.js canary chulkilee/next.js remove-mkdirp Change
index.html gzip 614 B 614 B
link.html gzip 620 B 620 B
withRouter.html gzip 607 B 607 B
Overall change 1.84 kB 1.84 kB

Serverless Mode
General Overall increase ⚠️
vercel/next.js canary chulkilee/next.js remove-mkdirp Change
buildDuration 15.3s 15.2s -49ms
nodeModulesSize 74.9 MB 74.9 MB ⚠️ +90.6 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary chulkilee/next.js remove-mkdirp Change
677f882d2ed8..38ed.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 6.63 kB 6.63 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary chulkilee/next.js remove-mkdirp Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary chulkilee/next.js remove-mkdirp Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
hooks-c71ae4..70cd.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary chulkilee/next.js remove-mkdirp Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Serverless bundles
vercel/next.js canary chulkilee/next.js remove-mkdirp Change
_error.js 1 MB 1 MB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 1 MB 1 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.19 MB 5.19 MB

Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary chulkilee/next.js remove-mkdirp Change
buildDuration 15.2s 15.8s ⚠️ +571ms
nodeModulesSize 74.9 MB 74.9 MB ⚠️ +90.6 kB
Page Load Tests Overall increase ✓
vercel/next.js canary chulkilee/next.js remove-mkdirp Change
/ failed reqs 0 0
/ total time (seconds) 2.532 2.53 0
/ avg req/sec 987.4 988.15 +0.75
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.809 1.737 -0.07
/error-in-render avg req/sec 1382.2 1439.12 +56.92
Client Bundles (main, webpack, commons)
vercel/next.js canary chulkilee/next.js remove-mkdirp Change
597-c48889ef..1870.js gzip 13 kB 13 kB
framework.HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 6.58 kB 6.58 kB
webpack-HASH.js gzip 954 B 954 B
Overall change 59.8 kB 59.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary chulkilee/next.js remove-mkdirp Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary chulkilee/next.js remove-mkdirp Change
_app-a5b2e84..33cf.js gzip 1.26 kB 1.26 kB
_error-6f1f9..5577.js gzip 3.38 kB 3.38 kB
hooks-725de8..0a15.js gzip 904 B 904 B
index-939503..6e1c.js gzip 232 B 232 B
link-e0cc871..fdbb.js gzip 1.63 kB 1.63 kB
routerDirect..9360.js gzip 308 B 308 B
withRouter-6..44ec.js gzip 304 B 304 B
Overall change 8.02 kB 8.02 kB
Client Build Manifests
vercel/next.js canary chulkilee/next.js remove-mkdirp Change
_buildManifest.js gzip 299 B 299 B
Overall change 299 B 299 B
Rendered Page Sizes
vercel/next.js canary chulkilee/next.js remove-mkdirp Change
index.html gzip 587 B 587 B
link.html gzip 591 B 591 B
withRouter.html gzip 580 B 580 B
Overall change 1.76 kB 1.76 kB

Diffs

Diff for index.html
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "dBMC0C0omPqogKN_FNTOV",
+        "buildId": "BWdCGkC9CRgKLajIqNFPY",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/dBMC0C0omPqogKN_FNTOV/_buildManifest.js"
+      src="/_next/static/BWdCGkC9CRgKLajIqNFPY/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/dBMC0C0omPqogKN_FNTOV/_ssgManifest.js"
+      src="/_next/static/BWdCGkC9CRgKLajIqNFPY/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "dBMC0C0omPqogKN_FNTOV",
+        "buildId": "BWdCGkC9CRgKLajIqNFPY",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/dBMC0C0omPqogKN_FNTOV/_buildManifest.js"
+      src="/_next/static/BWdCGkC9CRgKLajIqNFPY/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/dBMC0C0omPqogKN_FNTOV/_ssgManifest.js"
+      src="/_next/static/BWdCGkC9CRgKLajIqNFPY/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "dBMC0C0omPqogKN_FNTOV",
+        "buildId": "BWdCGkC9CRgKLajIqNFPY",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/dBMC0C0omPqogKN_FNTOV/_buildManifest.js"
+      src="/_next/static/BWdCGkC9CRgKLajIqNFPY/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/dBMC0C0omPqogKN_FNTOV/_ssgManifest.js"
+      src="/_next/static/BWdCGkC9CRgKLajIqNFPY/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: efeb164

@kodiakhq kodiakhq bot merged commit f6cc0de into vercel:canary Jan 26, 2021
26 of 28 checks passed
@chulkilee chulkilee deleted the remove-mkdirp branch Jan 26, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants