Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use same num workers between export and build #24180

Merged
merged 3 commits into from
Apr 17, 2021
Merged

Use same num workers between export and build #24180

merged 3 commits into from
Apr 17, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Apr 17, 2021

This ensures we use the same numWorkers config between next build and next export since we already calculate the correct value to use in the config.

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Fixes: #23318

@ijjk
Copy link
Member Author

ijjk commented Apr 17, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
buildDuration 14.7s 15.1s ⚠️ +384ms
buildDurationCached 4.3s 4.3s -53ms
nodeModulesSize 46.2 MB 46.2 MB -100 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.666 2.735 ⚠️ +0.07
/ avg req/sec 937.64 914.09 ⚠️ -23.55
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.596 1.54 -0.06
/error-in-render avg req/sec 1566.67 1623.44 +56.77
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.05 kB 7.05 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
index.html gzip 611 B 611 B ✓
link.html gzip 616 B 616 B ✓
withRouter.html gzip 604 B 604 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
buildDuration 18s 17.9s -79ms
buildDurationCached 6.3s 6.4s ⚠️ +52ms
nodeModulesSize 46.2 MB 46.2 MB -100 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.05 kB 7.05 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Serverless bundles Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
_error.js 1.39 MB 1.39 MB ✓
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.7 kB 10.7 kB ✓
amp.html 1.96 kB 1.96 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.39 MB 1.39 MB ⚠️ +2 B
link.js 1.45 MB 1.45 MB ✓
routerDirect.js 1.44 MB 1.44 MB -4 B
withRouter.js 1.44 MB 1.44 MB ✓
Overall change 7.14 MB 7.14 MB -2 B
Webpack 4 Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
buildDuration 11.9s 11.9s ⚠️ +54ms
buildDurationCached 5s 4.9s -89ms
nodeModulesSize 46.2 MB 46.2 MB -100 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.696 2.652 -0.04
/ avg req/sec 927.21 942.68 +15.47
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.614 1.674 ⚠️ +0.06
/error-in-render avg req/sec 1548.89 1493.83 ⚠️ -55.06
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.12 kB 7.12 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.71 kB 3.71 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
hooks-HASH.js gzip 888 B 888 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
Overall change 8.89 kB 8.89 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
_buildManifest.js gzip 371 B 371 B ✓
Overall change 371 B 371 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
index.html gzip 613 B 613 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: 58a91f4

@ijjk ijjk marked this pull request as ready for review April 17, 2021 17:33
@ijjk
Copy link
Member Author

ijjk commented Apr 17, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
buildDuration 12.7s 14.4s ⚠️ +1.8s
buildDurationCached 4.4s 4.4s ⚠️ +14ms
nodeModulesSize 46.2 MB 46.2 MB -100 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.442 2.121 -0.32
/ avg req/sec 1023.64 1178.93 +155.29
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.38 1.227 -0.15
/error-in-render avg req/sec 1812.22 2036.69 +224.47
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.05 kB 7.05 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
index.html gzip 611 B 611 B ✓
link.html gzip 616 B 616 B ✓
withRouter.html gzip 604 B 604 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
buildDuration 17.2s 16.1s -1.1s
buildDurationCached 6.6s 6.6s ⚠️ +2ms
nodeModulesSize 46.2 MB 46.2 MB -100 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.05 kB 7.05 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Serverless bundles
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
_error.js 1.39 MB 1.39 MB ✓
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.7 kB 10.7 kB ✓
amp.html 1.96 kB 1.96 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.39 MB 1.39 MB ✓
link.js 1.45 MB 1.45 MB ✓
routerDirect.js 1.44 MB 1.44 MB ✓
withRouter.js 1.44 MB 1.44 MB ✓
Overall change 7.14 MB 7.14 MB ✓
Webpack 4 Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
buildDuration 12.7s 12.2s -574ms
buildDurationCached 5.2s 4.6s -641ms
nodeModulesSize 46.2 MB 46.2 MB -100 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.39 2.473 ⚠️ +0.08
/ avg req/sec 1045.94 1010.86 ⚠️ -35.08
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.105 1.347 ⚠️ +0.24
/error-in-render avg req/sec 2262.81 1855.33 ⚠️ -407.48
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.12 kB 7.12 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.71 kB 3.71 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
hooks-HASH.js gzip 888 B 888 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
Overall change 8.89 kB 8.89 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
_buildManifest.js gzip 371 B 371 B ✓
Overall change 371 B 371 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
index.html gzip 613 B 613 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: 89d780d

@ijjk
Copy link
Member Author

ijjk commented Apr 17, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
buildDuration 15s 15.1s ⚠️ +99ms
buildDurationCached 4.7s 4.6s -84ms
nodeModulesSize 46.2 MB 46.2 MB -100 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.774 2.678 -0.1
/ avg req/sec 901.38 933.68 +32.3
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.577 1.568 -0.01
/error-in-render avg req/sec 1584.85 1594.04 +9.19
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.05 kB 7.05 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
index.html gzip 611 B 611 B ✓
link.html gzip 616 B 616 B ✓
withRouter.html gzip 604 B 604 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
buildDuration 19s 19.5s ⚠️ +511ms
buildDurationCached 6.7s 6.7s -77ms
nodeModulesSize 46.2 MB 46.2 MB -100 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.05 kB 7.05 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Serverless bundles
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
_error.js 1.39 MB 1.39 MB ✓
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.7 kB 10.7 kB ✓
amp.html 1.96 kB 1.96 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.39 MB 1.39 MB ✓
link.js 1.45 MB 1.45 MB ✓
routerDirect.js 1.44 MB 1.44 MB ✓
withRouter.js 1.44 MB 1.44 MB ✓
Overall change 7.14 MB 7.14 MB ✓
Webpack 4 Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
buildDuration 12.3s 12.6s ⚠️ +348ms
buildDurationCached 5.2s 5.2s ⚠️ +14ms
nodeModulesSize 46.2 MB 46.2 MB -100 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.751 2.7 -0.05
/ avg req/sec 908.79 926.01 +17.22
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.557 1.556 0
/error-in-render avg req/sec 1605.96 1606.25 +0.29
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.12 kB 7.12 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.71 kB 3.71 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
hooks-HASH.js gzip 888 B 888 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
Overall change 8.89 kB 8.89 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
_buildManifest.js gzip 371 B 371 B ✓
Overall change 371 B 371 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/num-workers-export Change
index.html gzip 613 B 613 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: 0eb5746

@kodiakhq kodiakhq bot merged commit 432c9ee into vercel:canary Apr 17, 2021
@ijjk ijjk deleted the fix/num-workers-export branch April 17, 2021 20:47
SokratisVidros pushed a commit to SokratisVidros/next.js that referenced this pull request Apr 20, 2021
@ijjk @SokratisVidros
Use same num workers between export and build (vercel#24180)
854c58a 
This ensures we use the same `numWorkers` config between `next build` and `next export` since we already calculate the correct value to use [in the config](https://github.com/vercel/next.js/blob/6e22a440e284628ed768a1a92a2936b9f5b1f380/packages/next/next-server/server/config-shared.ts#L99-L103). 

## Bug

- [x] Related issues linked using `fixes #number`
- [ ] Integration tests added

Fixes: vercel#23318
@sync-by-unito sync-by-unito bot mentioned this pull request May 18, 2021
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shuding shuding shuding approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CIRCLE_NODE_TOTAL isn't used when running next export
2 participants
@ijjk @shuding