Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error for getStaticPaths on non-dynamic page #24188

Merged
merged 2 commits into from
Apr 18, 2021
Merged

Add error for getStaticPaths on non-dynamic page #24188

merged 2 commits into from
Apr 18, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Apr 17, 2021

Noticed in this issue the reproduction was using getStaticPaths on a non-dynamic page incorrectly although we don't currently show an error for this.

Bug

  • Related issues linked using fixes #number
  • Integration tests added

x-ref: #22931

@ijjk
Copy link
Member Author

ijjk commented Apr 17, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js error/non-dynamic-getstaticpaths Change
buildDuration 12.2s 12s -227ms
buildDurationCached 3.8s 3.8s ⚠️ +35ms
nodeModulesSize 46.2 MB 46.3 MB ⚠️ +602 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js error/non-dynamic-getstaticpaths Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.133 2.123 -0.01
/ avg req/sec 1172.19 1177.78 +5.59
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.117 1.103 -0.01
/error-in-render avg req/sec 2238.02 2266.23 +28.21
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js error/non-dynamic-getstaticpaths Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.05 kB 7.05 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js error/non-dynamic-getstaticpaths Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js error/non-dynamic-getstaticpaths Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js error/non-dynamic-getstaticpaths Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js error/non-dynamic-getstaticpaths Change
index.html gzip 611 B 611 B ✓
link.html gzip 616 B 616 B ✓
withRouter.html gzip 604 B 604 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js error/non-dynamic-getstaticpaths Change
buildDuration 15.2s 15s -143ms
buildDurationCached 5.5s 5.5s -85ms
nodeModulesSize 46.2 MB 46.3 MB ⚠️ +602 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js error/non-dynamic-getstaticpaths Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.05 kB 7.05 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js error/non-dynamic-getstaticpaths Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js error/non-dynamic-getstaticpaths Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js error/non-dynamic-getstaticpaths Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary ijjk/next.js error/non-dynamic-getstaticpaths Change
_error.js 1.39 MB 1.39 MB ⚠️ +221 B
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.7 kB 10.7 kB ✓
amp.html 1.96 kB 1.96 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.39 MB 1.39 MB ⚠️ +221 B
link.js 1.45 MB 1.45 MB ⚠️ +221 B
routerDirect.js 1.44 MB 1.44 MB ⚠️ +219 B
withRouter.js 1.44 MB 1.44 MB ⚠️ +221 B
Overall change 7.15 MB 7.15 MB ⚠️ +1.1 kB
Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js error/non-dynamic-getstaticpaths Change
buildDuration 10.4s 10.4s ⚠️ +5ms
buildDurationCached 4.2s 4.1s -57ms
nodeModulesSize 46.2 MB 46.3 MB ⚠️ +602 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js error/non-dynamic-getstaticpaths Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.128 2.132 0
/ avg req/sec 1174.69 1172.68 ⚠️ -2.01
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.089 1.115 ⚠️ +0.03
/error-in-render avg req/sec 2295.25 2242.82 ⚠️ -52.43
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js error/non-dynamic-getstaticpaths Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.12 kB 7.12 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js error/non-dynamic-getstaticpaths Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js error/non-dynamic-getstaticpaths Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.71 kB 3.71 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
hooks-HASH.js gzip 888 B 888 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
Overall change 8.89 kB 8.89 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js error/non-dynamic-getstaticpaths Change
_buildManifest.js gzip 371 B 371 B ✓
Overall change 371 B 371 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js error/non-dynamic-getstaticpaths Change
index.html gzip 613 B 613 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: 3550ea9

@ijjk ijjk marked this pull request as ready for review April 18, 2021 00:08
@ijjk
Copy link
Member Author

ijjk commented Apr 18, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js error/non-dynamic-getstaticpaths Change
buildDuration 16.2s 16.5s ⚠️ +235ms
buildDurationCached 4.9s 4.8s -107ms
nodeModulesSize 46.3 MB 46.3 MB ⚠️ +602 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js error/non-dynamic-getstaticpaths Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.995 3.003 ⚠️ +0.01
/ avg req/sec 834.75 832.52 ⚠️ -2.23
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.707 1.658 -0.05
/error-in-render avg req/sec 1464.42 1507.95 +43.53
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js error/non-dynamic-getstaticpaths Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.05 kB 7.05 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js error/non-dynamic-getstaticpaths Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js error/non-dynamic-getstaticpaths Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js error/non-dynamic-getstaticpaths Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js error/non-dynamic-getstaticpaths Change
index.html gzip 609 B 609 B ✓
link.html gzip 615 B 615 B ✓
withRouter.html gzip 603 B 603 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js error/non-dynamic-getstaticpaths Change
buildDuration 20.4s 20.7s ⚠️ +297ms
buildDurationCached 7.3s 7.1s -132ms
nodeModulesSize 46.3 MB 46.3 MB ⚠️ +602 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js error/non-dynamic-getstaticpaths Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.05 kB 7.05 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js error/non-dynamic-getstaticpaths Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js error/non-dynamic-getstaticpaths Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js error/non-dynamic-getstaticpaths Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary ijjk/next.js error/non-dynamic-getstaticpaths Change
_error.js 1.39 MB 1.39 MB ⚠️ +219 B
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.7 kB 10.7 kB ✓
amp.html 1.96 kB 1.96 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.39 MB 1.39 MB ⚠️ +221 B
link.js 1.45 MB 1.45 MB ⚠️ +217 B
routerDirect.js 1.44 MB 1.44 MB ⚠️ +221 B
withRouter.js 1.44 MB 1.44 MB ⚠️ +221 B
Overall change 7.15 MB 7.15 MB ⚠️ +1.1 kB
Webpack 4 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js error/non-dynamic-getstaticpaths Change
buildDuration 13.6s 13.4s -167ms
buildDurationCached 5.8s 5.4s -368ms
nodeModulesSize 46.3 MB 46.3 MB ⚠️ +602 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js error/non-dynamic-getstaticpaths Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.893 2.859 -0.03
/ avg req/sec 864.12 874.47 +10.35
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.756 1.709 -0.05
/error-in-render avg req/sec 1423.34 1463.06 +39.72
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js error/non-dynamic-getstaticpaths Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.12 kB 7.12 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js error/non-dynamic-getstaticpaths Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js error/non-dynamic-getstaticpaths Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.71 kB 3.71 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
hooks-HASH.js gzip 888 B 888 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
Overall change 8.89 kB 8.89 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js error/non-dynamic-getstaticpaths Change
_buildManifest.js gzip 371 B 371 B ✓
Overall change 371 B 371 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js error/non-dynamic-getstaticpaths Change
index.html gzip 613 B 613 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 609 B 609 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: 6c6d0b2

@kodiakhq kodiakhq bot merged commit 6e7245c into vercel:canary Apr 18, 2021
@ijjk ijjk deleted the error/non-dynamic-getstaticpaths branch April 18, 2021 12:00
SokratisVidros pushed a commit to SokratisVidros/next.js that referenced this pull request Apr 20, 2021
@ijjk @SokratisVidros
Add error for getStaticPaths on non-dynamic page (vercel#24188)
96d3016 
Noticed in this issue the reproduction was using `getStaticPaths` on a non-dynamic page incorrectly although we don't currently show an error for this. 

## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added

x-ref: vercel#22931
@sync-by-unito sync-by-unito bot mentioned this pull request May 18, 2021
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ijjk @timneutkens