Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure locale key not duplicated when navigating back to root path with a query or hash value #24323

Merged
merged 2 commits into from
Apr 22, 2021
Merged

Ensure locale key not duplicated when navigating back to root path with a query or hash value #24323

merged 2 commits into from
Apr 22, 2021

Conversation

kylemarshall18
Copy link
Contributor

This ensures that a duplicate locale key is not prepended to the path when navigating back (using browsers back button) to the root path containing query parameters or a hash value.

Current behaviour:

  • /fr?value=1 -> /fr/another -> click browser back button -> /fr/fr?value=1
  • /fr?value=1 -> /fr?value=2 -> click browser back button -> /fr/fr?value=1
  • /fr#section -> /fr/another -> click browser back button -> /fr/fr#section
  • /fr#section -> /fr#another -> click browser back button -> /fr/fr#section

Fix:
Remove query string or hash value from path before determining whether to add the locale to the path in addLocale function.

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Fixes: #24287

@ijjk
Copy link
Member

ijjk commented Apr 21, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary kylemarshall18/next.js fix/i18n-locale-query-params Change
buildDuration 15s 16.1s ⚠️ +1.2s
buildDurationCached 5.5s 4.7s -751ms
nodeModulesSize 46.6 MB 46.6 MB ⚠️ +138 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kylemarshall18/next.js fix/i18n-locale-query-params Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.628 2.893 ⚠️ +0.26
/ avg req/sec 951.44 864.26 ⚠️ -87.18
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.57 1.601 ⚠️ +0.03
/error-in-render avg req/sec 1592.47 1561.15 ⚠️ -31.32
Client Bundles (main, webpack, commons)
vercel/next.js canary kylemarshall18/next.js fix/i18n-locale-query-params Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.12 kB 7.12 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary kylemarshall18/next.js fix/i18n-locale-query-params Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary kylemarshall18/next.js fix/i18n-locale-query-params Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary kylemarshall18/next.js fix/i18n-locale-query-params Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary kylemarshall18/next.js fix/i18n-locale-query-params Change
index.html gzip 610 B 609 B -1 B
link.html gzip 615 B 615 B ✓
withRouter.html gzip 604 B 604 B ✓
Overall change 1.83 kB 1.83 kB -1 B

Diffs

Diff for 597-HASH.js 
@@ -1436,7 +1436,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
 
       function addLocale(path, locale, defaultLocale) {
         if (false) {
-          var localeLower, pathLower;
+          var localeLower, pathLower, pathname;
         }
 
         return path;
Diff for index.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/webpack-b6976af37b4cba711bde.js"
+      href="/_next/static/chunks/webpack-cb3e79d84e65ca7a49d8.js"
       as="script"
     />
     <link
@@ -17,7 +17,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/597-ce2d8ad287ead7daa2d3.js"
+      href="/_next/static/chunks/597-43fe3bf983c91163dca3.js"
       as="script"
     />
     <link
@@ -58,7 +58,7 @@
       src="/_next/static/chunks/polyfills-8683bd742a84c1edd48c.js"
     ></script>
     <script
-      src="/_next/static/chunks/webpack-b6976af37b4cba711bde.js"
+      src="/_next/static/chunks/webpack-cb3e79d84e65ca7a49d8.js"
       async=""
     ></script>
     <script
@@ -66,7 +66,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/597-ce2d8ad287ead7daa2d3.js"
+      src="/_next/static/chunks/597-43fe3bf983c91163dca3.js"
       async=""
     ></script>
     <script
Diff for link.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/webpack-b6976af37b4cba711bde.js"
+      href="/_next/static/chunks/webpack-cb3e79d84e65ca7a49d8.js"
       as="script"
     />
     <link
@@ -17,7 +17,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/597-ce2d8ad287ead7daa2d3.js"
+      href="/_next/static/chunks/597-43fe3bf983c91163dca3.js"
       as="script"
     />
     <link
@@ -63,7 +63,7 @@
       src="/_next/static/chunks/polyfills-8683bd742a84c1edd48c.js"
     ></script>
     <script
-      src="/_next/static/chunks/webpack-b6976af37b4cba711bde.js"
+      src="/_next/static/chunks/webpack-cb3e79d84e65ca7a49d8.js"
       async=""
     ></script>
     <script
@@ -71,7 +71,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/597-ce2d8ad287ead7daa2d3.js"
+      src="/_next/static/chunks/597-43fe3bf983c91163dca3.js"
       async=""
     ></script>
     <script
Diff for withRouter.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/webpack-b6976af37b4cba711bde.js"
+      href="/_next/static/chunks/webpack-cb3e79d84e65ca7a49d8.js"
       as="script"
     />
     <link
@@ -17,7 +17,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/597-ce2d8ad287ead7daa2d3.js"
+      href="/_next/static/chunks/597-43fe3bf983c91163dca3.js"
       as="script"
     />
     <link
@@ -58,7 +58,7 @@
       src="/_next/static/chunks/polyfills-8683bd742a84c1edd48c.js"
     ></script>
     <script
-      src="/_next/static/chunks/webpack-b6976af37b4cba711bde.js"
+      src="/_next/static/chunks/webpack-cb3e79d84e65ca7a49d8.js"
       async=""
     ></script>
     <script
@@ -66,7 +66,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/597-ce2d8ad287ead7daa2d3.js"
+      src="/_next/static/chunks/597-43fe3bf983c91163dca3.js"
       async=""
     ></script>
     <script
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary kylemarshall18/next.js fix/i18n-locale-query-params Change
buildDuration 18.3s 18.9s ⚠️ +529ms
buildDurationCached 7.1s 6.8s -251ms
nodeModulesSize 46.6 MB 46.6 MB ⚠️ +138 B
Client Bundles (main, webpack, commons)
vercel/next.js canary kylemarshall18/next.js fix/i18n-locale-query-params Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.12 kB 7.12 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary kylemarshall18/next.js fix/i18n-locale-query-params Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary kylemarshall18/next.js fix/i18n-locale-query-params Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary kylemarshall18/next.js fix/i18n-locale-query-params Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Serverless bundles
vercel/next.js canary kylemarshall18/next.js fix/i18n-locale-query-params Change
_error.js 1.39 MB 1.39 MB ✓
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.96 kB 1.96 kB ✓
css.html 2.13 kB 2.13 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.39 MB 1.39 MB ✓
link.js 1.45 MB 1.45 MB ✓
routerDirect.js 1.44 MB 1.44 MB ✓
withRouter.js 1.44 MB 1.44 MB ✓
Overall change 7.15 MB 7.15 MB ✓
Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary kylemarshall18/next.js fix/i18n-locale-query-params Change
buildDuration 12.8s 12.6s -122ms
buildDurationCached 5.1s 5.9s ⚠️ +813ms
nodeModulesSize 46.6 MB 46.6 MB ⚠️ +138 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kylemarshall18/next.js fix/i18n-locale-query-params Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.675 2.674 0
/ avg req/sec 934.7 935.02 +0.32
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.547 1.652 ⚠️ +0.1
/error-in-render avg req/sec 1615.77 1513.73 ⚠️ -102.04
Client Bundles (main, webpack, commons)
vercel/next.js canary kylemarshall18/next.js fix/i18n-locale-query-params Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.2 kB 7.2 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary kylemarshall18/next.js fix/i18n-locale-query-params Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary kylemarshall18/next.js fix/i18n-locale-query-params Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.71 kB 3.71 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
21c68fa65a48..217.css gzip 125 B 125 B ✓
Overall change 9.36 kB 9.36 kB ✓
Client Build Manifests
vercel/next.js canary kylemarshall18/next.js fix/i18n-locale-query-params Change
_buildManifest.js gzip 419 B 419 B ✓
Overall change 419 B 419 B ✓
Rendered Page Sizes
vercel/next.js canary kylemarshall18/next.js fix/i18n-locale-query-params Change
index.html gzip 612 B 611 B -1 B
link.html gzip 619 B 620 B ⚠️ +1 B
withRouter.html gzip 605 B 605 B ✓
Overall change 1.84 kB 1.84 kB ✓

Diffs

Diff for 677f882d2ed8..c4df.HASH.js 
@@ -1273,7 +1273,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
 
       function addLocale(path, locale, defaultLocale) {
         if (false) {
-          var localeLower, pathLower;
+          var localeLower, pathLower, pathname;
         }
 
         return path;
Diff for index.html 
@@ -17,7 +17,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.95fa13665e1988802dfd.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.8aa73afbb6b2a0863510.js"
       as="script"
     />
     <link
@@ -61,7 +61,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.95fa13665e1988802dfd.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.8aa73afbb6b2a0863510.js"
       async=""
     ></script>
     <script
Diff for link.html 
@@ -17,7 +17,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.95fa13665e1988802dfd.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.8aa73afbb6b2a0863510.js"
       as="script"
     />
     <link
@@ -66,7 +66,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.95fa13665e1988802dfd.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.8aa73afbb6b2a0863510.js"
       async=""
     ></script>
     <script
Diff for withRouter.html 
@@ -17,7 +17,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.95fa13665e1988802dfd.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.8aa73afbb6b2a0863510.js"
       as="script"
     />
     <link
@@ -61,7 +61,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.95fa13665e1988802dfd.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.8aa73afbb6b2a0863510.js"
       async=""
     ></script>
     <script
Commit: 9dcb006

ijjk
ijjk approved these changes Apr 22, 2021
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good, thanks for the PR!

@ijjk
Copy link
Member

ijjk commented Apr 22, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary kylemarshall18/next.js fix/i18n-locale-query-params Change
buildDuration 15.7s 15.7s -14ms
buildDurationCached 5.1s 4.9s -240ms
nodeModulesSize 46.6 MB 46.6 MB ⚠️ +138 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kylemarshall18/next.js fix/i18n-locale-query-params Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.712 2.719 ⚠️ +0.01
/ avg req/sec 921.91 919.46 ⚠️ -2.45
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.544 1.614 ⚠️ +0.07
/error-in-render avg req/sec 1619.01 1548.88 ⚠️ -70.13
Client Bundles (main, webpack, commons)
vercel/next.js canary kylemarshall18/next.js fix/i18n-locale-query-params Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.12 kB 7.12 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary kylemarshall18/next.js fix/i18n-locale-query-params Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary kylemarshall18/next.js fix/i18n-locale-query-params Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary kylemarshall18/next.js fix/i18n-locale-query-params Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary kylemarshall18/next.js fix/i18n-locale-query-params Change
index.html gzip 610 B 609 B -1 B
link.html gzip 615 B 615 B ✓
withRouter.html gzip 604 B 604 B ✓
Overall change 1.83 kB 1.83 kB -1 B

Diffs

Diff for 597-HASH.js 
@@ -1436,7 +1436,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
 
       function addLocale(path, locale, defaultLocale) {
         if (false) {
-          var localeLower, pathLower;
+          var localeLower, pathLower, pathname;
         }
 
         return path;
Diff for index.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/webpack-b6976af37b4cba711bde.js"
+      href="/_next/static/chunks/webpack-cb3e79d84e65ca7a49d8.js"
       as="script"
     />
     <link
@@ -17,7 +17,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/597-ce2d8ad287ead7daa2d3.js"
+      href="/_next/static/chunks/597-43fe3bf983c91163dca3.js"
       as="script"
     />
     <link
@@ -58,7 +58,7 @@
       src="/_next/static/chunks/polyfills-8683bd742a84c1edd48c.js"
     ></script>
     <script
-      src="/_next/static/chunks/webpack-b6976af37b4cba711bde.js"
+      src="/_next/static/chunks/webpack-cb3e79d84e65ca7a49d8.js"
       async=""
     ></script>
     <script
@@ -66,7 +66,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/597-ce2d8ad287ead7daa2d3.js"
+      src="/_next/static/chunks/597-43fe3bf983c91163dca3.js"
       async=""
     ></script>
     <script
Diff for link.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/webpack-b6976af37b4cba711bde.js"
+      href="/_next/static/chunks/webpack-cb3e79d84e65ca7a49d8.js"
       as="script"
     />
     <link
@@ -17,7 +17,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/597-ce2d8ad287ead7daa2d3.js"
+      href="/_next/static/chunks/597-43fe3bf983c91163dca3.js"
       as="script"
     />
     <link
@@ -63,7 +63,7 @@
       src="/_next/static/chunks/polyfills-8683bd742a84c1edd48c.js"
     ></script>
     <script
-      src="/_next/static/chunks/webpack-b6976af37b4cba711bde.js"
+      src="/_next/static/chunks/webpack-cb3e79d84e65ca7a49d8.js"
       async=""
     ></script>
     <script
@@ -71,7 +71,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/597-ce2d8ad287ead7daa2d3.js"
+      src="/_next/static/chunks/597-43fe3bf983c91163dca3.js"
       async=""
     ></script>
     <script
Diff for withRouter.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/webpack-b6976af37b4cba711bde.js"
+      href="/_next/static/chunks/webpack-cb3e79d84e65ca7a49d8.js"
       as="script"
     />
     <link
@@ -17,7 +17,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/597-ce2d8ad287ead7daa2d3.js"
+      href="/_next/static/chunks/597-43fe3bf983c91163dca3.js"
       as="script"
     />
     <link
@@ -58,7 +58,7 @@
       src="/_next/static/chunks/polyfills-8683bd742a84c1edd48c.js"
     ></script>
     <script
-      src="/_next/static/chunks/webpack-b6976af37b4cba711bde.js"
+      src="/_next/static/chunks/webpack-cb3e79d84e65ca7a49d8.js"
       async=""
     ></script>
     <script
@@ -66,7 +66,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/597-ce2d8ad287ead7daa2d3.js"
+      src="/_next/static/chunks/597-43fe3bf983c91163dca3.js"
       async=""
     ></script>
     <script
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary kylemarshall18/next.js fix/i18n-locale-query-params Change
buildDuration 19s 19.3s ⚠️ +289ms
buildDurationCached 7.2s 7.2s ⚠️ +34ms
nodeModulesSize 46.6 MB 46.6 MB ⚠️ +138 B
Client Bundles (main, webpack, commons)
vercel/next.js canary kylemarshall18/next.js fix/i18n-locale-query-params Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.12 kB 7.12 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary kylemarshall18/next.js fix/i18n-locale-query-params Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary kylemarshall18/next.js fix/i18n-locale-query-params Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary kylemarshall18/next.js fix/i18n-locale-query-params Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary kylemarshall18/next.js fix/i18n-locale-query-params Change
_error.js 1.39 MB 1.39 MB ⚠️ +2 B
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.96 kB 1.96 kB ✓
css.html 2.13 kB 2.13 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.39 MB 1.39 MB ✓
link.js 1.45 MB 1.45 MB ✓
routerDirect.js 1.44 MB 1.44 MB ✓
withRouter.js 1.44 MB 1.44 MB ✓
Overall change 7.15 MB 7.15 MB ⚠️ +2 B
Webpack 4 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kylemarshall18/next.js fix/i18n-locale-query-params Change
buildDuration 12.8s 13.2s ⚠️ +380ms
buildDurationCached 5.5s 5.5s ⚠️ +22ms
nodeModulesSize 46.6 MB 46.6 MB ⚠️ +138 B
Page Load Tests Overall increase ✓
vercel/next.js canary kylemarshall18/next.js fix/i18n-locale-query-params Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.653 2.71 ⚠️ +0.06
/ avg req/sec 942.42 922.53 ⚠️ -19.89
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.665 1.575 -0.09
/error-in-render avg req/sec 1501.49 1587.8 +86.31
Client Bundles (main, webpack, commons)
vercel/next.js canary kylemarshall18/next.js fix/i18n-locale-query-params Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.2 kB 7.2 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary kylemarshall18/next.js fix/i18n-locale-query-params Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary kylemarshall18/next.js fix/i18n-locale-query-params Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.71 kB 3.71 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
21c68fa65a48..217.css gzip 125 B 125 B ✓
Overall change 9.36 kB 9.36 kB ✓
Client Build Manifests
vercel/next.js canary kylemarshall18/next.js fix/i18n-locale-query-params Change
_buildManifest.js gzip 419 B 419 B ✓
Overall change 419 B 419 B ✓
Rendered Page Sizes
vercel/next.js canary kylemarshall18/next.js fix/i18n-locale-query-params Change
index.html gzip 612 B 611 B -1 B
link.html gzip 619 B 620 B ⚠️ +1 B
withRouter.html gzip 605 B 605 B ✓
Overall change 1.84 kB 1.84 kB ✓

Diffs

Diff for 677f882d2ed8..c4df.HASH.js 
@@ -1273,7 +1273,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
 
       function addLocale(path, locale, defaultLocale) {
         if (false) {
-          var localeLower, pathLower;
+          var localeLower, pathLower, pathname;
         }
 
         return path;
Diff for index.html 
@@ -17,7 +17,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.95fa13665e1988802dfd.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.8aa73afbb6b2a0863510.js"
       as="script"
     />
     <link
@@ -61,7 +61,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.95fa13665e1988802dfd.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.8aa73afbb6b2a0863510.js"
       async=""
     ></script>
     <script
Diff for link.html 
@@ -17,7 +17,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.95fa13665e1988802dfd.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.8aa73afbb6b2a0863510.js"
       as="script"
     />
     <link
@@ -66,7 +66,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.95fa13665e1988802dfd.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.8aa73afbb6b2a0863510.js"
       async=""
     ></script>
     <script
Diff for withRouter.html 
@@ -17,7 +17,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.95fa13665e1988802dfd.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.8aa73afbb6b2a0863510.js"
       as="script"
     />
     <link
@@ -61,7 +61,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.95fa13665e1988802dfd.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.8aa73afbb6b2a0863510.js"
       async=""
     ></script>
     <script
Commit: 23fc935

@kodiakhq kodiakhq bot merged commit a29d8c9 into vercel:canary Apr 22, 2021
@sync-by-unito sync-by-unito bot mentioned this pull request May 18, 2021
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicate locale key in path when using browser back button
3 participants
@kylemarshall18 @ijjk @kmarshall-ccmi