fix(types): allow nonpromise return types for static functions #24685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljosberinn
requested review from
divmain,
ijjk,
lfades,
shuding and
timneutkens
as code owners
timneutkens
requested changes
May 3, 2021
This comment has been minimized.
This comment has been minimized.
Stats from current PRDefault Server Mode (Increase detected
|
| vercel/next.js canary | ljosberinn/next.js fix/allow-nonpromise-static-paths-props | Change | |
|---|---|---|---|
| buildDuration | 13.9s | 13.9s | |
| buildDurationCached | 3.9s | 3.8s | -127ms |
| nodeModulesSize | 46.7 MB | 46.7 MB |
Page Load Tests Overall increase ✓
| vercel/next.js canary | ljosberinn/next.js fix/allow-nonpromise-static-paths-props | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 2.41 | 2.462 | |
| / avg req/sec | 1037.28 | 1015.55 | |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.35 | 1.262 | -0.09 |
| /error-in-render avg req/sec | 1851.83 | 1980.89 | +129.06 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | ljosberinn/next.js fix/allow-nonpromise-static-paths-props | Change | |
|---|---|---|---|
| framework-HASH.js gzip | 39.3 kB | 39.3 kB | ✓ |
| main-HASH.js gzip | 19.4 kB | 19.4 kB | ✓ |
| webpack-HASH.js gzip | 994 B | 994 B | ✓ |
| Overall change | 59.7 kB | 59.7 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | ljosberinn/next.js fix/allow-nonpromise-static-paths-props | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31.1 kB | 31.1 kB | ✓ |
| Overall change | 31.1 kB | 31.1 kB | ✓ |
Client Pages
| vercel/next.js canary | ljosberinn/next.js fix/allow-nonpromise-static-paths-props | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 1.02 kB | 1.02 kB | ✓ |
| _error-HASH.js gzip | 3.06 kB | 3.06 kB | ✓ |
| amp-HASH.js gzip | 526 B | 526 B | ✓ |
| css-HASH.js gzip | 334 B | 334 B | ✓ |
| hooks-HASH.js gzip | 890 B | 890 B | ✓ |
| index-HASH.js gzip | 262 B | 262 B | ✓ |
| link-HASH.js gzip | 1.65 kB | 1.65 kB | ✓ |
| routerDirect..HASH.js gzip | 331 B | 331 B | ✓ |
| withRouter-HASH.js gzip | 329 B | 329 B | ✓ |
| bb14e60e810b..30f.css gzip | 125 B | 125 B | ✓ |
| Overall change | 8.54 kB | 8.54 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | ljosberinn/next.js fix/allow-nonpromise-static-paths-props | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 390 B | 390 B | ✓ |
| Overall change | 390 B | 390 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | ljosberinn/next.js fix/allow-nonpromise-static-paths-props | Change | |
|---|---|---|---|
| index.html gzip | 561 B | 561 B | ✓ |
| link.html gzip | 569 B | 569 B | ✓ |
| withRouter.html gzip | 556 B | 556 B | ✓ |
| Overall change | 1.69 kB | 1.69 kB | ✓ |
Serverless Mode
General Overall increase ⚠️
| vercel/next.js canary | ljosberinn/next.js fix/allow-nonpromise-static-paths-props | Change | |
|---|---|---|---|
| buildDuration | 16.2s | 16s | -204ms |
| buildDurationCached | 5s | 4.8s | -103ms |
| nodeModulesSize | 46.7 MB | 46.7 MB |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | ljosberinn/next.js fix/allow-nonpromise-static-paths-props | Change | |
|---|---|---|---|
| framework-HASH.js gzip | 39.3 kB | 39.3 kB | ✓ |
| main-HASH.js gzip | 19.4 kB | 19.4 kB | ✓ |
| webpack-HASH.js gzip | 994 B | 994 B | ✓ |
| Overall change | 59.7 kB | 59.7 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | ljosberinn/next.js fix/allow-nonpromise-static-paths-props | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31.1 kB | 31.1 kB | ✓ |
| Overall change | 31.1 kB | 31.1 kB | ✓ |
Client Pages
| vercel/next.js canary | ljosberinn/next.js fix/allow-nonpromise-static-paths-props | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 1.02 kB | 1.02 kB | ✓ |
| _error-HASH.js gzip | 3.06 kB | 3.06 kB | ✓ |
| amp-HASH.js gzip | 526 B | 526 B | ✓ |
| css-HASH.js gzip | 334 B | 334 B | ✓ |
| hooks-HASH.js gzip | 890 B | 890 B | ✓ |
| index-HASH.js gzip | 262 B | 262 B | ✓ |
| link-HASH.js gzip | 1.65 kB | 1.65 kB | ✓ |
| routerDirect..HASH.js gzip | 331 B | 331 B | ✓ |
| withRouter-HASH.js gzip | 329 B | 329 B | ✓ |
| bb14e60e810b..30f.css gzip | 125 B | 125 B | ✓ |
| Overall change | 8.54 kB | 8.54 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | ljosberinn/next.js fix/allow-nonpromise-static-paths-props | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 390 B | 390 B | ✓ |
| Overall change | 390 B | 390 B | ✓ |
Serverless bundles
| vercel/next.js canary | ljosberinn/next.js fix/allow-nonpromise-static-paths-props | Change | |
|---|---|---|---|
| _error.js | 16.9 kB | 16.9 kB | ✓ |
| 404.html | 2.42 kB | 2.42 kB | ✓ |
| 500.html | 2.41 kB | 2.41 kB | ✓ |
| amp.amp.html | 10.8 kB | 10.8 kB | ✓ |
| amp.html | 1.61 kB | 1.61 kB | ✓ |
| css.html | 1.79 kB | 1.79 kB | ✓ |
| hooks.html | 1.67 kB | 1.67 kB | ✓ |
| index.js | 17.2 kB | 17.2 kB | ✓ |
| link.js | 17.4 kB | 17.4 kB | ✓ |
| routerDirect.js | 17.4 kB | 17.4 kB | ✓ |
| withRouter.js | 17.4 kB | 17.4 kB | ✓ |
| Overall change | 107 kB | 107 kB | ✓ |
Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
| vercel/next.js canary | ljosberinn/next.js fix/allow-nonpromise-static-paths-props | Change | |
|---|---|---|---|
| buildDuration | 12.4s | 12.5s | |
| buildDurationCached | 5.3s | 5.2s | -40ms |
| nodeModulesSize | 46.7 MB | 46.7 MB |
Page Load Tests Overall decrease ⚠️
| vercel/next.js canary | ljosberinn/next.js fix/allow-nonpromise-static-paths-props | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 2.45 | 2.474 | |
| / avg req/sec | 1020.37 | 1010.6 | |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.249 | 1.311 | |
| /error-in-render avg req/sec | 2001.48 | 1907.36 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | ljosberinn/next.js fix/allow-nonpromise-static-paths-props | Change | |
|---|---|---|---|
| 677f882d2ed8..HASH.js gzip | 13.3 kB | 13.3 kB | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| main-HASH.js gzip | 7.25 kB | 7.25 kB | ✓ |
| webpack-HASH.js gzip | 751 B | 751 B | ✓ |
| Overall change | 60.3 kB | 60.3 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | ljosberinn/next.js fix/allow-nonpromise-static-paths-props | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31.3 kB | 31.3 kB | ✓ |
| Overall change | 31.3 kB | 31.3 kB | ✓ |
Client Pages
| vercel/next.js canary | ljosberinn/next.js fix/allow-nonpromise-static-paths-props | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 1.28 kB | 1.28 kB | ✓ |
| _error-HASH.js gzip | 3.74 kB | 3.74 kB | ✓ |
| amp-HASH.js gzip | 536 B | 536 B | ✓ |
| css-HASH.js gzip | 339 B | 339 B | ✓ |
| hooks-HASH.js gzip | 887 B | 887 B | ✓ |
| index-HASH.js gzip | 227 B | 227 B | ✓ |
| link-HASH.js gzip | 1.64 kB | 1.64 kB | ✓ |
| routerDirect..HASH.js gzip | 303 B | 303 B | ✓ |
| withRouter-HASH.js gzip | 302 B | 302 B | ✓ |
| e025d2764813..52f.css gzip | 125 B | 125 B | ✓ |
| Overall change | 9.38 kB | 9.38 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | ljosberinn/next.js fix/allow-nonpromise-static-paths-props | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 420 B | 420 B | ✓ |
| Overall change | 420 B | 420 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | ljosberinn/next.js fix/allow-nonpromise-static-paths-props | Change | |
|---|---|---|---|
| index.html gzip | 614 B | 614 B | ✓ |
| link.html gzip | 620 B | 620 B | ✓ |
| withRouter.html gzip | 606 B | 606 B | ✓ |
| Overall change | 1.84 kB | 1.84 kB | ✓ |
flybayer
pushed a commit
to blitz-js/next.js
that referenced
this pull request
Jun 16, 2021
…l#24685) ## Bug - [x] fixes vercel#24684 - [x] Integration tests added Intentionally omitted changing the types for `GetServerSideProps` etc. as its imo less reasonable to leverage SSR with a sync `getServerSideProps`. Can of course change the type too if you consider that also a valid case.
TeeBangCo
approved these changes
Jun 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Intentionally omitted changing the types for
GetServerSidePropsetc. as its imo less reasonable to leverage SSR with a syncgetServerSideProps. Can of course change the type too if you consider that also a valid case.