Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin create-next-app to eslint@v7 #29837

Merged
merged 2 commits into from
Oct 12, 2021

Conversation

finn-orsini
Copy link
Contributor

Fixes #29770

Description

Pins eslint to v7. This avoids issues with v8 from both changes to the public api and lack of support from rushstack. See #29770 (comment) for slightly more detail.

Local testing showed output of next app correctly pinned to v7.

Screen Shot 2021-10-12 at 12 31 56 AM

Bug Checklist

  • Related issues linked using fixes #number
  • Integration tests added
    • Happy to add an integration test for pinning to v7 if we'd like, will need to be updated / removed when v8 is supported.
  • Errors have helpful link attached, see contributing.md
    • No errors to add links for

@ijjk ijjk added the create-next-app Related to our CLI tool for quickly starting a new Next.js application. label Oct 12, 2021
Copy link
Collaborator

@housseindjirdeh housseindjirdeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! We'll try to get this merged asap.

@ijjk
Copy link
Member

ijjk commented Oct 12, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General
vercel/next.js canary finn-orsini/next.js pin_eslint_7_sorsini Change
buildDuration 15.4s 15.8s ⚠️ +438ms
buildDurationCached 3.6s 3.6s ⚠️ +8ms
nodeModulesSize 200 MB 200 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary finn-orsini/next.js pin_eslint_7_sorsini Change
/ failed reqs 0 0
/ total time (seconds) 3.664 3.623 -0.04
/ avg req/sec 682.38 689.99 +7.61
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.905 2.06 ⚠️ +0.16
/error-in-render avg req/sec 1312.14 1213.81 ⚠️ -98.33
Client Bundles (main, webpack, commons)
vercel/next.js canary finn-orsini/next.js pin_eslint_7_sorsini Change
779.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27 kB 27 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 70.9 kB 70.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary finn-orsini/next.js pin_eslint_7_sorsini Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary finn-orsini/next.js pin_eslint_7_sorsini Change
_app-HASH.js gzip 977 B 977 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 311 B 311 B
css-HASH.js gzip 328 B 328 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.14 kB 4.14 kB
index-HASH.js gzip 260 B 260 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 319 B 319 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13 kB 13 kB
Client Build Manifests
vercel/next.js canary finn-orsini/next.js pin_eslint_7_sorsini Change
_buildManifest.js gzip 493 B 493 B
Overall change 493 B 493 B
Rendered Page Sizes
vercel/next.js canary finn-orsini/next.js pin_eslint_7_sorsini Change
index.html gzip 539 B 539 B
link.html gzip 551 B 551 B
withRouter.html gzip 532 B 532 B
Overall change 1.62 kB 1.62 kB

Default Build with SWC (Decrease detected ✓)
General
vercel/next.js canary finn-orsini/next.js pin_eslint_7_sorsini Change
buildDuration 7.8s 7.7s -177ms
buildDurationCached 3.6s 3.7s ⚠️ +99ms
nodeModulesSize 200 MB 200 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary finn-orsini/next.js pin_eslint_7_sorsini Change
/ failed reqs 0 0
/ total time (seconds) 3.589 3.557 -0.03
/ avg req/sec 696.56 702.77 +6.21
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.885 1.937 ⚠️ +0.05
/error-in-render avg req/sec 1326.32 1290.69 ⚠️ -35.63
Client Bundles (main, webpack, commons)
vercel/next.js canary finn-orsini/next.js pin_eslint_7_sorsini Change
675-HASH.js gzip 13.8 kB 13.8 kB
770.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 50.7 kB 50.7 kB
main-HASH.js gzip 35 kB 35 kB
webpack-HASH.js gzip 1.64 kB 1.64 kB
Overall change 101 kB 101 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary finn-orsini/next.js pin_eslint_7_sorsini Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary finn-orsini/next.js pin_eslint_7_sorsini Change
_app-HASH.js gzip 1.33 kB 1.33 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 315 B 315 B
css-HASH.js gzip 331 B 331 B
dynamic-HASH.js gzip 2.79 kB 2.79 kB
head-HASH.js gzip 355 B 355 B
hooks-HASH.js gzip 637 B 637 B
image-HASH.js gzip 555 B 555 B
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.22 kB 2.22 kB
routerDirect..HASH.js gzip 326 B 326 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 322 B 322 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 10.1 kB 10.1 kB
Client Build Manifests
vercel/next.js canary finn-orsini/next.js pin_eslint_7_sorsini Change
_buildManifest.js gzip 511 B 511 B
Overall change 511 B 511 B
Rendered Page Sizes
vercel/next.js canary finn-orsini/next.js pin_eslint_7_sorsini Change
index.html gzip 537 B 537 B
link.html gzip 551 B 551 B
withRouter.html gzip 532 B 532 B
Overall change 1.62 kB 1.62 kB
Commit: 70a7d1c

@kodiakhq kodiakhq bot merged commit c78d8fa into vercel:canary Oct 12, 2021
@sicarius97
Copy link
Contributor

@finn-orsini @timneutkens So I believe this worked great for initially scaffolding a project via either npx or yarn dlx create-next-app, but I believe it is still pinning 8 when using yarn 2's yarn create next-app

@sicarius97
Copy link
Contributor

Actually I pulled the latest today, and scaffolding using both yarn dlx create-next-app and yarn create next-app is pinning eslint 8.1, effectively still breaking the next lint cli command

@finn-orsini
Copy link
Contributor Author

🤔

This is working for me locally using npx create-next-app@latest and yarn create next-app. I imagine it wasn't working for a bit because a new release had not yet been cut - but with the recent release of v12, the published version is pinning correctly again.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
@finn-orsini finn-orsini deleted the pin_eslint_7_sorsini branch January 31, 2022 19:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

yarn create next-app --ts sets wrong eslint version
5 participants