Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move outputFileTracing config up #30295

Merged
merged 7 commits into from Oct 26, 2021
Merged

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Oct 26, 2021

This moves the outputFileTracing config up.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

packages/next/server/config.ts Outdated Show resolved Hide resolved
@ijjk ijjk requested a review from styfle October 26, 2021 03:28
styfle
styfle previously approved these changes Oct 26, 2021
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member Author

ijjk commented Oct 26, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js move/output-tracing-config Change
buildDuration 21.5s 22.3s ⚠️ +776ms
buildDurationCached 4.2s 4.2s ⚠️ +7ms
nodeModulesSize 198 MB 198 MB -726 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js move/output-tracing-config Change
/ failed reqs 0 0
/ total time (seconds) 3.772 3.843 ⚠️ +0.07
/ avg req/sec 662.75 650.46 ⚠️ -12.29
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.94 2.027 ⚠️ +0.09
/error-in-render avg req/sec 1288.41 1233.15 ⚠️ -55.26
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js move/output-tracing-config Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.7 kB 27.7 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js move/output-tracing-config Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js move/output-tracing-config Change
_app-HASH.js gzip 1.23 kB 1.23 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js move/output-tracing-config Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js move/output-tracing-config Change
index.html gzip 533 B 533 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js move/output-tracing-config Change
buildDuration 18.1s 18.3s ⚠️ +113ms
buildDurationCached 4.4s 4.3s -84ms
nodeModulesSize 198 MB 198 MB -726 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js move/output-tracing-config Change
/ failed reqs 0 0
/ total time (seconds) 3.797 3.709 -0.09
/ avg req/sec 658.39 674.06 +15.67
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.076 2.004 -0.07
/error-in-render avg req/sec 1204.33 1247.75 +43.42
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js move/output-tracing-config Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.8 kB 27.8 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js move/output-tracing-config Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js move/output-tracing-config Change
_app-HASH.js gzip 1.22 kB 1.22 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 621 B 621 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.9 kB 1.9 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js move/output-tracing-config Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js move/output-tracing-config Change
index.html gzip 534 B 534 B
link.html gzip 546 B 546 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB
Commit: 9b1dea6

@ijjk ijjk merged commit 9eceb95 into vercel:canary Oct 26, 2021
40 checks passed
@ijjk ijjk deleted the move/output-tracing-config branch October 26, 2021 04:22
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants