Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix included flight manifest on node runtime #34113

Merged
merged 6 commits into from
Feb 9, 2022

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Feb 8, 2022

We need to switch to json flight manifest on node deployment for RSC

shuding
shuding previously approved these changes Feb 8, 2022
ijjk
ijjk previously approved these changes Feb 8, 2022
@ijjk

This comment has been minimized.

@huozhi huozhi dismissed stale reviews from ijjk and shuding via ed8bc03 February 8, 2022 23:53
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Feb 9, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js fix/rsc-node-manifest Change
buildDuration 15.1s 15s -85ms
buildDurationCached 5.9s 6s ⚠️ +99ms
nodeModulesSize 359 MB 359 MB ⚠️ +60 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js fix/rsc-node-manifest Change
/ failed reqs 0 0
/ total time (seconds) 2.96 2.947 -0.01
/ avg req/sec 844.48 848.34 +3.86
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.166 1.203 ⚠️ +0.04
/error-in-render avg req/sec 2143.78 2078.04 ⚠️ -65.74
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js fix/rsc-node-manifest Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js fix/rsc-node-manifest Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js fix/rsc-node-manifest Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.01 kB 5.01 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js fix/rsc-node-manifest Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js fix/rsc-node-manifest Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js fix/rsc-node-manifest Change
buildDuration 18.8s 18.8s -7ms
buildDurationCached 6s 5.9s -107ms
nodeModulesSize 359 MB 359 MB ⚠️ +60 B
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js fix/rsc-node-manifest Change
/ failed reqs 0 0
/ total time (seconds) 3.022 2.962 -0.06
/ avg req/sec 827.29 843.97 +16.68
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.216 1.185 -0.03
/error-in-render avg req/sec 2056.25 2108.82 +52.57
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js fix/rsc-node-manifest Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js fix/rsc-node-manifest Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js fix/rsc-node-manifest Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js fix/rsc-node-manifest Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js fix/rsc-node-manifest Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB
Commit: b3872b4

@kodiakhq kodiakhq bot merged commit 0f5d9dc into vercel:canary Feb 9, 2022
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
We need to switch to json flight manifest on node deployment for RSC
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2022
@huozhi huozhi deleted the fix/rsc-node-manifest branch May 11, 2022 22:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants