Set __NEXT_NEW_LINK_BEHAVIOR in Jest tests when newNextLinkBehavior is true
#40702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerAberbach
requested review from
timneutkens,
ijjk,
shuding,
padmaia and
huozhi
as code owners
timneutkens
previously requested changes
Sep 20, 2022
|
This is some awesome news @TomerAberbach :) thank you so much for looking into this, much appreciated! |
No problem! I probably should have mentioned, in the meantime you should be able to work around the issue by manually setting the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40463
Could use some help figuring out where to add a test! I looked around and found
jest-next-swc.test.ts, but I don't think I can use that to test this fix. Anyways, from my local testing this PR seems to fix the issue.