Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support viewport export via TS Plugin #57554

Merged
merged 10 commits into from
Oct 30, 2023

Conversation

Vinlock
Copy link
Contributor

@Vinlock Vinlock commented Oct 27, 2023

What?

The Next.js TS Plugin generally supports the named exports for the pages and layouts.
Currently the TS Plugin doesn't support the new viewport export.

See: https://nextjs.org/docs/app/building-your-application/upgrading/codemods#use-viewport-export

How?

Added the viewport export to the constants.ts.

Closes #57680

@Vinlock Vinlock changed the title Support viewport export Support viewport export via TS Plugin Oct 27, 2023
@Vinlock
Copy link
Contributor Author

Vinlock commented Oct 27, 2023

Let me know if I'm missing any additional requirements to get the PR merged! Thanks!

@huozhi huozhi added the CI approved Approve running CI for fork label Oct 27, 2023
@ijjk
Copy link
Member

ijjk commented Oct 27, 2023

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary Vinlock/next.js support-viewport-export Change
buildDuration 10.3s 10.2s N/A
buildDurationCached 6.1s 6s N/A
nodeModulesSize 175 MB 175 MB ⚠️ +200 B
nextStartRea..uration (ms) 422ms 413ms N/A
Client Bundles (main, webpack)
vercel/next.js canary Vinlock/next.js support-viewport-export Change
199-HASH.js gzip 32.3 kB 32.4 kB N/A
3f784ff6-HASH.js gzip 53.2 kB 53.2 kB
99.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.5 kB 45.5 kB
main-app-HASH.js gzip 254 B 252 B N/A
main-HASH.js gzip 35.3 kB 35.4 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 98.9 kB 98.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Vinlock/next.js support-viewport-export Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary Vinlock/next.js support-viewport-export Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.59 kB 2.59 kB
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.38 kB 4.38 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 316 B 318 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 319 B 319 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.99 kB 3.99 kB
Client Build Manifests
vercel/next.js canary Vinlock/next.js support-viewport-export Change
_buildManifest.js gzip 484 B 482 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary Vinlock/next.js support-viewport-export Change
index.html gzip 529 B 529 B
link.html gzip 543 B 542 B N/A
withRouter.html gzip 524 B 524 B
Overall change 1.05 kB 1.05 kB
Edge SSR bundle Size
vercel/next.js canary Vinlock/next.js support-viewport-export Change
edge-ssr.js gzip 96.1 kB 96.1 kB N/A
page.js gzip 140 kB 140 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary Vinlock/next.js support-viewport-export Change
middleware-b..fest.js gzip 625 B 623 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 25.8 kB 25.8 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Commit: 5e5d644

Copy link

@boxman0617 boxman0617 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@joulev joulev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you maybe merge from canary to trigger a new CI so the bot can merge this PR?

@huozhi
Copy link
Member

huozhi commented Oct 30, 2023

Thanks for the fix!

@kodiakhq kodiakhq bot merged commit 24a71dc into vercel:canary Oct 30, 2023
51 of 56 checks passed
@davegomez
Copy link
Contributor

@Vinlock I updated to canary and checked the code is there, but I'm still getting the type error.

typescript-error

@joulev
Copy link
Contributor

joulev commented Oct 31, 2023

@davegomez You have a typo. It’s viewport not viewpor.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI approved Approve running CI for fork locked type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meta theme-color is missing in the html, while meta viewport value is incorrect
6 participants