initial work for compile-time evaluation #3495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 10 Ignored Deployments
|
Benchmark for 178ea44Click to view benchmark
|
|
sokra
requested review from
mehulkar,
chris-olszewski,
alexkirsz and
jridgewell
Benchmark for de0f2d5
Click to view full benchmark
|
alexkirsz
reviewed
Jan 27, 2023
| require("fail"); | ||
| import("fail"); | ||
| } | ||
| }); |
There was a problem hiding this comment.
Add a test that verifies the error case as well.
There was a problem hiding this comment.
What do you mean with the error case?
I added a check if it runs through the "then" branch. Is that enough?
There was a problem hiding this comment.
The error case is when require("fail") or import("fail") fail to compile. Do we have a test case for this?
Benchmark for 4a91ae7
Click to view full benchmark
|
|
x-ref: #3347 |
Benchmark for 840f922
Click to view full benchmark
|
Benchmark for 906ada4
Click to view full benchmark
|
Benchmark for ecd6823
Click to view full benchmark
|
|
Do any other bundlers have a specific value dedicated to detecting them? ( |
Benchmark for 1501f94
Click to view full benchmark
|
Not as far as I know. |
alexkirsz
suggested changes
Feb 3, 2023
crates/next-dev-tests/tests/integration/turbopack/basic/comptime/index.js
Outdated
Show resolved
Hide resolved
| } | ||
| _ => false, | ||
| }, | ||
| JsValue::MemberCall(_, box ref mut obj, box ref mut prop, _) => match obj { |
There was a problem hiding this comment.
It would be good to name these members (struct-like variant vs. tuple-like variant). There's a possibility to confuse prop and obj otherwise.
There was a problem hiding this comment.
Yeah, but that's something for a follow-up PR
| /// Checks if we known that the value ends with a given string. Returns | ||
| /// None if we don't know. Returns Some if we know if or if not the | ||
| /// value ends with the given string. | ||
| pub fn ends_with(&self, str: &str) -> Option<bool> { |
There was a problem hiding this comment.
Might be good to give an example of why this particular function is needed too.
Benchmark for 5a967cf
Click to view full benchmark
|
alexkirsz
approved these changes
Feb 3, 2023
Benchmark for ae45cde
Click to view full benchmark
|
mehulkar
pushed a commit
that referenced
this pull request
Feb 3, 2023
Allows to skip unreachable code based on compile-time constant
conditions
e. g.
```
if (!process.turbopack) {
require("will-not-be-processed");
}
```
* add if() and process.turbopack fixes WEB-491
* Removes unreachable code fixes WEB-498
* evaluate some logical operations `&&`, `||`, `??`, `!`
* fix arguments handling fixes WEB-529
* nested effects for function called with closures
* handle closures when array methods are used fixes WEB-538
* evaluates `process.turbopack` fixes WEB-496
timneutkens
pushed a commit
to vercel/next.js
that referenced
this pull request
Feb 10, 2023
…49736102+kodiakhq[bot]@users.noreply.github.com> # New Features - vercel/turborepo#3540 - vercel/turborepo#3549 - vercel/turborepo#3465 - vercel/turborepo#3550 - vercel/turborepo#3495 - vercel/turborepo#3624 - vercel/turborepo#3600 - vercel/turborepo#3676 - vercel/turborepo#3689 # Fixes - vercel/turborepo#3437 - vercel/turborepo#3542 - vercel/turborepo#3531 - vercel/turborepo#3552 - vercel/turborepo#3551 - vercel/turborepo#3597 - vercel/turborepo#3644 - vercel/turborepo#3623 - vercel/turborepo#3634 - vercel/turborepo#3574 - vercel/turborepo#3673 - vercel/turborepo#3675 - vercel/turborepo#3723 - vercel/turborepo#3677 - vercel/turborepo#3717 - vercel/turborepo#3701 # Performance Improvements - vercel/turborepo#3361 - vercel/turborepo#3619 --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
jridgewell
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
Allows to skip unreachable code based on compile-time constant
conditions
e. g.
```
if (!process.turbopack) {
require("will-not-be-processed");
}
```
* add if() and process.turbopack fixes WEB-491
* Removes unreachable code fixes WEB-498
* evaluate some logical operations `&&`, `||`, `??`, `!`
* fix arguments handling fixes WEB-529
* nested effects for function called with closures
* handle closures when array methods are used fixes WEB-538
* evaluates `process.turbopack` fixes WEB-496
sokra
added a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
Allows to skip unreachable code based on compile-time constant
conditions
e. g.
```
if (!process.turbopack) {
require("will-not-be-processed");
}
```
* add if() and process.turbopack fixes WEB-491
* Removes unreachable code fixes WEB-498
* evaluate some logical operations `&&`, `||`, `??`, `!`
* fix arguments handling fixes WEB-529
* nested effects for function called with closures
* handle closures when array methods are used fixes WEB-538
* evaluates `process.turbopack` fixes WEB-496
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
Allows to skip unreachable code based on compile-time constant
conditions
e. g.
```
if (!process.turbopack) {
require("will-not-be-processed");
}
```
* add if() and process.turbopack fixes WEB-491
* Removes unreachable code fixes WEB-498
* evaluate some logical operations `&&`, `||`, `??`, `!`
* fix arguments handling fixes WEB-529
* nested effects for function called with closures
* handle closures when array methods are used fixes WEB-538
* evaluates `process.turbopack` fixes WEB-496
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
Allows to skip unreachable code based on compile-time constant
conditions
e. g.
```
if (!process.turbopack) {
require("will-not-be-processed");
}
```
* add if() and process.turbopack fixes WEB-491
* Removes unreachable code fixes WEB-498
* evaluate some logical operations `&&`, `||`, `??`, `!`
* fix arguments handling fixes WEB-529
* nested effects for function called with closures
* handle closures when array methods are used fixes WEB-538
* evaluates `process.turbopack` fixes WEB-496
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
Allows to skip unreachable code based on compile-time constant
conditions
e. g.
```
if (!process.turbopack) {
require("will-not-be-processed");
}
```
* add if() and process.turbopack fixes WEB-491
* Removes unreachable code fixes WEB-498
* evaluate some logical operations `&&`, `||`, `??`, `!`
* fix arguments handling fixes WEB-529
* nested effects for function called with closures
* handle closures when array methods are used fixes WEB-538
* evaluates `process.turbopack` fixes WEB-496
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to skip unreachable code based on compile-time constant conditions
e. g.
&&,||,??,!process.turbopackfixes WEB-496