Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for getStaticPaths.fallback = false #3600

Merged
merged 2 commits into from
Feb 6, 2023

Conversation

alexkirsz
Copy link
Contributor

Adds support for getStaticPaths returning { fallback: false } by building out all static paths and checking whether the resolved path is included in that list.

buildStaticPaths requires the next.config.js path, as well as other config options such as locale. I created WEB-546 to track being able to pass them to the handlers.

@alexkirsz alexkirsz requested a review from a team as a code owner February 2, 2023 13:28
@vercel
Copy link

vercel bot commented Feb 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
examples-basic-web 🔄 Building (Inspect) Feb 3, 2023 at 11:19AM (UTC)
examples-svelte-web 🔄 Building (Inspect) Feb 3, 2023 at 11:19AM (UTC)
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 3, 2023 at 11:19AM (UTC)
7 Ignored Deployments
Name Status Preview Comments Updated
examples-cra-web ⬜️ Ignored (Inspect) Feb 3, 2023 at 11:19AM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Feb 3, 2023 at 11:19AM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Feb 3, 2023 at 11:19AM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Feb 3, 2023 at 11:19AM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Feb 3, 2023 at 11:19AM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Feb 3, 2023 at 11:19AM (UTC)
examples-vite-web ⬜️ Ignored (Inspect) Feb 3, 2023 at 11:19AM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

Benchmark for 26476ba

Test Base PR % Significant %
bench_startup/Turbopack SSR/1000 modules 2129.27ms ± 7.85ms 2202.10ms ± 7.09ms +3.42% +2.00%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9909.66µs ± 86.02µs 9930.93µs ± 71.51µs +0.21%
bench_hmr_to_commit/Turbopack RCC/1000 modules 10.18ms ± 0.08ms 10.20ms ± 0.08ms +0.22%
bench_hmr_to_commit/Turbopack RSC/1000 modules 513.93ms ± 4.33ms 512.74ms ± 2.46ms -0.23%
bench_hmr_to_commit/Turbopack SSR/1000 modules 10.12ms ± 0.10ms 10.08ms ± 0.08ms -0.46%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8953.65µs ± 73.40µs 8886.36µs ± 59.68µs -0.75%
bench_hmr_to_eval/Turbopack RCC/1000 modules 9110.77µs ± 82.75µs 9212.82µs ± 91.88µs +1.12%
bench_hmr_to_eval/Turbopack SSR/1000 modules 9038.44µs ± 66.01µs 9068.19µs ± 93.83µs +0.33%
bench_hydration/Turbopack RCC/1000 modules 3994.92ms ± 15.67ms 3970.66ms ± 13.33ms -0.61%
bench_hydration/Turbopack RSC/1000 modules 3494.82ms ± 9.82ms 3485.48ms ± 11.38ms -0.27%
bench_hydration/Turbopack SSR/1000 modules 3235.35ms ± 16.49ms 3275.69ms ± 9.22ms +1.25%
bench_startup/Turbopack CSR/1000 modules 2170.39ms ± 9.02ms 2178.59ms ± 9.22ms +0.38%
bench_startup/Turbopack RCC/1000 modules 2663.48ms ± 9.63ms 2648.92ms ± 8.09ms -0.55%
bench_startup/Turbopack RSC/1000 modules 2526.99ms ± 7.29ms 2536.15ms ± 5.03ms +0.36%
bench_startup/Turbopack SSR/1000 modules 2129.27ms ± 7.85ms 2202.10ms ± 7.09ms +3.42% +2.00%

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests

See workflow summary for details

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

Benchmark for 2aa0225

Test Base PR % Significant %
bench_startup/Turbopack SSR/1000 modules 2330.31ms ± 6.78ms 2481.37ms ± 7.30ms +6.48% +5.24%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 10.02ms ± 0.08ms 9910.22µs ± 88.54µs -1.07%
bench_hmr_to_commit/Turbopack RCC/1000 modules 10.09ms ± 0.07ms 10.27ms ± 0.06ms +1.83%
bench_hmr_to_commit/Turbopack RSC/1000 modules 502.74ms ± 1.37ms 507.38ms ± 2.11ms +0.92%
bench_hmr_to_commit/Turbopack SSR/1000 modules 10.21ms ± 0.10ms 10.01ms ± 0.11ms -2.03%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8779.45µs ± 75.12µs 8776.22µs ± 88.93µs -0.04%
bench_hmr_to_eval/Turbopack RCC/1000 modules 9225.29µs ± 82.27µs 9289.18µs ± 86.06µs +0.69%
bench_hmr_to_eval/Turbopack SSR/1000 modules 8894.07µs ± 66.44µs 8883.68µs ± 95.17µs -0.12%
bench_hydration/Turbopack RCC/1000 modules 4496.06ms ± 37.91ms 4421.10ms ± 27.05ms -1.67%
bench_hydration/Turbopack RSC/1000 modules 4074.18ms ± 15.66ms 4017.07ms ± 13.50ms -1.40%
bench_hydration/Turbopack SSR/1000 modules 3751.69ms ± 33.45ms 3852.69ms ± 33.57ms +2.69%
bench_startup/Turbopack CSR/1000 modules 2790.26ms ± 11.82ms 2815.01ms ± 12.61ms +0.89%
bench_startup/Turbopack RCC/1000 modules 2877.25ms ± 7.60ms 2896.72ms ± 11.79ms +0.68%
bench_startup/Turbopack RSC/1000 modules 2788.46ms ± 10.45ms 2804.09ms ± 8.75ms +0.56%
bench_startup/Turbopack SSR/1000 modules 2330.31ms ± 6.78ms 2481.37ms ± 7.30ms +6.48% +5.24%

@alexkirsz alexkirsz merged commit 4e5c187 into main Feb 6, 2023
@alexkirsz alexkirsz deleted the alexkirsz/web-461-handle-404-pages-when branch February 6, 2023 08:56
jridgewell pushed a commit to vercel/next.js that referenced this pull request Mar 10, 2023
Adds support for `getStaticPaths` returning `{ fallback: false }` by
building out all static paths and checking whether the resolved path is
included in that list.

`buildStaticPaths` requires the `next.config.js` path, as well as other
config options such as locale. I created WEB-546 to track being able to
pass them to the handlers.
sokra pushed a commit to vercel/next.js that referenced this pull request Mar 13, 2023
Adds support for `getStaticPaths` returning `{ fallback: false }` by
building out all static paths and checking whether the resolved path is
included in that list.

`buildStaticPaths` requires the `next.config.js` path, as well as other
config options such as locale. I created WEB-546 to track being able to
pass them to the handlers.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
Adds support for `getStaticPaths` returning `{ fallback: false }` by
building out all static paths and checking whether the resolved path is
included in that list.

`buildStaticPaths` requires the `next.config.js` path, as well as other
config options such as locale. I created WEB-546 to track being able to
pass them to the handlers.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
Adds support for `getStaticPaths` returning `{ fallback: false }` by
building out all static paths and checking whether the resolved path is
included in that list.

`buildStaticPaths` requires the `next.config.js` path, as well as other
config options such as locale. I created WEB-546 to track being able to
pass them to the handlers.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
Adds support for `getStaticPaths` returning `{ fallback: false }` by
building out all static paths and checking whether the resolved path is
included in that list.

`buildStaticPaths` requires the `next.config.js` path, as well as other
config options such as locale. I created WEB-546 to track being able to
pass them to the handlers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants