Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine next.config.js Turbopack options into a nested object #3689

Merged
merged 2 commits into from
Feb 9, 2023
Merged

Combine next.config.js Turbopack options into a nested object #3689

merged 2 commits into from
Feb 9, 2023

Conversation

wbinnssmith
Copy link
Member

This combines Turbopack-specific options into a nested object experimental.turbopack, exposing loaders and resolveAlias properties.

x-ref: https://github.com/vercel/next.js/pull/45560/files/631b637f42757e20aabe84dc933527dc66b55173#r1098123643

Test Plan: Integration tests for loaders and resolveAlias.

@wbinnssmith
Combine next.config.js Turbopack options into a nested object
69de1e1 
This combines Turbopack-specific options into a nested object `experimental.turbopack`, exposing `loaders` and `resolveAlias` properties.

x-ref: https://github.com/vercel/next.js/pull/45560/files/631b637f42757e20aabe84dc933527dc66b55173#r1098123643

Test Plan: Integration tests for loaders and resolveAlias.
@wbinnssmith wbinnssmith requested a review from a team as a code owner February 8, 2023 01:14
@turbo-orchestrator turbo-orchestrator bot added area: docs Improvements or additions to documentation team: turbopack labels Feb 8, 2023
@vercel
Copy link

vercel bot commented Feb 8, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
examples-nonmonorepo 🔄 Building (Inspect) Feb 8, 2023 at 6:06PM (UTC)
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 8, 2023 at 6:06PM (UTC)
8 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Feb 8, 2023 at 6:06PM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Feb 8, 2023 at 6:06PM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Feb 8, 2023 at 6:06PM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Feb 8, 2023 at 6:06PM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Feb 8, 2023 at 6:06PM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Feb 8, 2023 at 6:06PM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Feb 8, 2023 at 6:06PM (UTC)
examples-vite-web ⬜️ Ignored (Inspect) Feb 8, 2023 at 6:06PM (UTC)

kwonoj
kwonoj approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@kwonoj kwonoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: if config have experimental.turbopack, does it automatically enables --turbo or it is still manual thing?

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)
  • Turbopack Rust PR benchmarks (non-blocking)

See workflow summary for details

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

Benchmark for 9f39b93

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9218.15µs ± 79.79µs 9240.75µs ± 84.84µs +0.25%
bench_hmr_to_commit/Turbopack RCC/1000 modules 9484.80µs ± 75.17µs 9463.89µs ± 59.16µs -0.22%
bench_hmr_to_commit/Turbopack RSC/1000 modules 507.60ms ± 3.54ms 507.41ms ± 1.66ms -0.04%
bench_hmr_to_commit/Turbopack SSR/1000 modules 9439.59µs ± 54.49µs 9410.86µs ± 103.22µs -0.30%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8227.12µs ± 48.29µs 8273.64µs ± 57.54µs +0.57%
bench_hmr_to_eval/Turbopack RCC/1000 modules 8522.52µs ± 71.37µs 8455.35µs ± 66.49µs -0.79%
bench_hmr_to_eval/Turbopack SSR/1000 modules 8438.17µs ± 53.81µs 8410.83µs ± 91.54µs -0.32%
bench_hydration/Turbopack RCC/1000 modules 4267.17ms ± 10.67ms 4253.37ms ± 11.77ms -0.32%
bench_hydration/Turbopack RSC/1000 modules 3865.46ms ± 21.71ms 3827.93ms ± 24.65ms -0.97%
bench_hydration/Turbopack SSR/1000 modules 3698.23ms ± 21.64ms 3723.59ms ± 16.14ms +0.69%
bench_startup/Turbopack CSR/1000 modules 2843.10ms ± 11.63ms 2827.11ms ± 12.72ms -0.56%
bench_startup/Turbopack RCC/1000 modules 2574.89ms ± 6.86ms 2565.51ms ± 4.31ms -0.36%
bench_startup/Turbopack RSC/1000 modules 2463.98ms ± 8.72ms 2460.08ms ± 6.76ms -0.16%
bench_startup/Turbopack SSR/1000 modules 2134.35ms ± 2.45ms 2131.40ms ± 3.23ms -0.14%

@alexkirsz
Copy link
Contributor

q: if config have experimental.turbopack, does it automatically enables --turbo or it is still manual thing?

For gradual adoption, I think we'll want to allow people to have both a normal config and a turbopack config side-by-side. In which case --turbo should still be opt-in.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

Benchmark for c006611

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8653.62µs ± 115.82µs 8714.53µs ± 80.96µs +0.70%
bench_hmr_to_commit/Turbopack RCC/1000 modules 8930.85µs ± 89.54µs 8976.86µs ± 97.71µs +0.52%
bench_hmr_to_commit/Turbopack RSC/1000 modules 475.97ms ± 1.10ms 480.95ms ± 2.14ms +1.05%
bench_hmr_to_commit/Turbopack SSR/1000 modules 8897.56µs ± 100.28µs 8874.02µs ± 69.98µs -0.26%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7670.16µs ± 74.43µs 7746.30µs ± 53.61µs +0.99%
bench_hmr_to_eval/Turbopack RCC/1000 modules 7959.58µs ± 68.29µs 8034.75µs ± 84.03µs +0.94%
bench_hmr_to_eval/Turbopack SSR/1000 modules 7956.22µs ± 83.04µs 7885.57µs ± 49.92µs -0.89%
bench_hydration/Turbopack RCC/1000 modules 4151.94ms ± 10.53ms 4128.63ms ± 12.27ms -0.56%
bench_hydration/Turbopack RSC/1000 modules 3747.98ms ± 15.41ms 3758.10ms ± 18.57ms +0.27%
bench_hydration/Turbopack SSR/1000 modules 3602.74ms ± 25.44ms 3592.40ms ± 20.63ms -0.29%
bench_startup/Turbopack CSR/1000 modules 2742.84ms ± 8.49ms 2749.51ms ± 16.14ms +0.24%
bench_startup/Turbopack RCC/1000 modules 2502.47ms ± 7.43ms 2505.61ms ± 6.39ms +0.13%
bench_startup/Turbopack RSC/1000 modules 2384.81ms ± 9.12ms 2411.25ms ± 8.73ms +1.11%
bench_startup/Turbopack SSR/1000 modules 2070.12ms ± 4.29ms 2070.23ms ± 2.32ms +0.01%

@wbinnssmith wbinnssmith merged commit 774d0dd into main Feb 9, 2023
@wbinnssmith wbinnssmith deleted the wbinnssmith/nest-turbopack-options branch February 9, 2023 00:25
@jridgewell jridgewell mentioned this pull request Feb 10, 2023
Merged
timneutkens pushed a commit to vercel/next.js that referenced this pull request Feb 10, 2023
@Brooooooklyn @kodiakhq
Update turbopack to 230209.02 (#45776)Co-authored-by: kodiakhq[bot] <…
946ccb0 
…49736102+kodiakhq[bot]@users.noreply.github.com>

# New Features
- vercel/turborepo#3540
- vercel/turborepo#3549
- vercel/turborepo#3465
- vercel/turborepo#3550
- vercel/turborepo#3495
- vercel/turborepo#3624
- vercel/turborepo#3600
- vercel/turborepo#3676
- vercel/turborepo#3689

# Fixes

- vercel/turborepo#3437
- vercel/turborepo#3542
- vercel/turborepo#3531
- vercel/turborepo#3552
- vercel/turborepo#3551
- vercel/turborepo#3597
- vercel/turborepo#3644
- vercel/turborepo#3623
- vercel/turborepo#3634
- vercel/turborepo#3574
- vercel/turborepo#3673
- vercel/turborepo#3675
- vercel/turborepo#3723
- vercel/turborepo#3677
- vercel/turborepo#3717
- vercel/turborepo#3701

# Performance Improvements

- vercel/turborepo#3361 
- vercel/turborepo#3619

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
jridgewell pushed a commit to vercel/next.js that referenced this pull request Mar 10, 2023
@wbinnssmith
Combine next.config.js Turbopack options into a nested object (vercel…
0187e3f 
…/turborepo#3689)

This combines Turbopack-specific options into a nested object
`experimental.turbopack`, exposing `loaders` and `resolveAlias`
properties.

x-ref:
https://github.com/vercel/next.js/pull/45560/files/631b637f42757e20aabe84dc933527dc66b55173#r1098123643

Test Plan: Integration tests for loaders and resolveAlias.
sokra pushed a commit to vercel/next.js that referenced this pull request Mar 13, 2023
@wbinnssmith
Combine next.config.js Turbopack options into a nested object (vercel…
1197edc 
…/turborepo#3689)

This combines Turbopack-specific options into a nested object
`experimental.turbopack`, exposing `loaders` and `resolveAlias`
properties.

x-ref:
https://github.com/vercel/next.js/pull/45560/files/631b637f42757e20aabe84dc933527dc66b55173#r1098123643

Test Plan: Integration tests for loaders and resolveAlias.
@DuCanhGH DuCanhGH mentioned this pull request Mar 15, 2023
Merged
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@wbinnssmith
Combine next.config.js Turbopack options into a nested object (vercel…
5c2f452 
…/turborepo#3689)

This combines Turbopack-specific options into a nested object
`experimental.turbopack`, exposing `loaders` and `resolveAlias`
properties.

x-ref:
https://github.com/vercel/next.js/pull/45560/files/631b637f42757e20aabe84dc933527dc66b55173#r1098123643

Test Plan: Integration tests for loaders and resolveAlias.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@wbinnssmith
Combine next.config.js Turbopack options into a nested object (vercel…
11382b6 
…/turborepo#3689)

This combines Turbopack-specific options into a nested object
`experimental.turbopack`, exposing `loaders` and `resolveAlias`
properties.

x-ref:
https://github.com/vercel/next.js/pull/45560/files/631b637f42757e20aabe84dc933527dc66b55173#r1098123643

Test Plan: Integration tests for loaders and resolveAlias.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@wbinnssmith
Combine next.config.js Turbopack options into a nested object (vercel…
448a1af 
…/turborepo#3689)

This combines Turbopack-specific options into a nested object
`experimental.turbopack`, exposing `loaders` and `resolveAlias`
properties.

x-ref:
https://github.com/vercel/next.js/pull/45560/files/631b637f42757e20aabe84dc933527dc66b55173#r1098123643

Test Plan: Integration tests for loaders and resolveAlias.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwonoj kwonoj kwonoj approved these changes

Assignees
No one assigned
Labels
area: docs Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wbinnssmith @alexkirsz @kwonoj