Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make error overlay message scrollable #3861

Merged

Conversation

ForsakenHarmony
Copy link
Member

@ForsakenHarmony ForsakenHarmony commented Feb 17, 2023

Before long messages would just be hidden:

@vercel
Copy link

vercel bot commented Feb 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
examples-designsystem-docs 🔄 Building (Inspect) Feb 17, 2023 at 4:07PM (UTC)
examples-tailwind-web 🔄 Building (Inspect) Feb 17, 2023 at 4:07PM (UTC)
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 17, 2023 at 4:07PM (UTC)
7 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Feb 17, 2023 at 4:07PM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Feb 17, 2023 at 4:07PM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Feb 17, 2023 at 4:07PM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Feb 17, 2023 at 4:07PM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Feb 17, 2023 at 4:07PM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Feb 17, 2023 at 4:07PM (UTC)
examples-vite-web ⬜️ Ignored (Inspect) Feb 17, 2023 at 4:07PM (UTC)

@ForsakenHarmony
Copy link
Member Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@ForsakenHarmony ForsakenHarmony enabled auto-merge (squash) February 17, 2023 16:22
@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2023

🟢 CI successful 🟢

Thanks

@ForsakenHarmony ForsakenHarmony merged commit 7ec99c8 into main Feb 17, 2023
@ForsakenHarmony ForsakenHarmony deleted the hrmny/web-572-make-error-overlay-message-scrollable branch February 17, 2023 16:23
@github-actions
Copy link
Contributor

Benchmark for fc8f14e

Test Base PR % Significant %
bench_hmr_to_commit/Turbopack RSC/1000 modules 510.50ms ± 1.98ms 499.94ms ± 1.41ms -2.07% -0.74%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9290.08µs ± 74.87µs 9238.40µs ± 96.72µs -0.56%
bench_hmr_to_commit/Turbopack RCC/1000 modules 11.97ms ± 0.26ms 12.38ms ± 0.16ms +3.48%
bench_hmr_to_commit/Turbopack RSC/1000 modules 510.50ms ± 1.98ms 499.94ms ± 1.41ms -2.07% -0.74%
bench_hmr_to_commit/Turbopack SSR/1000 modules 9380.80µs ± 94.56µs 9439.00µs ± 48.26µs +0.62%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8425.97µs ± 91.36µs 8262.53µs ± 78.92µs -1.94%
bench_hmr_to_eval/Turbopack RCC/1000 modules 11.08ms ± 0.37ms 10.76ms ± 0.19ms -2.92%
bench_hmr_to_eval/Turbopack SSR/1000 modules 8432.79µs ± 67.59µs 8418.27µs ± 63.35µs -0.17%
bench_hydration/Turbopack RCC/1000 modules 3699.08ms ± 23.86ms 3654.26ms ± 13.42ms -1.21%
bench_hydration/Turbopack RSC/1000 modules 3324.55ms ± 8.63ms 3347.64ms ± 9.10ms +0.69%
bench_hydration/Turbopack SSR/1000 modules 3405.87ms ± 8.84ms 3394.65ms ± 15.67ms -0.33%
bench_startup/Turbopack CSR/1000 modules 2681.48ms ± 9.37ms 2670.18ms ± 9.03ms -0.42%
bench_startup/Turbopack RCC/1000 modules 2257.76ms ± 2.55ms 2260.80ms ± 3.51ms +0.13%
bench_startup/Turbopack RSC/1000 modules 2188.39ms ± 4.63ms 2190.75ms ± 5.82ms +0.11%
bench_startup/Turbopack SSR/1000 modules 2067.49ms ± 2.79ms 2059.85ms ± 2.40ms -0.37%

sokra added a commit to vercel/next.js that referenced this pull request Feb 21, 2023
# Performance Improvements

* improve performance of TaskScopes and collectibes ([#3849](https://github.com/vercel/turbo/pull3849/))
* fix consistency issue with reading collectibles ([#3878](vercel/turbo#3878))
* change to NoHashHasher for ID keys ([#3864](https://github.com/vercel/turbo/pull3864/))

# Bug Fixes

* strip UNC prefix on windows paths ([#3847](https://github.com/vercel/turbo/pull3847/))
* make error overlay message scrollable ([#3861](vercel/turbo#3861))
* alias @swc/helpers to the version within next.js ([#3865](https://github.com/vercel/turbo/pull3865/))
* add possible unknown mutation to objects and arrays ([#3882](vercel/turbo#3882))

# Contributing

* Update profiling instructions for macOS ([#3837](https://github.com/vercel/turbo/pull3837/))
wbinnssmith added a commit to vercel/next.js that referenced this pull request Feb 21, 2023
ijjk pushed a commit to vercel/next.js that referenced this pull request Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants