add possible unknown mutation to objects and arrays #3882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
|
Benchmark for f6c943e
Click to view full benchmark
|
sokra
force-pushed
the
sokra/web-613-compile-time-evaluation-is-too-greedy
branch
from
f294caa
to
b5b3dce
Compare
Benchmark for 45d9188Click to view benchmark
|
alexkirsz
approved these changes
Feb 21, 2023
| "[{}]", | ||
| elems | ||
| "{}[{}]", | ||
| if *mutable { "" } else { "frozen " }, |
Co-authored-by: Alex Kirszenberg <alex.kirszenberg@vercel.com>
sokra
added
the
pr: automerge
ForsakenHarmony
approved these changes
Feb 21, 2023
kodiakhq
bot
deleted the
sokra/web-613-compile-time-evaluation-is-too-greedy
branch
Benchmark for f0c120bClick to view benchmark
|
sokra
added a commit
to vercel/next.js
that referenced
this pull request
Feb 21, 2023
# Performance Improvements * improve performance of TaskScopes and collectibes ([#3849](https://github.com/vercel/turbo/pull3849/)) * fix consistency issue with reading collectibles ([#3878](vercel/turbo#3878)) * change to NoHashHasher for ID keys ([#3864](https://github.com/vercel/turbo/pull3864/)) # Bug Fixes * strip UNC prefix on windows paths ([#3847](https://github.com/vercel/turbo/pull3847/)) * make error overlay message scrollable ([#3861](vercel/turbo#3861)) * alias @swc/helpers to the version within next.js ([#3865](https://github.com/vercel/turbo/pull3865/)) * add possible unknown mutation to objects and arrays ([#3882](vercel/turbo#3882)) # Contributing * Update profiling instructions for macOS ([#3837](https://github.com/vercel/turbo/pull3837/))
ijjk
pushed a commit
to vercel/next.js
that referenced
this pull request
Feb 21, 2023
# Performance Improvements: * vercel/turbo#3849 * vercel/turbo#3878 * vercel/turbo#3864 # Misc: * vercel/turbo#3847 * vercel/turbo#3865 * vercel/turbo#3850 * vercel/turbo#3861 * vercel/turbo#3823 * vercel/turbo#3882 # Contributing * Update profiling instructions for macOS ([#3837](vercel/turbo#3837))
jridgewell
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
Before the static evaluation didn't consider the fact that objects and arrays can be mutated. So we can't just assume for sure that they have certain properties/items. Instead we add an unknown mutation alternative to handle that. This avoids `if(obj.prop)` to be replaced with `if(true)` when prop is initialized with true. It might be modified in future.
sokra
added a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
Before the static evaluation didn't consider the fact that objects and arrays can be mutated. So we can't just assume for sure that they have certain properties/items. Instead we add an unknown mutation alternative to handle that. This avoids `if(obj.prop)` to be replaced with `if(true)` when prop is initialized with true. It might be modified in future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the static evaluation didn't consider the fact that objects and arrays can be mutated. So we can't just assume for sure that they have certain properties/items. Instead we add an unknown mutation alternative to handle that.
This avoids
if(obj.prop)to be replaced withif(true)when prop is initialized with true. It might be modified in future.