Support `module_resolution: "nodenext"` #8748

mischnic · 2024-07-15T08:52:17Z

Description

Allow resolving for example ./foo.js to ./foo.ts

.js can resolve to .ts and .tsx
.mjs can resolve to .mts
.cjs can resolve to .cts

This is what tsc --traceResolution says about priority of the various possible resolution:

======== Resolving module '../libs/f.js' from '/Users/niklas/Desktop/nodenext-app/app/page.tsx'. ========
Explicitly specified module resolution kind: 'NodeNext'.
Resolving in CJS mode with conditions 'require', 'types', 'node'.
Loading module as file / folder, candidate module location '/Users/niklas/Desktop/nodenext-app/libs/f.js', target file types: TypeScript, JavaScript, Declaration.
File name '/Users/niklas/Desktop/nodenext-app/libs/f.js' has a '.js' extension - stripping it.
File '/Users/niklas/Desktop/nodenext-app/libs/f.ts' does not exist.
File '/Users/niklas/Desktop/nodenext-app/libs/f.tsx' does not exist.
File '/Users/niklas/Desktop/nodenext-app/libs/f.d.ts' does not exist.
File '/Users/niklas/Desktop/nodenext-app/libs/f.js' does not exist.
File '/Users/niklas/Desktop/nodenext-app/libs/f.jsx' does not exist.
File '/Users/niklas/Desktop/nodenext-app/libs/f.js.ts' does not exist.
File '/Users/niklas/Desktop/nodenext-app/libs/f.js.tsx' does not exist.
File '/Users/niklas/Desktop/nodenext-app/libs/f.js.d.ts' does not exist.

Testing Instructions

I also added a test case

vercel · 2024-07-15T08:52:20Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
examples-basic-web	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 25, 2024 3:22pm
examples-designsystem-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 25, 2024 3:22pm
examples-gatsby-web	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 25, 2024 3:22pm
examples-kitchensink-blog	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 25, 2024 3:22pm
examples-native-web	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 25, 2024 3:22pm
examples-nonmonorepo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 25, 2024 3:22pm
examples-svelte-web	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 25, 2024 3:22pm
examples-tailwind-web	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 25, 2024 3:22pm
examples-vite-web	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 25, 2024 3:22pm
rust-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 25, 2024 3:22pm

github-actions · 2024-07-15T08:54:25Z

🟢 Turbopack Benchmark CI successful 🟢

Thanks

github-actions · 2024-07-15T08:55:34Z

✅ This change can build next-swc

github-actions · 2024-07-15T08:59:11Z

⚠️ CI failed ⚠️

The following steps have failed in CI:

Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

crates/turbopack-core/src/resolve/mod.rs

crates/turbopack-core/src/resolve/options.rs

sokra · 2024-07-18T12:58:29Z

crates/turbopack-core/src/resolve/mod.rs

+        if options_value.enable_js_ts_rewriting {
+            let mut rewritten_path = path_pattern.clone();
+            let rewritten_path_modified =
+                rewritten_path.replace_final_constants(&|c: &RcStr| -> Option<Pattern> {


Should modify new_path

Should be outside of the if !options_value.fully_specified

One sideeffect of that approach is that is also replaces the js that was appended via extensions:

request with appended extensions:

Alternatives([ Constant("./src/foo.js"), Constant("./src/foo.js.ts"), Constant("./src/foo.js.js"), Constant("./src/foo.js.json")])

request with extensions and then the new replacement

Alternatives([ Constant("./src/foo.ts"), Constant("./src/foo.tsx"), Constant("./src/foo.js"), Constant("./src/foo.js.ts"), // <- Constant("./src/foo.js.ts"), // <- Constant("./src/foo.js.tsx"), // <- Constant("./src/foo.js.js"), Constant("./src/foo.js.json")])

But in practice, it probably doesn't make a difference

crates/turbopack-core/src/resolve/pattern.rs

…nodenext

### Description Allow resolving for example `./foo.js` to `./foo.ts` `.js` can resolve to `.ts` and `.tsx` `.mjs` can resolve to `.mts` `.cjs` can resolve to `.cts` Closes PACK-3031 This is what `tsc --traceResolution` says about priority of the various possible resolution: ``` ======== Resolving module '../libs/f.js' from '/Users/niklas/Desktop/nodenext-app/app/page.tsx'. ======== Explicitly specified module resolution kind: 'NodeNext'. Resolving in CJS mode with conditions 'require', 'types', 'node'. Loading module as file / folder, candidate module location '/Users/niklas/Desktop/nodenext-app/libs/f.js', target file types: TypeScript, JavaScript, Declaration. File name '/Users/niklas/Desktop/nodenext-app/libs/f.js' has a '.js' extension - stripping it. File '/Users/niklas/Desktop/nodenext-app/libs/f.ts' does not exist. File '/Users/niklas/Desktop/nodenext-app/libs/f.tsx' does not exist. File '/Users/niklas/Desktop/nodenext-app/libs/f.d.ts' does not exist. File '/Users/niklas/Desktop/nodenext-app/libs/f.js' does not exist. File '/Users/niklas/Desktop/nodenext-app/libs/f.jsx' does not exist. File '/Users/niklas/Desktop/nodenext-app/libs/f.js.ts' does not exist. File '/Users/niklas/Desktop/nodenext-app/libs/f.js.tsx' does not exist. File '/Users/niklas/Desktop/nodenext-app/libs/f.js.d.ts' does not exist. ``` ### Testing Instructions I also added a test case

A regression from vercel/turborepo#8748 Closes PACK-3312 Previously, it treated imports to `something.mjs` as importing `something.mts` with a fallback to `something.js`. But it should obviously instead fallback to the original extension `mjs`, which is also what tsc does: ``` Found 'package.json' at 'input/package.json'. ======== Resolving module './src/foo.mjs' from 'input/index.js'. ======== Explicitly specified module resolution kind: 'NodeNext'. Resolving in CJS mode with conditions 'require', 'types', 'node'. Loading module as file / folder, candidate module location 'input/src/foo.mjs', target file types: TypeScript, JavaScript, Declaration. File name 'input/src/foo.mjs' has a '.mjs' extension - stripping it. File 'input/src/foo.mts' does not exist. File 'input/src/foo.d.mts' does not exist. File 'input/src/foo.mjs' does not exist. File 'input/src/foo.mjs.ts' does not exist. File 'input/src/foo.mjs.tsx' does not exist. File 'input/src/foo.mjs.d.ts' does not exist. File 'input/src/foo.mjs.js' does not exist. File 'input/src/foo.mjs.jsx' does not exist. Directory 'input/src/foo.mjs' does not exist, skipping all lookups in it. ======== Module name './src/foo.mjs' was not resolved. ======== ```

turbo-orchestrator bot added needs: triage New issues get this label. Remove it after triage owned-by: turbopack labels Jul 15, 2024

mischnic commented Jul 15, 2024

View reviewed changes

crates/turbopack-core/src/resolve/mod.rs Outdated Show resolved Hide resolved

vercel bot deployed to Preview – examples-nonmonorepo July 15, 2024 09:00 View deployment

vercel bot deployed to Preview – rust-docs July 15, 2024 09:02 View deployment

mischnic added 3 commits July 17, 2024 09:43

Add nodenext resolution test

e098afa

Support module_resolution: "nodenext"

0962bb7

Only allow for .../*.js specifiers

61bb5af

mischnic force-pushed the mischnic/pack-3031-web-995-support-tsconfig-nodenext branch from 904e2f8 to 2e4ee59 Compare July 17, 2024 09:56

turbo-orchestrator bot added created-by: turbopack and removed needs: triage New issues get this label. Remove it after triage labels Jul 17, 2024

Cleanup config loading

847081e

vercel bot deployed to Preview – examples-nonmonorepo July 17, 2024 09:57 View deployment

vercel bot deployed to Preview – rust-docs July 17, 2024 10:01 View deployment

Properly rewrite the pattern

8c02b98

mischnic force-pushed the mischnic/pack-3031-web-995-support-tsconfig-nodenext branch from 1348426 to 8c02b98 Compare July 17, 2024 11:47

vercel bot deployed to Preview – examples-nonmonorepo July 17, 2024 11:47 View deployment

vercel bot deployed to Preview – rust-docs July 17, 2024 11:49 View deployment

mischnic marked this pull request as ready for review July 17, 2024 12:35

mischnic requested a review from a team as a code owner July 17, 2024 12:35

mischnic requested a review from sokra July 18, 2024 12:46

sokra reviewed Jul 18, 2024

View reviewed changes

crates/turbopack-core/src/resolve/mod.rs Outdated Show resolved Hide resolved

sokra reviewed Jul 18, 2024

View reviewed changes

crates/turbopack-core/src/resolve/options.rs Outdated Show resolved Hide resolved

sokra reviewed Jul 18, 2024

View reviewed changes

crates/turbopack-core/src/resolve/pattern.rs Outdated Show resolved Hide resolved

Rename to enable_typescript_with_output_extension

e37969a

vercel bot deployed to Preview – examples-designsystem-docs July 23, 2024 07:07 View deployment

vercel bot deployed to Preview – examples-svelte-web July 23, 2024 07:07 View deployment

vercel bot deployed to Preview – examples-nonmonorepo July 23, 2024 07:07 View deployment

vercel bot deployed to Preview – examples-basic-web July 23, 2024 07:07 View deployment

vercel bot deployed to Preview – examples-native-web July 23, 2024 07:07 View deployment

vercel bot deployed to Preview – examples-tailwind-web July 23, 2024 07:07 View deployment

vercel bot deployed to Preview – examples-gatsby-web July 23, 2024 07:07 View deployment

vercel bot deployed to Preview – examples-kitchensink-blog July 23, 2024 07:07 View deployment

vercel bot deployed to Preview – rust-docs July 23, 2024 07:09 View deployment

Merge branch 'main' into mischnic/pack-3031-web-995-support-tsconfig-…

adfd4d3

…nodenext

vercel bot deployed to Preview – examples-svelte-web July 25, 2024 15:20 View deployment

vercel bot deployed to Preview – examples-vite-web July 25, 2024 15:20 View deployment

vercel bot deployed to Preview – examples-designsystem-docs July 25, 2024 15:20 View deployment

vercel bot deployed to Preview – examples-nonmonorepo July 25, 2024 15:20 View deployment

vercel bot deployed to Preview – examples-native-web July 25, 2024 15:20 View deployment

vercel bot deployed to Preview – examples-kitchensink-blog July 25, 2024 15:21 View deployment

vercel bot deployed to Preview – examples-basic-web July 25, 2024 15:21 View deployment

vercel bot deployed to Preview – examples-gatsby-web July 25, 2024 15:21 View deployment

vercel bot deployed to Preview – examples-tailwind-web July 25, 2024 15:21 View deployment

vercel bot deployed to Preview – rust-docs July 25, 2024 15:22 View deployment

sokra approved these changes Jul 29, 2024

View reviewed changes

sokra merged commit 64e5946 into main Jul 29, 2024
57 of 59 checks passed

sokra deleted the mischnic/pack-3031-web-995-support-tsconfig-nodenext branch July 29, 2024 14:53

timneutkens mentioned this pull request Oct 21, 2024

[WEB-995] Support tsconfig nodenext #4807

Open

mischnic mentioned this pull request Oct 22, 2024

Turbopack: Fix module_resolution: "nodenext" with mjs or cjs vercel/next.js#71635

Merged

unstubbable mentioned this pull request Oct 22, 2024

Read page name from work store in server module map proxy vercel/next.js#71669

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support `module_resolution: "nodenext"` #8748

Support `module_resolution: "nodenext"` #8748

mischnic commented Jul 15, 2024 •

edited

Loading

vercel bot commented Jul 15, 2024 •

edited

Loading

github-actions bot commented Jul 15, 2024 •

edited

Loading

github-actions bot commented Jul 15, 2024 •

edited

Loading

github-actions bot commented Jul 15, 2024 •

edited

Loading

sokra Jul 18, 2024

mischnic Jul 18, 2024

Support module_resolution: "nodenext" #8748

Support module_resolution: "nodenext" #8748

Conversation

mischnic commented Jul 15, 2024 • edited Loading

Description

Testing Instructions

vercel bot commented Jul 15, 2024 • edited Loading

github-actions bot commented Jul 15, 2024 • edited Loading

🟢 Turbopack Benchmark CI successful 🟢

github-actions bot commented Jul 15, 2024 • edited Loading

github-actions bot commented Jul 15, 2024 • edited Loading

⚠️ CI failed ⚠️

sokra Jul 18, 2024

Choose a reason for hiding this comment

mischnic Jul 18, 2024

Choose a reason for hiding this comment

Support `module_resolution: "nodenext"` #8748

Support `module_resolution: "nodenext"` #8748

mischnic commented Jul 15, 2024 •

edited

Loading

vercel bot commented Jul 15, 2024 •

edited

Loading

github-actions bot commented Jul 15, 2024 •

edited

Loading

github-actions bot commented Jul 15, 2024 •

edited

Loading

github-actions bot commented Jul 15, 2024 •

edited

Loading