Fix dtype of condition operation on class objects #4352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsnyder
added a commit
that referenced
this pull request
Jul 10, 2023
wsnyder
reviewed
Jul 10, 2023
RRozak
force-pushed
the
rrozak/fix-cond-dtypep
branch
from
cd923fe
to
ad4dee7
Compare
RRozak
added a commit
to antmicro/uvm-verilator
that referenced
this pull request
Jul 17, 2023
It is already solved: verilator/verilator#4352 Signed-off-by: Ryszard Rozak <rrozak@antmicro.com>
RRozak
added a commit
to antmicro/uvm-verilator
that referenced
this pull request
Jul 17, 2023
It is already solved: verilator/verilator#4352 Signed-off-by: Ryszard Rozak <rrozak@antmicro.com>
RRozak
added a commit
to antmicro/uvm-verilator
that referenced
this pull request
Jul 18, 2023
It is already solved: verilator/verilator#4352 Signed-off-by: Ryszard Rozak <rrozak@antmicro.com>
RRozak
added a commit
to antmicro/uvm-verilator
that referenced
this pull request
Jul 21, 2023
It is already solved: verilator/verilator#4352 Signed-off-by: Ryszard Rozak <rrozak@antmicro.com>
RRozak
added a commit
to antmicro/uvm-verilator
that referenced
this pull request
Jul 21, 2023
It is already solved: verilator/verilator#4352 Signed-off-by: Ryszard Rozak <rrozak@antmicro.com>
RRozak
added a commit
to antmicro/uvm-verilator
that referenced
this pull request
Jul 24, 2023
It is already solved: verilator/verilator#4352 Signed-off-by: Ryszard Rozak <rrozak@antmicro.com>
RRozak
added a commit
to antmicro/uvm-verilator
that referenced
this pull request
Jul 24, 2023
It is already solved: verilator/verilator#4352 Signed-off-by: Ryszard Rozak <rrozak@antmicro.com>
Signed-off-by: Ryszard Rozak <rrozak@antmicro.com>
Signed-off-by: Ryszard Rozak <rrozak@antmicro.com>
Signed-off-by: Ryszard Rozak <rrozak@antmicro.com>
puneet
pushed a commit
to coverify/verilator
that referenced
this pull request
Jul 27, 2023
Signed-off-by: Ryszard Rozak <rrozak@antmicro.com>
RRozak
force-pushed
the
rrozak/fix-cond-dtypep
branch
from
ad4dee7
to
bac9360
Compare
|
I removed the unnecessary copying of the dtype node. Do You think it can be merged now, @wsnyder? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently on master, the dtype of AstNodeCond with expressions of class types is wrong, if the class types aren't the same and if the node was created after V3Width. It doesn't occur if the node was created before V3Width, because the dtype is correctly set in that phase. I mentioned that problem in #4345.
It fixes this problem by using the function from V3Width in constructor of AstNodeCond, instead of taking the dtype of one of its expressions.