-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V3LockGuard: Add constructor for adopting already locked mutex. #4476
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see where this is used, I'm ok with the change, but would prefer not to add dead code that hurts internal coverage. Can you fold this into whatever needs it - or better add a self test case that uses it. Thanks
4402dcb
to
02591f3
Compare
Sure, I've added usage of it, so now this PR requires: #4477 I think I can't really add selfTest for |
82ca71d
to
1a09bc9
Compare
This PR should be ready for review and merge. |
Signed-off-by: Kamil Rakoczy <krakoczy@antmicro.com>
Signed-off-by: Kamil Rakoczy <krakoczy@antmicro.com>
Signed-off-by: Kamil Rakoczy <krakoczy@antmicro.com>
9348e5b
to
ee93908
Compare
Signed-off-by: Kamil Rakoczy <krakoczy@antmicro.com>
Pre-PR to: #4228
Add constructor for adopting already locked mutex.