Skip to content

Add check that model exists during read_blif to avoid seg fault #3287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2025
Merged

Add check that model exists during read_blif to avoid seg fault #3287

merged 1 commit into from
Sep 30, 2025

Conversation

gigeresk
Copy link
Contributor

@gigeresk gigeresk commented Sep 30, 2025 •
edited
Loading

As described in title. This offers feedback when feeding vtr malformed inputs.

@github-actions github-actions bot added VPR VPR FPGA Placement & Routing Tool lang-cpp C/C++ code labels Sep 30, 2025
AlexandreSinger
AlexandreSinger approved these changes Sep 30, 2025
View reviewed changes
Copy link
Contributor

@AlexandreSinger AlexandreSinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @gigeresk

@AlexandreSinger AlexandreSinger merged commit 3cb321b into master Sep 30, 2025
30 checks passed
@AlexandreSinger AlexandreSinger deleted the fredt_check_model_existence branch September 30, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexandreSinger AlexandreSinger AlexandreSinger approved these changes

Assignees
No one assigned
Labels
lang-cpp C/C++ code VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gigeresk @AlexandreSinger