-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSDK-6865 android flag changes #3986
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add support for tflitecpu on android * Update etc/android/build-tflite.sh Co-authored-by: abe-winter <abe-winter@users.noreply.github.com> * pr changes --------- Co-authored-by: abe-winter <abe-winter@users.noreply.github.com>
* working x264 build in etc * factor android make commands to own file, add temp gostream build command * actual working gostream command * video-only makeStreamConfig for no_cgo mode * add patched makeStreamServer to web_notc.go (needs cleanup). move functions from web_c.go -> web.go unchanged: StreamServer, closeStreamServer, initStreamServer, refreshVideoSources, startVideoStream, startStream, propertiesFromStream * build works with arm64 only -- need approach to link x86 as well * removed unneeded flags * x264 architecture: add x86, add armv8-a for linux (remove latter until time to test though) * build separately, merge after (so x264 can link per-platform) * single and multiarch AARs * clean old droidtmp to prevent CRC error from zip * rm temp gostream target * clearer arch lookups in make * include so.NNN in archives * properly handle symlinks in zips, make prefix paths secondary so they don't fail to unlink * soname patch * undo x264 changes before reapply * much simpler android flags for streaming (graphviz is only major copied code) * fix tagging so graphviz_{c,nocgo} are exclusive * gomobile in tools for lint * lose println for lint (PlatformHomeDir is going away for merge anyway) * lint * use NDK_ROOT from environment where present * lint
viambot
added
the
safe to test
This pull request is marked safe to test from a trusted zone
label
May 22, 2024
seanavery
approved these changes
May 22, 2024
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
Why
make droid-rdk.aar
command functionalBuilds tested
with sha 19375ba
make droid-rdk.aar
make full-static
(in shell with no tflite)make server
(retested these to make sure flagging changes didn't break anything)