Rsdk 2930 error when resource not registered

src/viam/resource/manager.py

@@ -3,8 +3,9 @@
 
 from viam.proto.common import ResourceName
 from viam.resource.base import ResourceBase
-from viam.services.service_base import ServiceBase
+from viam.resource.registry import Registry
 
+from ..services.service_base import ServiceBase
 from ..components.component_base import ComponentBase
 from ..errors import DuplicateResourceError, ResourceNotFoundError
 
@@ -40,6 +41,8 @@ def register(self, component: ResourceBase):
         Args:
             component (ResourceBase): The component to register
         """
+        Registry.lookup_subtype(component.SUBTYPE)  # confirm the subtype is registered in Registry
+
         _BaseClasses = (ResourceBase, ComponentBase, ServiceBase)
         rnames: Dict[ResourceName, ResourceBase] = {}
         for subtype in component.__class__.mro():

tests/test_component_service_base.py

@@ -4,9 +4,13 @@
 
 import pytest
 from grpclib import const
+from grpclib.client import Channel
 
 from viam.components.component_base import ComponentBase
+from viam.errors import ResourceNotFoundError
 from viam.operations import run_with_operation
+from viam.resource.registry import Registry, ResourceRegistration
+from viam.resource.rpc_client_base import ReconfigurableResourceRPCClientBase
 from viam.resource.rpc_service_base import ResourceManager, ResourceRPCServiceBase
 from viam.resource.types import Subtype
 
@@ -29,6 +33,10 @@ async def long_running(self, **kwargs) -> bool:
             self.long_running_task_cancelled = False
             return self.long_running_task_cancelled
 
+    class TestClient(TestComponent, ReconfigurableResourceRPCClientBase):
+        def __init__(self, name: str, channel: Channel):
+            ...
+
     class TestService(ResourceRPCServiceBase[TestComponent]):
         RESOURCE_TYPE = TestComponent
 
@@ -37,9 +45,15 @@ async def long_running(self) -> bool:
             return await component.long_running()
 
         def __mapping__(self) -> Mapping[str, const.Handler]:
-            return {}
+            return {
+                "/TestService/long_running": const.Handler(self.long_running, const.Cardinality.UNARY_UNARY, "TestRequest", "TestResponse")
+            }
 
     component = TestComponent("test")
+    with pytest.raises(ResourceNotFoundError):
+        service = TestService(ResourceManager([component]))
+
+    Registry.register_subtype(ResourceRegistration(TestComponent, TestService, lambda name, channel: TestClient(name, channel)))
     service = TestService(ResourceManager([component]))
 
     # Test bare functions