Skip to content

unnormalize api/model name #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2023
Merged

unnormalize api/model name #391

merged 1 commit into from
Aug 21, 2023

Conversation

cheukt
Copy link
Member

@cheukt cheukt commented Aug 18, 2023

to be consistent with rdk

@cheukt cheukt requested a review from a team as a code owner August 18, 2023 21:23
@cheukt cheukt requested review from maximpertsov and stuqdog and removed request for a team August 18, 2023 21:23
maximpertsov
maximpertsov reviewed Aug 18, 2023
View reviewed changes
Copy link
Contributor

@maximpertsov maximpertsov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[opt] would it be worth adding a small test for this?

@cheukt cheukt merged commit dae9517 into rc-0.4.8 Aug 21, 2023
@cheukt cheukt deleted the cheukt-patch-1 branch August 21, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuqdog stuqdog stuqdog approved these changes

+1 more reviewer

@maximpertsov maximpertsov maximpertsov approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cheukt @maximpertsov @stuqdog