Get Geometries fix #402
Closed
Get Geometries fix #402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!
|
cheukt
requested changes
Aug 23, 2023
| Returns: | ||
| List[Geometry]: The geometries associated with the Component. | ||
| """ | ||
| raise NotImplementedError() |
There was a problem hiding this comment.
can we raise the viam unimplemented error here instead? that way we'd get the actual grpc unimplemented status code
cheukt
approved these changes
Aug 23, 2023
|
Closed in favor of #403 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the default implementation for get_geometries.
This won't get merged into main directly, but we'll make a new release off this branch and then merge that in