Use s:TRUE/s:FALSE instead of 1/0 #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vim-vimlparser can be translated into Python and JavaScript which convert number to boolean implicitly, but it's difficlut to translate it into other language which doesn't have implicit type conversion. I actually created translater to Go (ref: vim-jp#26) by including this change. (We need more tweak for Go translater, but this change is one of them) Using s:TRUE/s:FALSE is better not only for translator, but also for readability.
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vim-vimlparser can be translated into Python and JavaScript which
convert number to boolean implicitly, but it's difficlut to translate it
into other language which doesn't have implicit type conversion.
I actually created translater to Go (ref: #26) by including this change.
(We need more tweak for Go translater, but this change is one of them)
Using s:TRUE/s:FALSE is better not only for translator, but also for
readability.