New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Improve color emoji #1

Closed
wants to merge 23 commits into
base: master
from

Conversation

Projects
3 participants
@koron
Member

koron commented Nov 27, 2017

No description provided.

@koron koron added the enhancement label Nov 27, 2017

@koron koron added this to To Do in DirectX optimization ph.2 via automation Nov 27, 2017

@koron koron moved this from To Do to Progress in DirectX optimization ph.2 Nov 27, 2017

@koron koron assigned k-takata, mattn and koron and unassigned k-takata Nov 27, 2017

@codecov

This comment has been minimized.

codecov bot commented Nov 27, 2017

Codecov Report

Merging #1 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #1      +/-   ##
==========================================
+ Coverage   74.49%   74.51%   +0.02%     
==========================================
  Files          91       91              
  Lines      132416   132415       -1     
  Branches    29083    29084       +1     
==========================================
+ Hits        98643    98674      +31     
+ Misses      33748    33712      -36     
- Partials       25       29       +4
Impacted Files Coverage Δ
src/if_xcmdsrv.c 84.17% <0%> (-0.18%) ⬇️
src/if_py_both.h 76.45% <0%> (-0.15%) ⬇️
src/undo.c 82.26% <0%> (-0.07%) ⬇️
src/libvterm/src/screen.c 72.79% <0%> (+0.02%) ⬆️
src/eval.c 81.01% <0%> (+0.04%) ⬆️
src/gui_gtk_x11.c 47.75% <0%> (+0.04%) ⬆️
src/os_unix.c 54.23% <0%> (+0.09%) ⬆️
src/window.c 81.78% <0%> (+0.49%) ⬆️
src/gui_beval.c 63.09% <0%> (+7.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17471e8...1284ddc. Read the comment docs.

k-takata added some commits Nov 27, 2017

Refactor
Add wrapper functions for DrawLine and SetPixel.
@@ -6575,6 +6576,7 @@ clear_rect(RECT *rcp)
#if defined(FEAT_DIRECTX)
if (IS_ENABLE_DIRECTX())
{
DWriteContext_FlushInterop(s_dwc);
DWriteContext_FillRect(s_dwc, rcp, gui.back_pixel);

This comment has been minimized.

@koron

koron Nov 27, 2017

Member

これ(FlushInterop)、いっそのこと FillRect のほうに入れてしまうのはどうでしょう?
たぶん Interop モード中は、DirectXのネイティブの描画はできないんですよね?

  • GDIモード
  • DirectX モード
  • Interop モード

たぶんこの3つのモードがあって、gui_w32.c からみると GDIモードへの遷移だけ Flush で行って
あとのモード間の遷移は gui_dwrite.cpp のなかで閉じてるとスッキリしそうに感じます。

k-takata and others added some commits Nov 28, 2017

Refactor and improve performance
* Do not switch between GDI and Direct2D if not really needed.
  - Implement both GDI and D2D version of FillRect and DrawLine.
Improve performance of SetPixel
Use DrawLine in Direct2D mode instead of SetPixel.
Merge pull request #2 from vim-jp/drawing-mode
introduce DrawingMode to reduce switching
Use redrawing instead of scrolling when DirectX is used
It seems that redrawing is much faster than scrolling when DirectX is
used.
Add srclines option to 'renderoptions'
Make it customizable whether ScrollWindowEx or RedrawWindow is used.
Add error check for D2DERR_RECREATE_TARGET
Need to recreate the render taget when the error is returned.
@koron

This comment has been minimized.

Member

koron commented on src/gui_dwrite.cpp in 3737225 Dec 2, 2017

元からやってなかったのでアレなんですけど、
mRT だけ作れて mBrush ができてない状況が
チェックなしでスルーされちゃいますね…

どうするのが良いのだろう?

This comment has been minimized.

Member

k-takata replied Dec 2, 2017

そんな変な状況、あまり考えたくないですね…。
今の作りだと DWriteContext のコンストラクタでエラーが起きてもちゃんとエラーハンドリングされない訳か。

k-takata added some commits Dec 2, 2017

doc: Rewrite description for scrlines
Most part is written by koron.
@k-takata

This comment has been minimized.

Member

k-takata commented Dec 2, 2017

投げました。 vim#2401
協力ありがとうございました。

@k-takata k-takata closed this Dec 2, 2017

DirectX optimization ph.2 automation moved this from Progress to Done Dec 2, 2017

@k-takata

This comment has been minimized.

Member

k-takata commented Dec 2, 2017

vim#2401 に日本語コメントが表示されてしまっているな。ま、いいっか?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment