Skip to content

WIP: Improve color emoji #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 23 commits into from
Closed

WIP: Improve color emoji #1

wants to merge 23 commits into from

Conversation

koron
Copy link
Member

@koron koron commented Nov 27, 2017

No description provided.

@koron koron assigned k-takata, mattn and koron and unassigned k-takata Nov 27, 2017
@codecov
Copy link

codecov bot commented Nov 27, 2017

Codecov Report

Merging #1 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #1      +/-   ##
==========================================
+ Coverage   74.49%   74.51%   +0.02%     
==========================================
  Files          91       91              
  Lines      132416   132415       -1     
  Branches    29083    29084       +1     
==========================================
+ Hits        98643    98674      +31     
+ Misses      33748    33712      -36     
- Partials       25       29       +4
Impacted Files Coverage Δ
src/if_xcmdsrv.c 84.17% <0%> (-0.18%) ⬇️
src/if_py_both.h 76.45% <0%> (-0.15%) ⬇️
src/undo.c 82.26% <0%> (-0.07%) ⬇️
src/libvterm/src/screen.c 72.79% <0%> (+0.02%) ⬆️
src/eval.c 81.01% <0%> (+0.04%) ⬆️
src/gui_gtk_x11.c 47.75% <0%> (+0.04%) ⬆️
src/os_unix.c 54.23% <0%> (+0.09%) ⬆️
src/window.c 81.78% <0%> (+0.49%) ⬆️
src/gui_beval.c 63.09% <0%> (+7.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17471e8...1284ddc. Read the comment docs.

src/gui_w32.c Outdated
@@ -6575,6 +6576,7 @@ clear_rect(RECT *rcp)
#if defined(FEAT_DIRECTX)
if (IS_ENABLE_DIRECTX())
{
DWriteContext_FlushInterop(s_dwc);
DWriteContext_FillRect(s_dwc, rcp, gui.back_pixel);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これ(FlushInterop)、いっそのこと FillRect のほうに入れてしまうのはどうでしょう?
たぶん Interop モード中は、DirectXのネイティブの描画はできないんですよね?

  • GDIモード
  • DirectX モード
  • Interop モード

たぶんこの3つのモードがあって、gui_w32.c からみると GDIモードへの遷移だけ Flush で行って
あとのモード間の遷移は gui_dwrite.cpp のなかで閉じてるとスッキリしそうに感じます。

k-takata and others added 16 commits November 28, 2017 12:29
* Do not switch between GDI and Direct2D if not really needed.
  - Implement both GDI and D2D version of FillRect and DrawLine.
Use DrawLine in Direct2D mode instead of SetPixel.
introduce DrawingMode to reduce switching
It seems that redrawing is much faster than scrolling when DirectX is
used.
Make it customizable whether ScrollWindowEx or RedrawWindow is used.
Need to recreate the render taget when the error is returned.
Most part is written by koron.
@k-takata
Copy link
Member

k-takata commented Dec 2, 2017

投げました。 vim#2401
協力ありがとうございました。

@k-takata k-takata closed this Dec 2, 2017
@k-takata
Copy link
Member

k-takata commented Dec 2, 2017

vim#2401 に日本語コメントが表示されてしまっているな。ま、いいっか?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants