Skip to content

0022 patch expo sqlite web

github-actions[bot] edited this page Nov 18, 2026 · 3 revisions

expo-sqlite is patched so the web build reuses one buffer

Status: accepted · Implementation: done · Date: 2026-11-18

From LibreLifts ADR 0036; the patch is the one written there, for expo-sqlite 58.0.18. It has not been reported to Expo; sending a report is the maintainer's call. As built, 2026-11-18: the patch is applied on install, unchanged from LibreLifts, and the web build opens its database. The burst of writes it exists for has not been shown again here, because there are no screens to log with yet, so this stays planned. Shown again here on 2026-11-18, in Chromium: 300 sets added to one workout in under four seconds, each a transaction of its own followed by the screen reading the workout again, with no error and 301 rows on screen; then the workout was discarded, which marks every one of them. The page was not run without the patch for comparison.

Context

The app reads and writes its database with synchronous calls (0018). In the browser, expo-sqlite runs SQLite in a worker, and each synchronous call makes a new one-megabyte shared buffer for the answer. None of those buffers is freed until the page and the worker are both idle.

LibreLifts found what follows from that. A burst of calls runs the page out of memory. The call that fails is often in the middle of a transaction, and the rollback fails for the same reason. The transaction then stays open, every later one is refused, and the app shows an error until the page is reloaded. iOS and Android are not affected.

LibreBars keeps the web build (0007), so it has the same problem.

Decision

  • expo-sqlite is patched with pnpm's patchedDependencies so that synchronous calls in the browser share one result buffer and one lock. The patch is patches/expo-sqlite@58.0.18.patch and changes one file, web/WorkerChannel.ts.
  • It is safe because calls happen one at a time and the answer is copied out of the buffer before the call returns. If a call times out, the buffers are dropped and the next call gets new ones.
  • The app also batches its writes on every platform: several rows of one table go in one statement, with their outbox notes in another.
  • The patch is tied to the exact version. Updating expo-sqlite means checking whether the patch is still needed and making it again if it is.

Consequences

  • A burst of writes does not break the web build. In LibreLifts this was tested with 150 workouts logged in one go and 2,550 changes sent afterwards; it has to be shown again here.
  • The project carries a patch to a dependency. pnpm fails the install if the patch no longer applies, so it cannot be dropped silently.
  • expo-sqlite cannot be updated without looking at the patch.
  • This is made for the web build alone, against the rule that nothing is. It is allowed because without it the web build loses data. It goes when the web build goes.

LibreBars

Clone this wiki locally