Skip to content

Cruft #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 24, 2025
Merged

Cruft #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4138469
cruft update
viseshrp May 24, 2025
92c9749
cruft update
viseshrp May 24, 2025
d653b99
Merge branch 'main' into cruft
viseshrp May 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .cruft.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"template": "https://github.com/viseshrp/yapc",
"commit": "10c7cc76029dfab48a5de100faefdb86fde02a90",
"commit": "6f03acb04ca70ea6abbbdd8aca5caadd9e780834",
"checkout": null,
"context": {
"cookiecutter": {
Expand All @@ -16,7 +16,7 @@
"git_init": "n",
"github_actions": "y",
"_template": "https://github.com/viseshrp/yapc",
"_commit": "10c7cc76029dfab48a5de100faefdb86fde02a90"
"_commit": "6f03acb04ca70ea6abbbdd8aca5caadd9e780834"
}
},
"directory": null
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ version: ## Print the current project version
.PHONY: tag
tag: ## 🏷 Tag the current release version (stripping .dev) and push
@echo "🏷 Creating signed Git tag: v$(VERSION)"
git tag -s v$(VERSION) -m "Release v$(VERSION)"
git tag v$(VERSION) -m "Release v$(VERSION)"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This change removes the -s flag from the git tag command. The -s flag is used to create a signed tag using the committer's GPG key. Removing it means the tags created by this target will no longer be cryptographically signed.

Signed tags provide a way to verify the integrity and origin of a release tag. Was the removal of signed tags intentional? If so, could you please explain the reasoning? If not, it's generally recommended to sign release tags for security and trust purposes.

	git tag -s v$(VERSION) -m "Release v$(VERSION)"

git push origin v$(VERSION)

.PHONY: check-dist
Expand Down