[ts] QuadkeyLayer and GeoCellLayer translated to typescript. #6822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbigg
force-pushed
the
zbigg/typescript-quadkey-layer
branch
5 times, most recently
from
d0190da
to
880d4b4
Compare
zbigg
commented
Apr 14, 2022
| * | ||
| * Note that both the outer polygon as well the outlines of any holes will be drawn. | ||
| */ | ||
| stroked: boolean; |
There was a problem hiding this comment.
Re: duplication of doc
While learning what these mean i've automatically copied docs from markdown.
This is some kind of compromise, between wanting good UX in IDEs showing docs and duplication.
Please comment if this is desirable and/or if we should maybe make this doc more terse.
| lineDashJustified: boolean; | ||
|
|
||
| /** Called on each object in the data stream to retrieve its corresponding polygon. */ | ||
| getPolygon: AccessorFunction<DataT, any>; |
There was a problem hiding this comment.
@Pessimistress Shall we define Polygon analogous to Position defined in #6803
| @@ -18,7 +18,15 @@ export type AccessorContext<T> = { | |||
| target: number[]; | |||
| }; | |||
|
|
|||
| export type Accessor<In, Out> = Out | ((object: In, objectInfo: AccessorContext<In>) => Out); | |||
| export type AccessorFunction<In, Out> = (object: In, objectInfo: AccessorContext<In>) => Out; | |||
There was a problem hiding this comment.
In some cases, we support only dynamic accessor (not sure if that's indended or not, that's helpful).
zbigg
force-pushed
the
zbigg/typescript-quadkey-layer
branch
3 times, most recently
from
3f46103
to
8c67eef
Compare
zbigg
force-pushed
the
zbigg/typescript-quadkey-layer
branch
3 times, most recently
from
d03c505
to
49a5075
Compare
zbigg
force-pushed
the
zbigg/typescript-quadkey-layer
branch
from
49a5075
to
2af4f0a
Compare
zbigg
force-pushed
the
zbigg/typescript-quadkey-layer
branch
from
2af4f0a
to
0108b0a
Compare
| import SolidPolygonLayer from '../solid-polygon-layer/solid-polygon-layer'; | ||
| import PathLayer from '../path-layer/path-layer'; | ||
| import * as Polygon from '../solid-polygon-layer/polygon'; | ||
| import {replaceInRange} from '../utils'; | ||
|
|
||
| // TODO: not sure where this type belongs to |
There was a problem hiding this comment.
This should be defined by core's lighting shader module. You can leave it as is for now.
Pessimistress
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #5589
Change List: