Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add(widgets) fullscreen widget #8024
add(widgets) fullscreen widget #8024
Changes from all commits
fc6be2c
cd67293
18835f1
2fa64ad
fceab53
bfa10b6
adfc21a
46be41a
f37b35e
024d1bc
3caa7e8
e07fd97
debbf1e
f43cfdd
ed185ff
f135eca
a5cd7b4
efd612e
2f31eca
004c0aa
e02624b
a87c7f9
ee7a365
bda7bcd
f9cc7ab
8df067a
a7aabfe
24ce65d
4791fb8
a6f6268
24bf325
73afafd
61d2f55
bca3b89
17b6c13
eebc3ad
993d850
ed1906d
814762f
9d0ecc0
5f70324
cb72e2c
59b1a56
03dda1e
254b319
01d5c39
e30fc53
c641626
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Pessimistress I was thinking of move these variations to a test app. I want to maintain coverage for edge cases somewhere, and keep getting started very simple. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes agreed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, I haven't really being paying attention. Are we using a react style library for our pure-js implementation? And then we will have react wrappers on top?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty certain we don't want the complexity or bundle size of react, but I like its api style.
My goal has been to pick something as close to the DOM as we can while also providing some convenience over
document.createElement
.preact
seems to serve this niche well... It give us the ability to make basic components with JSX, and implements a thin virtual dom only adding 3kb to the bundle.Re: react wrappers, I think of a widget as a deck component that happens to have UI. In a sense, how the UI is built within it is ideally isolated from other UI on the page so that deck can manage it. Let's say we used react to make UI widgets in
@deckgl/widgets
... I'd still ideally want them to create their own react root separate from the rest of application and other widgets. This way all integrations work through the same interface.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood and I agree with the principle that widgets should be free to choose implementation as long as they are externally independent. That said, I would not be happy to see a pure-js deck.gl module have react as a dependency in its package.json. I would think twice before using that in a pure-js app.
For a community widget that could be a different story of course.
preact seems like a reasonable choice.