Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to Vite 3.1.0 #370

Closed
wants to merge 3 commits into from
Closed

feat: upgrade to Vite 3.1.0 #370

wants to merge 3 commits into from

Conversation

userquin
Copy link
Member

@userquin userquin commented Sep 6, 2022

This PR includes:

  • migrate to Vite 3.1.0
  • added packages for new core (just empty and configure to use unbuild) and vite-plugin-pwa
  • updated all dependencies with taze major -r -w
  • updated docs to use the latest VitePress: using the buildEnd hook to build the pwa
  • included new sequential closeBundle hook on build plugin with default order: will help to configure the new SvelteKit
  • tested all examples with prompt strategy except sveltekit that should be removed from the examples folder: react/preact/solid/svelte/vue

/cc @antfu I change the name of plugin in the root package.json with @vite-pwa: you should review all the scripts in the new vite-plugin-pwa package.

DON'T FORGET TO REVIEW THE RELEASE SCRIPTS

/cc @benmccann

superseded by #371

@netlify
Copy link

netlify bot commented Sep 6, 2022

Deploy Preview for vite-plugin-pwa ready!

Name Link
🔨 Latest commit a5cebb4
🔍 Latest deploy log https://app.netlify.com/sites/vite-plugin-pwa/deploys/6317f20c3fa4e4000844bb55
😎 Deploy Preview https://deploy-preview-370--vite-plugin-pwa.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@userquin userquin requested a review from antfu September 6, 2022 22:35
@userquin
Copy link
Member Author

userquin commented Sep 7, 2022

@antfu review the types please

EDIT: you can check the integration here https://github.com/userquin/pwa-sveltekit-vite (the adapter fails, we need to update the kit version to latest, failing on my local running the posinstall script)

/cc @benmccann

This was referenced Sep 7, 2022
@userquin userquin marked this pull request as draft September 8, 2022 19:02
@userquin
Copy link
Member Author

userquin commented Sep 8, 2022

we can close this PR

@userquin userquin closed this Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant